UI-DEN-16288-1 UI-DEN-16288_UI BN S104 [ ready - application ]

closed on 19 Oct 23

Author

Moderator

Reviewers

Dara Navaei
vduong (deleted user)
jreaume (deleted user)
msuleiman (deleted user)
jpaguio (deleted user)

UI-DEN-16288_UI BN S104 [ ready - application ]

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 33

application 0
- Folder sources 0
  - Folder device 0
    - File DeviceController.cpp 6 Remove
    - File DeviceController.h 0 Remove
    - File DeviceModels.h 0 Remove
    - File DeviceView.cpp 0 Remove
    - File DeviceView.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder dialogs 0
        
        File ConfirmDialog.qml 3 Remove
        
        File PowerOff.qml 0 Remove
      - Folder pages 0
        
        Folder endtreatment/rinseback 0
        
        File EndTreatmentRinsebackInit.qml 0 Remove
        
        Folder pretreatment 0
        
        File PreTreatmentConsumablesStack.qml 0 Remove
        
        File PreTreatmentPrimeStack.qml 0 Remove
        
        Folder settings 0
        
        File SettingsDecommission.qml 0 Remove
        
        File SettingsDeviceRegistration.qml 0 Remove
        
        File SettingsExportLogs.qml 0 Remove
        
        File SettingsFactoryReset.qml 0 Remove
        
        File SettingsInformation.qml 0 Remove
        
        File SettingsRootSSHAccess.qml 3 Remove
        
        File SettingsServicePassword.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
      - File AlarmItem.qml 3 Remove
      - File PowerItem.qml 3 Remove
      - File main.qml 0 Remove
    - File GuiController.h 0 Remove
  - Folder model/hd/adjustment/settings 0
    - File MAdjustHDRequests.h 0 Remove
  - Folder storage 0
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
  - Folder utility 0
    - File encryption.cpp 0 Remove
  - Folder view/settings 0
    - File VSettings.cpp 3 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File ApplicationPost.cpp 0 Remove
  - File ApplicationPost.h 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	45m	9	Since Vy is busy and it is not a code change and is only ...
Michael Garthwaite	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
Sean Nash	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 6% reviewed	2m	1	RESOLVED
vduong (deleted user)	Reviewer - Complete	58m	11	RESOLVED
jreaume (deleted user)	Reviewer - 0% reviewed
msuleiman (deleted user)	Reviewer - Complete	20m	3	RESOLVED
jpaguio (deleted user)	Reviewer - 0% reviewed
Total		2h 6m	24

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee
DEN-16411

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-16288-1

UI-DEN-16288_UI BN S104 [ ready - application ]

UI-DEN-16288-1 24

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-16288_UI BN S104 [ ready - application ]

UI-DEN-16288-1 24

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time