Fisheye on application/sources/view/settings/VAdjustmentAlarmVolume.cpp https://devapps.diality.us/changelog/~br%3Dfeature%25402fUI-MS-S117-Integration/application/sources/view/settings/VAdjustmentAlarmVolume.cpp Recent activity in "application" under directory /sources/view/settings/VAdjustmentAlarmVolume.cpp UI-DEN-15279-1: closed by Dara Navaei Thu, 19 Oct 2023 10:36:25 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1 https://devapps.diality.us/cru/UI-DEN-15279-1 Dara Navaei Closed UI-DEN-15279-1 ]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:36:13 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19159 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19159 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:35:11 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19158 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19158 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:57 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19157 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19157 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:17 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19156 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19156 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:12 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19155 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19155 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:33:04 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19154 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19154 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:32:36 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1/#c19153 https://devapps.diality.us/cru/UI-DEN-15279-1/#c19153 Dara Navaei replied to Behrouz NematiPour in UI-DEN-15279-1

RESOLVED

]]> UI-DEN-15279-1: started by Dara Navaei Thu, 19 Oct 2023 10:31:30 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-15279-1 https://devapps.diality.us/cru/UI-DEN-15279-1 Dara Navaei started review UI-DEN-15279-1 ]]> UI-UCOMMITS-5: closed by Dara Navaei Thu, 14 Sep 2023 09:49:54 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei Closed UI-UCOMMITS-5 ]]> UI-UCOMMITS-5: reviewers finished Thu, 14 Sep 2023 09:34:21 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei finished reviewing UI-UCOMMITS-5 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-5: reviewers finished Thu, 17 Aug 2023 08:39:14 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Sean Nash finished reviewing UI-UCOMMITS-5 UI Staging Unreviewed Commits ]]> UI-DEN-15833-10: closed by vduong Tue, 08 Aug 2023 13:45:12 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 vduong  (deleted user) Closed UI-DEN-15833-10 ]]> UI-DEN-15833-10: reviewers finished Tue, 08 Aug 2023 13:44:03 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 Behrouz NematiPour and Tiffany Mejia finished reviewing UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> UI-DEN-15833-10: reviewers added to UI-DEN-15833_UI VD S101 - UI - Post Settings Check... Tue, 08 Aug 2023 11:46:32 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 Behrouz NematiPour added jpaguio  (deleted user) to UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> UI-DEN-15833-10: reviewers finished Sun, 06 Aug 2023 19:54:26 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 msuleiman  (deleted user) finished reviewing UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> UI-DEN-15833-10: reviewers joined UI-DEN-15833_UI VD S101 - UI - Post Settings Check... Sun, 06 Aug 2023 19:53:12 -0700 https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 msuleiman  (deleted user) joined UI-DEN-15833-10 UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ] ]]> UI-DEN-15833-10: started by Behrouz NematiPour Sun, 06 Aug 2023 18:41:07 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10 Behrouz NematiPour started review UI-DEN-15833-10 ]]> UI-UCOMMITS-5: started by Dara Navaei Sun, 06 Aug 2023 12:23:06 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-5 https://devapps.diality.us/cru/UI-UCOMMITS-5 Dara Navaei started review UI-UCOMMITS-5 ]]> UI-DEN-15833-10: comment by Behrouz NematiPour "Thanks for reminding me the situation with the ..." Tue, 01 Aug 2023 18:23:29 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18361 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18361 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-15833-10

Thanks for reminding me the situation with the comment.
that is right in View classes we need to.
maybe later we can move these checks all in the settings controller, from this view.

RESOLVED.

]]> UI-DEN-15833-10: comment by Behrouz NematiPour "RESOLVED" Tue, 01 Aug 2023 18:23:00 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18360 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18360 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-15833-10

RESOLVED

]]> UI-DEN-15833-10: comment by Behrouz NematiPour "RESOLVED" Tue, 01 Aug 2023 18:22:39 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18359 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18359 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-15833-10

RESOLVED

]]> UI-DEN-15833-10: comment by Behrouz NematiPour "RESOLVED" Tue, 01 Aug 2023 18:22:00 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18357 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18357 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-15833-10

RESOLVED

]]> UI-DEN-15833-10: comment by Behrouz NematiPour "RESOLVED" Tue, 01 Aug 2023 18:21:20 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18356 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18356 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-15833-10

RESOLVED

]]> UI-DEN-15833-10: comment by vduong "Changed" Fri, 28 Jul 2023 05:35:55 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10/#c18311 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18311 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-15833-10

Changed

]]> UI-DEN-15833-10: comment by vduong "Added." Fri, 28 Jul 2023 05:35:20 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10/#c18310 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18310 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-15833-10

Added.

]]> UI-DEN-15833-10: comment by vduong "Added." Fri, 28 Jul 2023 05:35:14 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10/#c18309 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18309 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-15833-10

Added.

]]> UI-DEN-15833-10: comment by vduong "Changed based on how GuiView handles the connec..." Fri, 28 Jul 2023 05:34:25 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10/#c18308 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18308 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-15833-10

Changed based on how GuiView handles the connection from a created-in-QML object.

]]> UI-DEN-15833-10: comment by vduong "This I will align similar to how the others loo..." Fri, 28 Jul 2023 05:00:56 -0700 vduong https://devapps.diality.us/cru/UI-DEN-15833-10/#c18307 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18307 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-15833-10

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

]]> UI-DEN-15833-10: comment by Behrouz NematiPour "this is incorrect connection usage. it should ..." Fri, 28 Jul 2023 01:43:36 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-15833-10/#c18298 https://devapps.diality.us/cru/UI-DEN-15833-10/#c18298 Behrouz NematiPour commented on UI-DEN-15833-10

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

]]>