Fisheye on hdfirmware/firmware/App/Drivers/Comm.h https://devapps.diality.us/changelog/~br%3Dleo-sprint-development/hdfirmware/firmware/App/Drivers/Comm.h Recent activity in "hdfirmware" under directory /firmware/App/Drivers/Comm.h HD-DEN-5674-2: closed by Dara Navaei Thu, 19 Oct 2023 08:18:11 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Dara Navaei Closed HD-DEN-5674-2 ]]> HD-DEN-5674-2: reviewers finished Thu, 19 Oct 2023 08:18:03 -0700 https://devapps.diality.us/cru/HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Dara Navaei finished reviewing HD-DEN-5674-2 HD-DEN-5674_Alarm Design (3 of 4) ]]> HD-DEN-5674-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:17:53 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-5674-2/#c19103 https://devapps.diality.us/cru/HD-DEN-5674-2/#c19103 Dara Navaei replied to Sean Nash in HD-DEN-5674-2

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-5674-2: started by Dara Navaei Thu, 19 Oct 2023 08:16:11 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Dara Navaei started review HD-DEN-5674-2 ]]> HD-UCOMMITS-20: closed by Sean Nash Thu, 03 Aug 2023 09:52:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Sean Nash Closed HD-UCOMMITS-20 ]]> HD-UCOMMITS-20: reviewers finished Thu, 03 Aug 2023 09:29:51 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Dara Navaei finished reviewing HD-UCOMMITS-20 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-19: closed by Sean Nash Thu, 03 Aug 2023 08:57:40 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Sean Nash Closed HD-UCOMMITS-19 ]]> HD-UCOMMITS-19: reviewers finished Wed, 02 Aug 2023 21:26:40 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-20: reviewers finished Wed, 02 Aug 2023 12:17:59 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Sean Nash finished reviewing HD-UCOMMITS-20 HD Staging Unreviewed Commits ]]> HD-DEN-15104-1: closed by wbracken Mon, 15 May 2023 13:43:03 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15104-1 https://devapps.diality.us/cru/HD-DEN-15104-1 wbracken  (deleted user) Closed HD-DEN-15104-1 ]]> HD-DEN-15104-1: reviewers finished Mon, 15 May 2023 11:35:15 -0700 https://devapps.diality.us/cru/HD-DEN-15104-1 https://devapps.diality.us/cru/HD-DEN-15104-1 dcox  (deleted user) , jtaylor  (deleted user) and Sean Nash finished reviewing HD-DEN-15104-1 HD-DEN-15104_HD Fpga Communications ]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Sun, 14 May 2023 15:11:39 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17461 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17461 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Sun, 14 May 2023 15:10:56 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17460 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17460 Sean Nash replied to Sean Nash in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Sun, 14 May 2023 15:09:10 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17459 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17459 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by wbracken "Moved to here from function." Sun, 14 May 2023 12:39:51 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15104-1/#c17454 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17454 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15104-1

Moved to here from function.

]]> HD-DEN-15104-1: comment by wbracken "No longer needed." Sun, 14 May 2023 11:28:55 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15104-1/#c17445 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17445 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15104-1

No longer needed.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:33:22 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17441 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17441 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:32:24 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17440 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17440 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:31:43 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17439 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17439 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:31:30 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17438 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17438 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:31:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17437 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17437 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:30:37 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17436 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17436 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:30:09 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17435 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17435 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "Per my other comment, please avoid in-function ..." Fri, 12 May 2023 17:29:26 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17434 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17434 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

Per my other comment, please avoid in-function static variables.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:28:47 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17433 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17433 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "Not a fan of in function statics. Probably due..." Fri, 12 May 2023 17:28:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17432 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17432 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:27:07 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17431 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17431 Sean Nash replied to Sean Nash in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 12 May 2023 17:26:44 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17430 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17430 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-15104-1: comment by Sean Nash "Now it's gone. No longer needed?" Fri, 12 May 2023 17:26:08 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-15104-1/#c17429 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17429 Sean Nash replied to wbracken  (deleted user) in HD-DEN-15104-1

Now it's gone. No longer needed?

]]> HD-DEN-15104-1: comment by wbracken "Removed" Fri, 12 May 2023 13:22:56 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-15104-1/#c17423 https://devapps.diality.us/cru/HD-DEN-15104-1/#c17423 wbracken  (deleted user) replied to Sean Nash in HD-DEN-15104-1

Removed

]]>