Fisheye on dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.h

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-2650-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:42:37 -0700

Dara Navaei Closed DG-DEN-2650-1

DG-DEN-2650-1: reviewers finished

Thu, 19 Oct 2023 08:42:03 -0700

Dara Navaei finished reviewing DG-DEN-2650-1

DG-DEN-2650_DG Firmware Infrastructure

DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:41:49 -0700

Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2650-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:41:19 -0700

Dara Navaei started review DG-DEN-2650-1

DG-DEN-9480-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:05:20 -0700

Dara Navaei Closed DG-DEN-9480-1

DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:05:10 -0700

Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:03:54 -0700

Dara Navaei started review DG-DEN-9480-1

DG-DEN-14604-1: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:46:43 -0700

Dara Navaei Closed DG-DEN-14604-1

DG-DEN-14604-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 20:46:29 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14604-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14604-1: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 20:45:20 -0700

Dara Navaei started review DG-DEN-14604-1

DG-DIAL-283-1: closed by Dara Navaei

Dara Navaei — Thu, 14 Sep 2023 09:49:26 -0700

Dara Navaei Closed DG-DIAL-283-1

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 14 Sep 2023 09:29:29 -0700

Dara Navaei committed 5459a8a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

DG-DIAL-283-1: reviewers finished

Thu, 14 Sep 2023 09:00:11 -0700

Dara Navaei and wbracken (deleted user) finished reviewing DG-DIAL-283-1

DG-DIAL-283_NO Moving Average Commands Conductivity

DG-DIAL-283-1: reviewers finished

Tue, 12 Sep 2023 10:12:50 -0700

jtaylor (deleted user) finished reviewing DG-DIAL-283-1

DG-DIAL-283_NO Moving Average Commands Conductivity

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: compiler fixes.

Michael Garthwaite — Mon, 11 Sep 2023 14:00:50 -0700

Michael Garthwaite committed 3c5e5fb on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DIAL-283: compiler fixes.

· /firmware/App/Modes/ModeChemicalDisinfect.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: message handling for moving average override.

Michael Garthwaite — Mon, 11 Sep 2023 13:59:11 -0700

Michael Garthwaite committed 3fc8744 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DIAL-283: message handling for moving average override.

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-10, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

DG-DIAL-283-1: started by Dara Navaei

Dara Navaei — Mon, 11 Sep 2023 12:05:53 -0700

Dara Navaei started review DG-DIAL-283-1

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 03 Feb 2023 13:48:44 -0800

Dara Navaei committed 56ba1b1 on branch DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 161 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-14604-1: reviewers finished

Fri, 03 Feb 2023 12:51:29 -0800

Sean Nash and wbracken (deleted user) finished reviewing DG-DEN-14604-1

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9

DG-DEN-14604-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 03 Feb 2023 12:49:34 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14604-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 03 Feb 2023 11:12:08 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14604-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14604-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 03 Feb 2023 10:55:02 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14604-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14604-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 03 Feb 2023 10:49:23 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14604-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1: comment by Dara Navaei "Done"

Dara Navaei — Fri, 03 Feb 2023 10:35:22 -0800

Dara Navaei replied to Sean Nash in DG-DEN-14604-1

Done

DG-DEN-14604-1: comment by Dara Navaei "Done"

Dara Navaei — Fri, 03 Feb 2023 10:32:15 -0800

Dara Navaei replied to Sean Nash in DG-DEN-14604-1

Done

DG-DEN-14604-1: comment by Sean Nash "The enum comments are now non-doxygen style, bu..."

Sean Nash — Fri, 03 Feb 2023 10:19:02 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14604-1

The enum comments are now non-doxygen style, but the enum is still in the group. Move it below the /*@}/ to get it out of HeatersState group.

DG-DEN-14604-1: comment by Dara Navaei "Done"

Dara Navaei — Fri, 03 Feb 2023 10:20:19 -0800

Dara Navaei replied to Sean Nash in DG-DEN-14604-1

Done

DG-DEN-14604-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 03 Feb 2023 10:20:04 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14604-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 03 Feb 2023 10:19:53 -0800

Sean Nash replied to Dara Navaei in DG-DEN-14604-1

RESOLVED in CODE WALKTHROUGH.