Fisheye on dgfirmware/firmware/App/Services/Integrity.c https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/firmware/App/Services/Integrity.c Recent activity in "dgfirmware" under directory /firmware/App/Services/Integrity.c DG-DEN-8103-1: closed by qnguyen Fri, 25 Jun 2021 16:45:22 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1 https://devapps.diality.us/cru/DG-DEN-8103-1 qnguyen  (deleted user) Closed DG-DEN-8103-1 ]]> DG-DEN-8103-1: reviewers finished Fri, 25 Jun 2021 14:11:00 -0700 https://devapps.diality.us/cru/DG-DEN-8103-1 https://devapps.diality.us/cru/DG-DEN-8103-1 Dara Navaei and pmontazemi  (deleted user) finished reviewing DG-DEN-8103-1 DG-DEN-8103_DG HD Dev Alarm Design ]]> DG-DEN-8103-1: reviewers resumed Wed, 16 Jun 2021 15:03:31 -0700 https://devapps.diality.us/cru/DG-DEN-8103-1 https://devapps.diality.us/cru/DG-DEN-8103-1 Sean Nash resumed reviewing DG-DEN-8103-1 DG-DEN-8103_DG HD Dev Alarm Design ]]> DG-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:36:48 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10200 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10200 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:36:24 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10199 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10199 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:36:13 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10198 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10198 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:35:58 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10197 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10197 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8103-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 03 Jun 2021 10:35:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10196 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10196 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8103-1: comment by qnguyen "Good point. The module has been moved to fwcomm..." Sat, 29 May 2021 01:16:41 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1/#c10171 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10171 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-8103-1

Good point. The module has been moved to fwcommon.

]]> DG-DEN-8103-1: comment by qnguyen "Removed the wrapper function. For now, only sup..." Sat, 29 May 2021 01:16:06 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1/#c10170 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10170 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-8103-1

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

]]> DG-DEN-8103-1: comment by qnguyen "Done." Fri, 28 May 2021 16:39:35 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1/#c10141 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10141 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-8103-1

Done.

]]> DG-DEN-8103-1: comment by qnguyen "Noe said they updated the ID and this is the ne..." Fri, 28 May 2021 16:31:56 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1/#c10140 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10140 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-8103-1

Noe said they updated the ID and this is the new ID for DG FPGA.
The FPGA test will fail without this change.

]]> DG-DEN-8103-1: comment by Sean Nash "Should mention somewhere that timer is counting..." Fri, 28 May 2021 15:20:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10136 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10136 Sean Nash commented on DG-DEN-8103-1

Should mention somewhere that timer is counting ms.

]]> DG-DEN-8103-1: comment by Sean Nash "Why did this change?" Fri, 28 May 2021 15:19:09 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10135 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10135 Sean Nash commented on DG-DEN-8103-1

Why did this change?

]]> DG-DEN-8103-1: comment by Sean Nash "Is there a reason why this module isn't in fwco..." Fri, 28 May 2021 15:14:59 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10133 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10133 Sean Nash commented on DG-DEN-8103-1

Is there a reason why this module isn't in fwcommon? And if it can't be common for some reason, should this module (or group name) be named DGIntegrity?

]]> DG-DEN-8103-1: comment by Sean Nash "Do we need to support more than one 32-bit CRC ..." Fri, 28 May 2021 15:18:18 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c10134 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10134 Sean Nash commented on DG-DEN-8103-1

Do we need to support more than one 32-bit CRC algorithm in firmware? If not, do we need this wrapper function?

]]> DG-DEN-8103-1: comment by qnguyen "Done." Thu, 27 May 2021 10:34:11 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1/#c10130 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10130 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-8103-1

Done.

]]> DG-DEN-8103-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 27 May 2021 10:30:49 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-8103-1/#c10124 https://devapps.diality.us/cru/DG-DEN-8103-1/#c10124 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in DG-DEN-8103-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8103-1: comment by qnguyen "The only preference is to put TRUE first if it ..." Thu, 20 May 2021 11:24:50 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1/#c9993 https://devapps.diality.us/cru/DG-DEN-8103-1/#c9993 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in DG-DEN-8103-1

The only preference is to put TRUE first if it is == such as below.

]]> DG-DEN-8103-1: comment by Sean Nash "Should we move this enum to separate .h file?" Wed, 19 May 2021 17:15:03 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8103-1/#c9981 https://devapps.diality.us/cru/DG-DEN-8103-1/#c9981 Sean Nash commented on DG-DEN-8103-1

Should we move this enum to separate .h file?

]]> DG-DEN-8103-1: comment by pmontazemi "Place TRUE as first argument." Wed, 19 May 2021 15:35:33 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-8103-1/#c9965 https://devapps.diality.us/cru/DG-DEN-8103-1/#c9965 pmontazemi  (deleted user) commented on DG-DEN-8103-1

Place TRUE as first argument.

]]> DG-DEN-8103-1: started by qnguyen Tue, 18 May 2021 10:07:05 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8103-1 https://devapps.diality.us/cru/DG-DEN-8103-1 qnguyen  (deleted user) started review DG-DEN-8103-1 ]]>