Fisheye on dgfirmware/firmware/source/rti.c https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/firmware/source/rti.c Recent activity in "dgfirmware" under directory /firmware/source/rti.c DG-DEN-4217-1: closed by Dara Navaei Thu, 19 Oct 2023 08:28:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: reviewers finished Thu, 19 Oct 2023 08:28:27 -0700 https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei , qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DG-DEN-4217-1 DG-DEN-4217_Level and Shock Detection ]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:28:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:27:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: started by Dara Navaei Thu, 19 Oct 2023 08:26:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei started review DG-DEN-4217-1 ]]> DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-8886-1: closed by Sean Nash Thu, 19 Aug 2021 14:02:19 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8886-1 https://devapps.diality.us/cru/DG-DEN-8886-1 Sean Nash Closed DG-DEN-8886-1 ]]> DG-DEN-8886-1: reviewers finished Thu, 19 Aug 2021 14:01:25 -0700 https://devapps.diality.us/cru/DG-DEN-8886-1 https://devapps.diality.us/cru/DG-DEN-8886-1 qnguyen  (deleted user) and Dara Navaei finished reviewing DG-DEN-8886-1 DG-DEN-8886_HD_DG_Dev Self Tests (2 of 2) ]]> DG-DEN-8886-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 19 Aug 2021 10:29:49 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8886-1/#c10794 https://devapps.diality.us/cru/DG-DEN-8886-1/#c10794 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-8886-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8886-1: comment by Sean Nash "Made function void." Tue, 17 Aug 2021 11:13:53 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8886-1/#c10758 https://devapps.diality.us/cru/DG-DEN-8886-1/#c10758 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-8886-1

Made function void.

]]> DG-DEN-8886-1: comment by qnguyen "Missing return for non-void function." Fri, 13 Aug 2021 11:23:43 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8886-1/#c10753 https://devapps.diality.us/cru/DG-DEN-8886-1/#c10753 qnguyen  (deleted user) commented on DG-DEN-8886-1

Missing return for non-void function.

]]> DG-DEN-8886-1: started by Sean Nash Thu, 05 Aug 2021 10:24:45 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8886-1 https://devapps.diality.us/cru/DG-DEN-8886-1 Sean Nash started review DG-DEN-8886-1 ]]> DG-DEN-9054-1: closed by Dara Navaei Wed, 04 Aug 2021 10:42:13 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9054-1 https://devapps.diality.us/cru/DG-DEN-9054-1 Dara Navaei Closed DG-DEN-9054-1 ]]> DG-DEN-9054-1: reviewers finished Wed, 04 Aug 2021 10:41:21 -0700 https://devapps.diality.us/cru/DG-DEN-9054-1 https://devapps.diality.us/cru/DG-DEN-9054-1 qnguyen  (deleted user) and Sean Nash finished reviewing DG-DEN-9054-1 DG-DEN-9054_DG HD Switches ]]> DG-DEN-9054-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Wed, 04 Aug 2021 10:38:09 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-9054-1/#c10597 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10597 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9054-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9054-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Wed, 04 Aug 2021 10:32:13 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-9054-1/#c10596 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10596 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9054-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9054-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Wed, 04 Aug 2021 10:31:47 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-9054-1/#c10595 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10595 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9054-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9054-1: comment by Dara Navaei "Fixed the maxBufferLength variable." Tue, 03 Aug 2021 09:48:56 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9054-1/#c10592 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10592 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-9054-1

Fixed the maxBufferLength variable.

]]> DG-DEN-9054-1: comment by Dara Navaei "Done." Tue, 03 Aug 2021 09:43:30 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9054-1/#c10591 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10591 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-9054-1

Done.

]]> DG-DEN-9054-1: comment by Dara Navaei "Done." Tue, 03 Aug 2021 09:42:29 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9054-1/#c10590 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10590 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-9054-1

Done.

]]> DG-DEN-9054-1: comment by qnguyen "Unused parameter." Tue, 03 Aug 2021 09:34:15 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-9054-1/#c10589 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10589 qnguyen  (deleted user) commented on DG-DEN-9054-1

Unused parameter.

]]> DG-DEN-9054-1: comment by qnguyen "Looks like the parameter is not being used." Tue, 03 Aug 2021 09:33:08 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-9054-1/#c10588 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10588 qnguyen  (deleted user) commented on DG-DEN-9054-1

Looks like the parameter is not being used.

]]> DG-DEN-9054-1: comment by qnguyen "maxBufferLength variable is not needed in this ..." Tue, 03 Aug 2021 09:27:39 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-9054-1/#c10587 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10587 qnguyen  (deleted user) commented on DG-DEN-9054-1

maxBufferLength variable is not needed in this case and the comment is not matched the code.
Suggest revert this change to line 2139.

]]> DG-DEN-9054-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 02 Aug 2021 10:33:13 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-9054-1/#c10574 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10574 Sean Nash replied to Dara Navaei in DG-DEN-9054-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9054-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 02 Aug 2021 10:32:03 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-9054-1/#c10573 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10573 Sean Nash replied to Dara Navaei in DG-DEN-9054-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9054-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 02 Aug 2021 10:31:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-9054-1/#c10572 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10572 Sean Nash replied to Dara Navaei in DG-DEN-9054-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9054-1: comment by Dara Navaei "The signal is debounced for 50ms. I added a deb..." Sat, 31 Jul 2021 09:02:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9054-1/#c10568 https://devapps.diality.us/cru/DG-DEN-9054-1/#c10568 Dara Navaei replied to Sean Nash in DG-DEN-9054-1

The signal is debounced for 50ms. I added a debounce for a longer time.

]]>