Fisheye on dgfirmware/results/StatusReport.csv https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/results/StatusReport.csv Recent activity in "dgfirmware" under directory /results/StatusReport.csv DG-DEN-2652-1: closed by Dara Navaei Thu, 21 May 2020 10:39:33 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2652-1 https://devapps.diality.us/cru/DG-DEN-2652-1 Dara Navaei Closed DG-DEN-2652-1 ]]> DG-DEN-2652-1: reviewers finished Thu, 21 May 2020 10:39:13 -0700 https://devapps.diality.us/cru/DG-DEN-2652-1 https://devapps.diality.us/cru/DG-DEN-2652-1 Sean Nash and Dara Navaei finished reviewing DG-DEN-2652-1 DG-DEN-2652_DG Valve Control 1 of 2 ]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:49:42 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1793 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1793 Sean Nash replied to Sean Nash in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:47:58 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1792 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1792 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:47:47 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1791 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1791 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:47:30 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1790 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1790 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:47:16 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1789 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1789 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:47:04 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1788 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1788 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:46:51 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1787 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1787 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:46:33 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1786 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1786 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:46:18 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1785 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1785 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:46:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1784 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1784 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:45:56 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1783 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1783 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:45:09 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1782 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1782 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:42:42 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1781 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1781 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:42:31 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1780 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1780 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:42:18 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1779 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1779 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:42:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1778 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1778 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:41:26 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1777 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1777 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 May 2020 15:40:38 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2652-1/#c1776 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1776 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2652-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Tue, 05 May 2020 15:39:21 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2652-1/#c1775 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1775 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2652-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Tue, 05 May 2020 15:38:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2652-1/#c1773 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1773 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2652-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Tue, 05 May 2020 15:38:40 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2652-1/#c1774 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1774 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-2652-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2652-1: comment by pmontazemi "Agreed and done." Tue, 05 May 2020 14:05:11 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2652-1/#c1772 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1772 pmontazemi  (deleted user) replied to Dara Navaei in DG-DEN-2652-1

Agreed and done.

]]> DG-DEN-2652-1: comment by pmontazemi "Agreed and done." Tue, 05 May 2020 14:04:57 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2652-1/#c1771 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1771 pmontazemi  (deleted user) replied to Dara Navaei in DG-DEN-2652-1

Agreed and done.

]]> DG-DEN-2652-1: comment by pmontazemi "Agreed and changed to U08." Tue, 05 May 2020 14:04:45 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2652-1/#c1770 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1770 pmontazemi  (deleted user) replied to Dara Navaei in DG-DEN-2652-1

Agreed and changed to U08.

]]> DG-DEN-2652-1: comment by pmontazemi "They should be static, agreed and done." Tue, 05 May 2020 14:04:21 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2652-1/#c1769 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1769 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2652-1

They should be static, agreed and done.

]]> DG-DEN-2652-1: comment by Dara Navaei "I would use U08 instead of int" Tue, 05 May 2020 14:03:44 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2652-1/#c1768 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1768 Dara Navaei commented on DG-DEN-2652-1

I would use U08 instead of int

]]> DG-DEN-2652-1: comment by pmontazemi "Agreed, I had done that but the compiler origin..." Tue, 05 May 2020 13:54:40 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2652-1/#c1765 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1765 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2652-1

Agreed, I had done that but the compiler originally gave me trouble because it was expecting U32, now done.

]]> DG-DEN-2652-1: comment by Dara Navaei "For consistency, I would use U08 instead of int" Tue, 05 May 2020 13:57:01 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2652-1/#c1767 https://devapps.diality.us/cru/DG-DEN-2652-1/#c1767 Dara Navaei commented on DG-DEN-2652-1

For consistency, I would use U08 instead of int

]]>