Fisheye on dialin/protocols/protocol

DIALIN-REFACTORING-3-1: closed by plucia

plucia — Mon, 04 May 2020 15:15:00 -0700

plucia (deleted user) Closed DIALIN-REFACTORING-3-1

DIALIN-REFACTORING-3-1: reviewers finished

Mon, 04 May 2020 12:22:23 -0700

pmontazemi (deleted user) and Behrouz NematiPour finished reviewing DIALIN-REFACTORING-3-1

DIALIN_Refactoring 3

DIALIN-REFACTORING-3-1: comment by Behrouz NematiPour "talked with Peter and it's OK. RESOLVED."

Behrouz NematiPour — Mon, 04 May 2020 12:16:24 -0700

Behrouz NematiPour replied to Behrouz NematiPour in DIALIN-REFACTORING-3-1

talked with Peter and it's OK.
RESOLVED.

DIALIN-REFACTORING-3-1: comment by Behrouz NematiPour "Why we setup to virtual can 0,1 ?"

Behrouz NematiPour — Mon, 04 May 2020 12:05:07 -0700

Behrouz NematiPour commented on DIALIN-REFACTORING-3-1

Why we setup to virtual can 0,1 ?

DIALIN-REFACTORING-3-1: comment by pmontazemi "RESOLVED."

pmontazemi — Thu, 30 Apr 2020 08:14:45 -0700

pmontazemi (deleted user) replied to plucia (deleted user) in DIALIN-REFACTORING-3-1

RESOLVED.

DIALIN-REFACTORING-3-1: comment by plucia "Done."

plucia — Wed, 29 Apr 2020 10:29:45 -0700

plucia (deleted user) replied to pmontazemi (deleted user) in DIALIN-REFACTORING-3-1

Done.

DIALIN-REFACTORING-3-1: comment by pmontazemi "RESOLVED."

pmontazemi — Wed, 29 Apr 2020 09:58:06 -0700

pmontazemi (deleted user) replied to plucia (deleted user) in DIALIN-REFACTORING-3-1

RESOLVED.

DIALIN-REFACTORING-3-1: comment by plucia "The purpose of programming language specificati..."

plucia — Wed, 29 Apr 2020 09:14:57 -0700

plucia (deleted user) replied to pmontazemi (deleted user) in DIALIN-REFACTORING-3-1

The purpose of programming language specification here is description only and there are no pypi classifiers that specify the python version beyond MAJOR.MINOR.

Since python-can has an issue working on windows, I haven't specified windows as a supported version.

I checked, and there is no pypi classifier for Virtualbox, or any other type of virtualization platform. This makes sense because specifying a python package as being compatible with a virtualization environment is out of the scope of the setuptools configuration.

There are also no pypi specifiers for Ubuntu specifically. So, the classifier I could find that best matches the OS we're running is Linux.

DIALIN-REFACTORING-3-1: comment by pmontazemi "I thought we were using Python v3.6.8 on Linux ..."

pmontazemi — Tue, 28 Apr 2020 22:28:44 -0700

pmontazemi (deleted user) commented on DIALIN-REFACTORING-3-1

I thought we were using Python v3.6.8 on Linux Ubuntu v18.04.3 LTS (64-bit) running in Oracle VirtualBox v5.2.32 (64-bit) on Windows Pro 10 (64-bit) OS?

DIALIN-REFACTORING-3-1: comment by pmontazemi "Add copyright header to all files."

pmontazemi — Tue, 28 Apr 2020 22:24:58 -0700

pmontazemi (deleted user) commented on DIALIN-REFACTORING-3-1

Add copyright header to all files.

DIALIN-REFACTORING-3-1: started by plucia

plucia — Tue, 28 Apr 2020 17:02:02 -0700

plucia (deleted user) started review DIALIN-REFACTORING-3-1

dialin (DEN-12358-sw_dev-sprint-67_mg): Restructured dialin package and modules.

Thu, 02 Apr 2020 10:35:51 -0700

Peter Lucia committed 8c39fe1 on branch 2020_EOY_DEMO, Calibration_fixes and 294 more in dialin

Restructured dialin package and modules.

· /.gitignore

(-2, +4)

| History

| Source

| Diff

· /LICENSE

(-0, +4)

| History

| Source

· /README.md

(-1, +1)

| History

| Source

| Diff

· /build.sh

(-0, +5)

| History

| Source

· /dg/dialysate_generator.py

(-280, +0)

| History

| Source

| Diff

· /dg/firmware_simulator.py

(-38, +0)

| History

| Source

| Diff

· /dg/protocols

(-1, +0)

| History

| Source

| Diff

· /dg/utils

(-1, +0)

| History

| Source

| Diff

· /dialin/__init__.py

(-0, +0)

| History

| Source

· /dialin/dg/__init__.py

(-0, +0)

| History

| Source

· /dialin/dg/dialysate_generator.py

(-0, +257)

| History

| Source

· /dialin/dg/protocols

(-0, +1)

| History

| Source

· /dialin/dg/utils

(-0, +1)

| History

| Source

· /dialin/hd/__init__.py

(-0, +0)

| History

| Source

· /dialin/hd/alarms.py

(-0, +277)

| History

| Source

… 42 more files in changeset.

dialin (DEN-12358-sw_dev-sprint-67_mg): Continued refactoring...

Wed, 01 Apr 2020 13:13:49 -0700

Peter Lucia committed 619cd8f on branch 2020_EOY_DEMO, Calibration_fixes and 294 more in dialin

Continued refactoring...

· /DG/DG_Firmware_Simulator.py

(-38, +0)

| History

| Source

| Diff

· /DG/DialIn

(-1, +0)

| History

| Source

| Diff

· /DG/DialysateGenerator.py

(-274, +0)

| History

| Source

| Diff

· /DialIn/CoreCANProtocol.py

(-704, +0)

| History

| Source

| Diff

· /HD/Alarms.py

(-261, +0)

| History

| Source

| Diff

· /HD/Basics.py

(-97, +0)

| History

| Source

| Diff

· /HD/BloodFlow.py

(-376, +0)

| History

| Source

| Diff

· /HD/Buttons.py

(-99, +0)

| History

| Source

| Diff

· /HD/DialIn

(-1, +0)

| History

| Source

| Diff

· /HD/DialysateInletFlow.py

(-370, +0)

| History

| Source

| Diff

· /HD/DialysateOutletFlow.py

(-445, +0)

| History

| Source

| Diff

· /HD/HD_DialOutFlow.py

(-183, +0)

| History

| Source

| Diff

· /HD/HD_TestScript.py

(-71, +0)

| History

| Source

| Diff

· /HD/HemodialysisDevice.py

(-179, +0)

| History

| Source

| Diff

· /HD/PressureOcclusion.py

(-316, +0)

| History

| Source

| Diff

… 39 more files in changeset.