DIALIN-REFACTORING-3-1 DIALIN_Refactoring 3

closed on 04 May 20

Author

Moderator

Reviewers

DIALIN_Refactoring 3

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 112

dialin 0
- Folder DG 0
  - File DG_Firmware_Simulator.py 0 Remove
  - File DialIn 0 Remove
  - File DialysateGenerator.py 0 Remove
- Folder DialIn 0
  - File CoreCANProtocol.py 0 Remove
- Folder HD 0
  - File Alarms.py 0 Remove
  - File Basics.py 0 Remove
  - File BloodFlow.py 0 Remove
  - File Buttons.py 0 Remove
  - File DialIn 0 Remove
  - File DialysateInletFlow.py 0 Remove
  - File DialysateOutletFlow.py 0 Remove
  - File HD_DialOutFlow.py 0 Remove
  - File HD_TestScript.py 0 Remove
  - File HemodialysisDevice.py 0 Remove
  - File PressureOcclusion.py 0 Remove
  - File RTC.py 0 Remove
  - File Treatment.py 0 Remove
  - File UI.py 0 Remove
  - File Watchdog.py 0 Remove
  - File utils.py 0 Remove
- Folder Tools 0
  - File document.sh 0 Remove
  - File setup_canbus.sh 0 Remove
  - File setup_environment.sh 0 Remove
  - File setup_environment_windows.bat 0 Remove
  - File setup_virtual_can.sh 0 Remove
- Folder dg 0
  - File dialysate_generator.py 0 Remove
  - File firmware_simulator.py 0 Remove
  - File protocols 0 Remove
  - File utils 0 Remove
- Folder dialin 0
  - Folder dg 0
    - File __init__.py 0 Remove
    - File constants.py 0 Remove
    - File dialysate_generator.py 0 Remove
    - File drain_pump.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File load_cells.py 0 Remove
    - File pressures.py 0 Remove
    - File protocols 0 Remove
    - File reservoirs.py 0 Remove
    - File ro_pump.py 0 Remove
    - File utils 0 Remove
  - Folder hd 0
    - File __init__.py 0 Remove
    - File alarms.py 0 Remove
    - File basics.py 0 Remove
    - File blood_flow.py 0 Remove
    - File buttons.py 3 Remove
    - File constants.py 0 Remove
    - File dialout_flow.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File protocols 0 Remove
    - File rtc.py 0 Remove
    - File treatment.py 0 Remove
    - File ui.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File utils 0 Remove
    - File watchdog.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
    - File __init__.py 0 Remove
  - Folder utils 0
    - File __init__.py 0 Remove
    - File conversions.py 0 Remove
  - File __init__.py 0 Remove
- Folder document 0
  - File Doxyfile 0 Remove
- Folder hd 0
  - File Alarms.py 0 Remove
  - File Basics.py 0 Remove
  - File BloodFlow.py 0 Remove
  - File Buttons.py 0 Remove
  - File DialysateInletFlow.py 0 Remove
  - File DialysateOutletFlow.py 0 Remove
  - File HD_DialOutFlow.py 0 Remove
  - File HD_TestScript.py 0 Remove
  - File HemodialysisDevice.py 0 Remove
  - File PressureOcclusion.py 0 Remove
  - File RTC.py 0 Remove
  - File Treatment.py 0 Remove
  - File UI.py 0 Remove
  - File Watchdog.py 0 Remove
  - File alarms.py 0 Remove
  - File basics.py 0 Remove
  - File blood_flow.py 0 Remove
  - File buttons.py 0 Remove
  - File constants.py 0 Remove
  - File dialout_flow.py 0 Remove
  - File dialysate_inlet_flow.py 0 Remove
  - File dialysate_outlet_flow.py 0 Remove
  - File pressure_occlusion.py 0 Remove
  - File protocols 0 Remove
  - File rtc.py 0 Remove
  - File test_script.py 0 Remove
  - File treatment.py 0 Remove
  - File ui.py 0 Remove
  - File utils 0 Remove
  - File watchdog.py 0 Remove
- Folder protocols 0
  - File CAN.py 0 Remove
  - File CoreCANProtocol.py 0 Remove
  - File protocol 0 Remove
- Folder tests 0
  - File dg_test_script.py 0 Remove
  - File hd_test_script.py 0 Remove
  - File test_imports.py 0 Remove
- Folder tools 0
  - File document.sh 0 Remove
  - File setup_canbus.sh 0 Remove
  - File setup_environment.sh 0 Remove
  - File setup_environment_windows.bat 0 Remove
  - File setup_virtual_can.sh 2 Remove
- Folder utils 0
  - File conversions.py 0 Remove
- File .gitignore 0 Remove
- File Doxyfile 0 Remove
- File LICENSE 0 Remove
- File README.md 0 Remove
- File build.sh 0 Remove
- File setup.py 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author & Moderator	1h 6m	2	Done.
Behrouz NematiPour	Reviewer - Complete	1h 4m	2	talked with Peter and it's OK. RESOLVED.
pmontazemi (deleted user)	Reviewer - Complete	11m	4	RESOLVED.
Total		2h 22m	8

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-REFACTORING-3-1

DIALIN_Refactoring 3

DIALIN-REFACTORING-3-1 8

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN_Refactoring 3

DIALIN-REFACTORING-3-1 8

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time