Fisheye on dialin/tests/test_hd_simulator.py

DIALIN-DEN-8251-1: closed by plucia

plucia — Mon, 24 May 2021 13:13:39 -0700

plucia (deleted user) Closed DIALIN-DEN-8251-1

DIALIN-DEN-8251-1: reviewers finished

Mon, 24 May 2021 13:11:14 -0700

Sean Nash finished reviewing DIALIN-DEN-8251-1

DIALIN-DEN-8251_Sprint 44

DIALIN-DEN-8251-1: reviewers finished

Fri, 21 May 2021 16:38:43 -0700

qnguyen (deleted user) and pmontazemi (deleted user) finished reviewing DIALIN-DEN-8251-1

DIALIN-DEN-8251_Sprint 44

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:37:31 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:37:19 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:36:40 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by plucia "If you select Edit Configuration -> "add conten..."

plucia — Fri, 21 May 2021 15:15:07 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

If you select Edit Configuration -> "add content roots" in PyCharm, it will automatically add /home/denali/Projects/dialin/ to your path before executing the script and there is no longer a need to append to the path in the script. I had selected this option and wasn't having issue running any script.
I've updated all the paths now to support execution from outside of PyCharm.

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Fri, 21 May 2021 15:16:11 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done - just FYI I have added type hints in my S..."

plucia — Fri, 21 May 2021 15:18:06 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done - just FYI I have added type hints in my Sprint 45 branch for the dg classes. So it hasn't been updated almost everywhere inside the dg folder on this Sprint 44 branch

DIALIN-DEN-8251-1: comment by qnguyen "Will this path is enough to find dialin folder ..."

qnguyen — Fri, 21 May 2021 10:29:50 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Will this path is enough to find dialin folder since this has been moved into another folder?

DIALIN-DEN-8251-1: comment by qnguyen "This function and the one below needs to match ..."

qnguyen — Fri, 14 May 2021 10:50:16 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

This function and the one below needs to match the new style.

DIALIN-DEN-8251-1: comment by qnguyen "Change to return type to None and remove not ne..."

qnguyen — Fri, 14 May 2021 10:41:35 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Change to return type to None and remove not needed return 0 to keep consistency with other functions in this file.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:15 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:09 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:02 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:17:27 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:18:23 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:19:08 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by qnguyen "Need file header."

qnguyen — Wed, 05 May 2021 23:08:38 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Need file header.

DIALIN-DEN-8251-1: comment by qnguyen "Need file header (copyright, etc.)"

qnguyen — Wed, 05 May 2021 23:07:05 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Need file header (copyright, etc.)

DIALIN-DEN-8251-1: comment by qnguyen "Mismatch filename."

qnguyen — Wed, 05 May 2021 23:06:06 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Mismatch filename.

DIALIN-DEN-8251-1: started by plucia

plucia — Tue, 04 May 2021 00:02:04 -0700

plucia (deleted user) started review DIALIN-DEN-8251-1

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8251, DIAL-103, DIAL-104: Improve threading performance, hd alarm volume simulation, maintenance.

Thu, 29 Apr 2021 23:43:19 -0700

Peter Lucia committed bfb0c47 on branch master, Calibration_fixes and 223 more in dialin

DEN-8251, DIAL-103, DIAL-104: Improve threading performance, hd alarm volume simulation, maintenance.

· /dialin/dg/dialysate_generator.py

(-2, +2)

| History

| Source

| Diff

· /dialin/protocols/CAN.py

(-3, +4)

| History

| Source

| Diff

· /dialin/ui/__init__.py

(-1, +0)

| History

| Source

| Diff

· /dialin/ui/dg_simulator.py

(-4, +1)

| History

| Source

| Diff

· /dialin/ui/hd_simulator.py

(-4, +1)

| History

| Source

| Diff

· /dialin/ui/hd_simulator_alarms.py

(-1, +61)

| History

| Source

| Diff

· /dialin/utils/__init__.py

(-0, +4)

| History

| Source

| Diff

· /dialin/utils/base.py

(-221, +2)

| History

| Source

| Diff

· /dialin/utils/helpers.py

(-0, +222)

| History

| Source

· /dialin/utils/singleton.py

(-0, +41)

| History

| Source

· /tests/peter/set_RTCs.py

(-0, +40)

| History

| Source

· /tests/peter/test_blood_flow.py

(-0, +55)

| History

| Source

· /tests/peter/test_calibration.py

(-0, +222)

| History

| Source

· /tests/peter/test_can.py

(-0, +27)

| History

| Source

· /tests/peter/test_debug_text.py

(-0, +29)

| History

| Source

… 30 more files in changeset.

DIALIN-DEN-5751-1: closed by Behrouz NematiPour

Behrouz NematiPour — Mon, 01 Feb 2021 18:07:33 -0800

Behrouz NematiPour Closed DIALIN-DEN-5751-1

DIALIN-DEN-5751-1: reviewers finished

Mon, 01 Feb 2021 17:51:49 -0800

plucia (deleted user) and pmontazemi (deleted user) finished reviewing DIALIN-DEN-5751-1

DIALIN-DEN-5751_Pre Treatment Ultrafiltration

DIALIN-DEN-5751-1: comment by plucia "will be addressed later, RESOLVED"

plucia — Mon, 01 Feb 2021 17:50:29 -0800

plucia (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-5751-1

will be addressed later,
RESOLVED

DIALIN-DEN-5751-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 01 Feb 2021 13:43:29 -0800

pmontazemi (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-5751-1

RESOLVED.

DIALIN-DEN-5751-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 01 Feb 2021 13:43:19 -0800

pmontazemi (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-5751-1

RESOLVED.

DIALIN-DEN-5751-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 01 Feb 2021 13:43:10 -0800

pmontazemi (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-5751-1

RESOLVED.

DIALIN-DEN-5751-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 01 Feb 2021 13:42:59 -0800

pmontazemi (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-5751-1

RESOLVED.