Fisheye on testsuites/tst_AlarmStatusData/verificationPoints/VP1 https://devapps.diality.us/changelog/~br%3Dmaster/testsuites/tst_AlarmStatusData/verificationPoints/VP1 Recent activity in "testsuites" under directory /tst_AlarmStatusData/verificationPoints/VP1 UI-DEN-5830-2: closed by Behrouz NematiPour Tue, 19 Jan 2021 20:55:38 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2 https://devapps.diality.us/cru/UI-DEN-5830-2 Behrouz NematiPour Closed UI-DEN-5830-2 ]]> UI-DEN-5830-2: reviewers finished Tue, 19 Jan 2021 14:40:06 -0800 https://devapps.diality.us/cru/UI-DEN-5830-2 https://devapps.diality.us/cru/UI-DEN-5830-2 plucia  (deleted user) finished reviewing UI-DEN-5830-2 UI-DEN-5830_Alarm Design ]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Tue, 19 Jan 2021 14:39:44 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7525 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7525 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "I will work on that later in prTx-UF story and ..." Tue, 19 Jan 2021 11:33:13 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7521 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7521 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

I will work on that later in prTx-UF story and it has only been fixed here since it wasn't passing the test sometimes while testing the Alarm design.

]]> UI-DEN-5830-2: comment by plucia "Yes I know. I accidently clicked it and there's..." Tue, 19 Jan 2021 08:42:18 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7519 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7519 plucia  (deleted user) replied to pmontazemi  (deleted user) in UI-DEN-5830-2

Yes I know. I accidently clicked it and there's no way to unclick

]]> UI-DEN-5830-2: comment by pmontazemi "Our process calls for only 1 UNRESOLVED and 1 R..." Tue, 19 Jan 2021 08:35:58 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-5830-2/#c7516 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7516 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

Our process calls for only 1 UNRESOLVED and 1 RESOLVED response (comment) per thread please.

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Mon, 18 Jan 2021 11:22:20 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7478 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7478 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: reviewers finished Fri, 15 Jan 2021 14:37:13 -0800 https://devapps.diality.us/cru/UI-DEN-5830-2 https://devapps.diality.us/cru/UI-DEN-5830-2 pmontazemi  (deleted user) finished reviewing UI-DEN-5830-2 UI-DEN-5830_Alarm Design ]]> UI-DEN-5830-2: comment by pmontazemi "RESOLVED." Fri, 15 Jan 2021 14:36:18 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-5830-2/#c7439 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7439 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED.

]]> UI-DEN-5830-2: comment by pmontazemi "RESOLVED." Fri, 15 Jan 2021 14:36:00 -0800 pmontazemi https://devapps.diality.us/cru/UI-DEN-5830-2/#c7438 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7438 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED.

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Fri, 15 Jan 2021 11:37:58 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7428 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7428 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Fri, 15 Jan 2021 11:37:50 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7427 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7427 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "deleted." Thu, 14 Jan 2021 15:32:01 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7370 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7370 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

deleted.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "Good catch, Dleted." Thu, 14 Jan 2021 15:31:37 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7369 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7369 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

Good catch,
Dleted.

]]> testsuites (DEN-8514_UI_DEV_Alarms_Active_List): DEN-5838: Code Review 0 Thu, 14 Jan 2021 15:30:35 -0800 Behrouz NematiPour https://devapps.diality.us/changelog/testsuites?cs=90d25f34aa147e502583fab7c9e4fd4a980dd4e8 https://devapps.diality.us/changelog/testsuites?cs=90d25f34aa147e502583fab7c9e4fd4a980dd4e8 Behrouz NematiPour committed 90d25f3 on branch DEN-10602_UI_DEV_PatientID, DEN-16533-UI-VD-S109_integration_update_2 and 32 more in testsuites DEN-5838: Code Review 0

· /tst_AlarmStatusData/verificationPoints/VP1 (-6, +0) | History | Source | Diff
· /tst_CreateTreatment/test.py (-1, +0) | History | Source | Diff
]]> UI-DEN-5830-2: comment by Behrouz NematiPour "You actually had it with the value of 0.1 ms an..." Thu, 14 Jan 2021 15:27:16 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7367 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7367 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

You actually had it with the value of 0.1 ms and I increased it to 0.5 because after running the test multiple times I figured it is not enough time.
I will review the waits in the pTx-UF COCO.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "I kept it for debugging. The usual behavior of..." Thu, 14 Jan 2021 15:14:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7366 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7366 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

I kept it for debugging.
The usual behavior of the SquishQt is to continue even if an error happens to stop it if an error happens this value needs to be set.
I'm still trying to figure out how exactly this works and later may move it in a better file.

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:21:31 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7305 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7305 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:20:40 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7304 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7304 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:20:26 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7303 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7303 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:20:08 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7302 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7302 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:19:49 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7301 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7301 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Wed, 13 Jan 2021 11:19:05 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7300 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7300 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "removed." Tue, 12 Jan 2021 17:58:51 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7273 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7273 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

removed.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "Thanks for catching that. Fixed. This script i..." Tue, 12 Jan 2021 17:57:43 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7272 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7272 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

Thanks for catching that. Fixed.
This script is helping to have a summary of the objectives in the code reviews and a summary of what has been done in this branch.

]]> UI-DEN-5830-2: comment by Behrouz NematiPour "deleted" Tue, 12 Jan 2021 17:56:59 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-5830-2/#c7271 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7271 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-5830-2

deleted

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Tue, 12 Jan 2021 17:44:25 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7269 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7269 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "RESOLVED" Tue, 12 Jan 2021 17:44:16 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7268 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7268 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-5830-2

RESOLVED

]]> UI-DEN-5830-2: comment by plucia "Was this added by mistake?" Tue, 12 Jan 2021 17:36:19 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7266 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7266 plucia  (deleted user) commented on UI-DEN-5830-2

Was this added by mistake?

]]> UI-DEN-5830-2: comment by plucia "Can delete" Tue, 12 Jan 2021 17:36:49 -0800 plucia https://devapps.diality.us/cru/UI-DEN-5830-2/#c7267 https://devapps.diality.us/cru/UI-DEN-5830-2/#c7267 plucia  (deleted user) commented on UI-DEN-5830-2

Can delete

]]>