UI-DEN-5830-2 UI-DEN-5830_Alarm Design

closed on 19 Jan 21

Author

Reviewers

UI-DEN-5830_Alarm Design

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 88

application 0
- Folder resources/images 0
  - File AlarmBell.png 0 Remove
  - File AlarmBellSilent.png 0 Remove
  - File audio.png 0 Remove
  - File chevron-down.png 0 Remove
  - File chevron-up.png 0 Remove
  - File doted-list.png 0 Remove
  - File list.png 0 Remove
  - File mute.png 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 6 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File ImageLogoD.qml 0 Remove
        
        File ModalDialog.qml 0 Remove
        
        File MuteButton.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File TimeText.qml 0 Remove
        
        File TouchRect.qml 0 Remove
        
        File UpDownButton.qml 0 Remove
      - Folder dialogs 0
        
        File AlarmListDialog.qml 3 Remove
        
        File NotificationDialog.qml 3 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Variables.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmCleared.cpp 0 Remove
        
        File MAlarmCleared.h 0 Remove
        
        File MAlarmClearedCondition.cpp 0 Remove
        
        File MAlarmClearedCondition.h 0 Remove
        
        File MAlarmStatusData.cpp 3 Remove
        
        File MAlarmStatusData.h 0 Remove
        
        File MAlarmTriggered.cpp 0 Remove
        
        File MAlarmTriggered.h 0 Remove
    - File MModel.h 3 Remove
  - Folder view/hd/alarm 0
    - File VAlarmStatus.cpp 3 Remove
    - File VAlarmStatus.h 0 Remove
  - File AlarmGenerator.cpp 0 Remove
  - File AlarmGenerator.h 0 Remove
- Folder unittests 0
  - File tst_canbus.cpp 0 Remove
  - File tst_canbus.h 0 Remove
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 3 Remove
  - File tst_models.cpp 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File cr_objectives.sh 3 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File en_US.udic 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 3 Remove
- Folder simulator 0
  - Folder plugins 0
    - Folder alarms 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder createtreatment 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder heparin 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder inlinebloodpressures 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder salinebolus 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder treatmentranges 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder treatmentstates 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder ultrafiltration 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - File __init__.py 0 Remove
  - Folder simulator 0
    - File dynamicloader.py 0 Remove
    - File interface.ui 0 Remove
    - File loader.py 0 Remove
    - File runtimewidget.py 0 Remove
  - File run.py 0 Remove
  - File runtimewidget.py 0 Remove
  - File simulator.ui 0 Remove
- Folder tst_AlarmStatusData 0
  - Folder verificationPoints 0
    - File VP1 3 Remove
  - File test.py 3 Remove
- Folder tst_Alarm_Colors 0
  - File config.xml 0 Remove
  - File test.py 0 Remove
- Folder tst_ConfirmPrimingBegin 0
  - File test.py 6 Remove
- Folder tst_CreateTreatment 0
  - File test.py 3 Remove
- Folder tst_HDOperationModeData 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Heparin 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Ultrafiltration 0
  - File test.py 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	1h 52m	15	I will work on that later in prTx-UF story and it has onl...
pmontazemi (deleted user)	Reviewer - Complete	16m	5	Our process calls for only 1 UNRESOLVED and 1 RESOLVED re...
plucia (deleted user)	Reviewer - Complete	1h 36m	25	RESOLVED
Total		3h 44m	45

Linked issues
- DEN-5833
- DEN-5836

#permalink

Objectives

Summary:
----- Applicarion -----

Updated the old Alarm model structure to used the notify in the Message Interpreter.
Updated the Alarm Trigger, Clear, Status to inherit from MAbstract to be able to the above.
Added a macro to make the request messages handling easier.
Added 3 Alarm buttons
created Mute Button
created Up and Down Button (minimize/maximize)
used FW alarm status flag enum (Alarm_State_Flag_Bit_Positions) instead of the UI version and removed UI one.
modified and cleaned up Notification Dialog and Bar.
modified Time Text component to be able to show sections with one zero only.
cleaned up main.qml
Added User Action message response model.
Implementation of message 64: 'Alarm User Action'
Cleaned up the VAlarmStatus class.
increased the Notification Bar height a little bit more.
Fixed the bug of silence logic which was reverse
Fixed the bug that the length of the silence message payload was incorrectly set to 4 instead of 1.
changed the name of the MAlarmSilenceReq member variable to silence instead of the state which now implies it is silent (1) or not (0).
moved version and SD-Card icon to top which were covering the alarm bar.
added list icon on the notification bar
implemented the basics of the alarm list dialog.
tweaked the Notification default coloring
Added the message 63: 'alarm condition cleared, req/rsp'
Fixed the bug that alarm ID zero which is clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed the notification signal not to raise and GUI wasn't getting updated.
Added a MACRO for convenience of empty payload messages handling.
Cleaned up the unit tests
Added a UI "AlarmGenerator" class to handle the HD_COMM_TIMEOUT and later the BLE Cuff alarm (PRS 395).
updated the alarm message table
commented as manually tested the AlarmClearedCondition.
added a unit test for the AlarmGenerator private method setBits.

----- TestSuit -----

Completing the Alarm Status
Removing the Alarm Color which has been covered in the AlarmStatus in a bigger area.
Code Cleanup

Simulator:
- minor .ui changes
- Create a single object of the HD_Simulator and setting it in the DynamicLoader parent class of the plugins.
- The last piece of making the Simulator plugin base.
- Improvement: separator.
- Changed the RealTimeWidget parent name to DynamicLoader.
- Made DynamicLoader abstract class.
- Added Create Treatment plugin.
- Added the Alarm plugin
- modified the plugins to use a unique Loader class name and then define the unique name in the _init_.py file.
- using the os lib to get the current plugin path and load the unique interface.ui in the RealTmeWidget parent class.
- Added check CANBus in the simulator.

===== detailed by commits =====
----- Application -----
commit: f1e100 - DEN-5833: Implementation

Updated the old Alarm model structure to used the notify in the Message Interpreter.
Updated the Alarm Trigger, Clear, Status to inherit from MAbstract to be able to the above.
Added a macro to make the request messages handling easier.

commit: 45ce6e - DEN-5833: Implementation

Added 3 Alarm buttons
created Mute Button
created Up and Down Button (minimize/maximize)
used FW alarm status flag enum (Alarm_State_Flag_Bit_Positions) instead of the UI version and removed UI one.
modified and cleaned up Notification Dialog and Bar.
modified Time Text component to be able to show sections with one zero only.
cleaned up main.qml

commit: e1eed3 - DEN-5833: Implementation

Fixed a bouncing bug of the message when sent for the first time with a silenced flag on to show the alarm not maximized.

commit: eb23f8 - DEN-5833: Implementation

Added User Action message response model.

commit: d619b1 - DEN-5833: Implementation

Implementation of the message 64: 'Alarm User Action'
Cleaned up the VAlarmStatus class.

commit: 43cdee - DEN-5833: Implementation

made the mute button click optional and currently enabled.
made minimize on silent on the Notification Dialog optional and is disabled currently.
made separate slots for each user's actions instead of one for all with 4 parameters because it's easier and more convenient to use this way.
increased the Notification Bar height a little bit more.

commit: 71784f - DEN-5833: Implementation

Fixed the bug of silence logic which was reverse
Fixed the bug that the length of the silence message payload was incorrectly set to 4 instead of 1.
changed the name of the MAlarmSilenceReq member variable to silence instead of the state which now implies it is silent (1) or not (0).

commit: f325fa - DEN-5833: Implementation

fix a naming bug.

commit: 1d43ff - DEN-5833: Implementation

moved version and SD-Card icon to top which were covering the alarm bar.
added list icon on the notification bar
implemented the basics of the alarm list dialog.
tweaked the Notification default coloring

commit: 3e5cdc - DEN-5833: Implementation

Added the message 63: 'alarm condition cleared, req/rsp'

commit: 0e001d - DEN-5833: Implementation

The message 63 has been tested

commit: 5b17a1 - DEN-5833: Implementation

Moved the version and sd-card icon to not cover others.

commit: 9aedf - DEN-5833: Implementation

Fixed the bug that alarm ID zero which is clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed the notification signal not to raise and GUI wasn't getting updated.

commit: 51accb - DEN-5833: Implementation

Added a MACRO for convenience of empty payload messages handling.

commit: cd7694 - DEN-5833: Implementation

added a touch expanding area for the TouchArea so regardless of its visual size it can have an expanded touchable area.
the touch expanding for the mute button set to 25 so it can have a bigger touch area than its size which is little.

commit: 0d3114 - DEN-5833: Implementation

Cleaned up the unit tests

commit: 190921 - DEN-5833: Implementation

Added a UI "AlarmGenerator" class to handle the HD_COMM_TIMEOUT and later the BLE Cuff alarm (PRS 395).

commit: b42479 - DEN-5836: Code Coverage

updated the alarm message table
fixed the -q parameter

commit: 7ffe64 - DEN-5836: Code Coverage

99.110% (4790/4833)

commit: 741b1c - DEN-5836: Code Coverage

commented as manually tested the AlarmClearedCondition.

commit: 4d3220 - DEN-5836: Code Coverage

99.979% (4826/4827)

commit: 911882 - DEN-5836: Code Coverage

100.000% (4827/4827)
added a unit test for the AlarmGenerator private method setBits.

----- TestSuit -----

commit : 8e2d609 - DEN-5836: Code Coverage

99.979% (4826/4827)

commit : f29743f - DEN-5835: Integration Testing

removed the commented-out part of the test code for Priming.

commit : bb99af6 - DEN-5835: Integration Testing

Completing the Alarm Status
Removing the Alarm Color which has been covered in the AlarmStatus in a bigger area.

commit : ab2ebd8 - DEN-5836: Code Coverage

99.297% (4799/4833)

commit : ef497ba - DEN-5836: Code Coverage

Make the tests work with the application just to be able to start the testing.
Currently, the coverage is at 98.634% (4767/4833)

commit : 6f1082f - DEN-5833: Implementation

Added a Condition to test the message 63 Condition cleared
Code Cleanup

commit : d04cee8 - DEN-5833: Implementation

minor .ui changes

commit : f921975 - DEN-5754: Implementation

Create a single object of the HD_Simulator and setting it in the DynamicLoader parent class of the plugins.

commit : cbf0e77 - DEN-5833: Implementation

reversed the alarm status flags bits order.

commit : 15118be - DEN-5754: Implementation

The last piece of making the Simulator plugin base.
Improvement: separator.

commit : 9206e36 - DEN-5754: Implementation

Changed the RealTimeWidget parent name to DynamicLoader.
Made DynamicLoader abstract class.
Added Create Treatment plugin.

commit : 69b2aac - DEN-5833: Implementation

Added the Alarm plugin
modified the plugins to use a unique Loader class name and then define the unique name int the _init_.py file.
using the os lib to get the current plugin path and load the unique interface.ui in the RealTmeWidget parent class.
Added check CANBus in the simulator.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-5830-2

UI-DEN-5830_Alarm Design

UI-DEN-5830-2 45

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-5830_Alarm Design

UI-DEN-5830-2 45

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time