Fisheye on testsuites/tst_DGHeatersData/config.xml https://devapps.diality.us/changelog/~br%3Dmaster_old/testsuites/tst_DGHeatersData/config.xml Recent activity in "testsuites" under directory /tst_DGHeatersData/config.xml UI-DEN-4598-1: closed by plucia Wed, 11 Nov 2020 10:59:24 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1 https://devapps.diality.us/cru/UI-DEN-4598-1 plucia  (deleted user) Closed UI-DEN-4598-1 ]]> UI-DEN-4598-1: reviewers finished Tue, 10 Nov 2020 18:42:44 -0800 https://devapps.diality.us/cru/UI-DEN-4598-1 https://devapps.diality.us/cru/UI-DEN-4598-1 pmontazemi  (deleted user) and Behrouz NematiPour finished reviewing UI-DEN-4598-1 UI-DEN-4598_Confirm Priming Begin ]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 17:21:06 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6098 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6098 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by plucia "RESOLVED" Tue, 10 Nov 2020 17:20:04 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c6097 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6097 plucia  (deleted user) replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "Please rename the file to MTreatmentEndResponse" Thu, 29 Oct 2020 13:02:27 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c5759 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5759 Behrouz NematiPour commented on UI-DEN-4598-1

Please rename the file to MTreatmentEndResponse

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 17:12:44 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6096 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6096 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 17:10:24 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6095 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6095 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 16:46:08 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6094 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6094 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 16:39:58 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6087 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6087 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 16:40:14 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6088 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6088 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 16:40:30 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6090 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6090 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "In general please try to use less components. ..." Mon, 09 Nov 2020 11:57:30 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c5960 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5960 Behrouz NematiPour commented on UI-DEN-4598-1

In general please try to use less components.
Components should be more general and not specific to a screen.
If that is the case think of it as a big(which I call it compound) component and put it in the compounds folder(which I recently created).
Please note that either way we still should create less components/compounds.

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED http://dvm-linux02:8080/browse/DEN-56..." Tue, 10 Nov 2020 16:42:00 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6092 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6092 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED" Tue, 10 Nov 2020 16:38:51 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6086 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6086 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED" Tue, 10 Nov 2020 16:38:06 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6085 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6085 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED" Tue, 10 Nov 2020 16:36:25 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6084 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6084 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "RESOLVED" Tue, 10 Nov 2020 16:36:11 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c6083 https://devapps.diality.us/cru/UI-DEN-4598-1/#c6083 Behrouz NematiPour replied to plucia  (deleted user) in UI-DEN-4598-1

RESOLVED

]]> UI-DEN-4598-1: comment by plucia "I've noted this and will make sure to resolve i..." Tue, 10 Nov 2020 09:44:08 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5986 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5986 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

I've noted this and will make sure to resolve it later

http://dvm-linux02:8080/browse/DEN-5642

]]> UI-DEN-4598-1: comment by plucia "The reason this has been added is somewhat comp..." Tue, 10 Nov 2020 09:52:58 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5995 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5995 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

The reason this has been added is somewhat complicated to explain. But one of the reasons is so the next time we enter pre-treatment the top page is the create treatment page and not the treatment begin page. I've made a note to follow up on this

]]> UI-DEN-4598-1: comment by plucia "Okay thank you. I've made a list and will make ..." Tue, 10 Nov 2020 09:47:07 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5993 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5993 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

Okay thank you. I've made a list and will make sure they are resolved later

]]> UI-DEN-4598-1: comment by plucia "I've noted this and will make sure to resolve i..." Tue, 10 Nov 2020 09:45:37 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5992 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5992 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

I've noted this and will make sure to resolve it later

]]> UI-DEN-4598-1: comment by plucia "I've noted this and will make sure to resolve i..." Tue, 10 Nov 2020 09:44:33 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5989 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5989 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

I've noted this and will make sure to resolve it later

]]> UI-DEN-4598-1: comment by plucia "I've noted this and will make sure to resolve i..." Tue, 10 Nov 2020 09:44:25 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5987 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5987 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

I've noted this and will make sure to resolve it later

]]> UI-DEN-4598-1: comment by plucia "Done" Tue, 10 Nov 2020 09:24:28 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5978 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5978 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

Done

]]> UI-DEN-4598-1: comment by plucia "Done" Tue, 10 Nov 2020 09:25:56 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5980 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5980 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

Done

]]> UI-DEN-4598-1: comment by plucia "Done" Mon, 09 Nov 2020 18:03:53 -0800 plucia https://devapps.diality.us/cru/UI-DEN-4598-1/#c5973 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5973 plucia  (deleted user) replied to Behrouz NematiPour in UI-DEN-4598-1

Done

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "I put some comments as notes which don't requir..." Mon, 09 Nov 2020 12:49:14 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c5967 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5967 Behrouz NematiPour commented on UI-DEN-4598-1

I put some comments as notes which don't require to be fixed in this code review but it is expected to be noted and resolved in later on going stories.
So please take notes and consider applying them to any recent story/task.

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "Later please use Treatment first and then the c..." Mon, 09 Nov 2020 12:28:23 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c5966 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5966 Behrouz NematiPour commented on UI-DEN-4598-1

Later please use Treatment first and then the command.
Like ID_TreatmentEnd, ID_TreatmentStart, ...

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "This is part of a merge conflict resolution. P..." Mon, 09 Nov 2020 12:27:05 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c5965 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5965 Behrouz NematiPour commented on UI-DEN-4598-1

This is part of a merge conflict resolution.
Please correct it.

]]> UI-DEN-4598-1: comment by Behrouz NematiPour "Be careful of using this. When you push and po..." Mon, 09 Nov 2020 12:23:53 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-4598-1/#c5964 https://devapps.diality.us/cru/UI-DEN-4598-1/#c5964 Behrouz NematiPour commented on UI-DEN-4598-1

Be careful of using this.
When you push and pop in order it's fine but when pop to an item randomly it's not safe.
If the object is not currently in the stack you may get an error and I don't know what is going to happen to the Application !!!
preferably don't use this, it's a stack and has to be pushed and popped in order.

]]>