UI-DEN-4598-1 UI-DEN-4598_Confirm Priming Begin

closed on 11 Nov 20

Author

Reviewers

UI-DEN-4598_Confirm Priming Begin

Activity

Details
Objectives
General Comments 15
Unresolved
Resolved
Number of files included: 155

application 0
- Folder resources/images 0
  - File alarm.svg 0 Remove
  - File bell-off.svg 0 Remove
  - File bell.svg 0 Remove
  - File check.png 0 Remove
  - File checkCircle.png 0 Remove
- Folder scripts 0
  - File copy.sh 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File MessageInterpreter.h 3 Remove
    - File messagedispatcher.cpp 0 Remove
    - File messageglobals.h 0 Remove
    - File messageinterpreter.cpp 0 Remove
    - File messageinterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File CheckListItem.qml 0 Remove
        
        File ConfirmTreatmentSubTable.qml 0 Remove
        
        File ConfirmTreatmentTable.qml 0 Remove
        
        File ConfirmTreatmentTableEntry.qml 0 Remove
        
        File GridSelection.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File PrimingTimer.qml 0 Remove
        
        File ProgressCircle.qml 0 Remove
        
        File RangeRect.qml 0 Remove
        
        File RectSelectCreateTreatment.qml 0 Remove
        
        File Slider.qml 3 Remove
        
        File SliderCreateTreatment.qml 0 Remove
        
        File SliderDoubleCreateTreatment.qml 0 Remove
        
        File StackItem.qml 0 Remove
        
        File TopMenuBarCreateTreatment.qml 0 Remove
        
        File TouchRect.qml 0 Remove
      - Folder dialogs 0
        
        File NotificationDialog.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        File TreatmentBegin.qml 3 Remove
        
        File TreatmentConfirm.qml 3 Remove
        
        File TreatmentCreate.qml 3 Remove
        
        File TreatmentPrime.qml 0 Remove
        
        File TreatmentStack.qml 3 Remove
        
        File SettingsHome.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 3 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 3 Remove
    - File guicontroller.cpp 0 Remove
    - File guicontroller.h 0 Remove
    - File guiglobals.cpp 0 Remove
    - File guiglobals.h 0 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment 0
        
        File MTreatmentAdjustRequests.h 3 Remove
      - Folder alarm 0
        
        File MAlarmStatusData.h 0 Remove
      - Folder data 0
        
        File MPrimingData.cpp 0 Remove
        
        File MPrimingData.h 9 Remove
    - File MEndTreatmentResponse.cpp 2 Remove
    - File MEndTreatmentResponse.h 5 Remove
    - File MModel.h 0 Remove
    - File MStartTreatmentResponse.cpp 0 Remove
    - File MStartTreatmentResponse.h 5 Remove
    - File MTreatmentParameters.cpp 0 Remove
    - File MTreatmentParameters.h 0 Remove
    - File MTreatmentParametersResp.cpp 0 Remove
    - File MTreatmentParametersResp.h 12 Remove
    - File mtreatmentparameters.h 6 Remove
    - File mtreatmentparametersresp.cpp 0 Remove
  - Folder storage 0
    - File FileHandler.cpp 0 Remove
    - File FileHandler.h 0 Remove
    - File FileSaver.cpp 0 Remove
    - File FileSaver.h 0 Remove
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
    - File filehandler.cpp 0 Remove
    - File filehandler.h 0 Remove
    - File filesaver.cpp 0 Remove
    - File filesaver.h 0 Remove
    - File storageglobals.cpp 6 Remove
    - File storageglobals.h 0 Remove
  - Folder view 0
    - Folder hd/alarm 0
      - File VAlarmStatus.cpp 0 Remove
      - File VAlarmStatus.h 3 Remove
    - File VCreateTreatment.cpp 0 Remove
    - File VCreateTreatment.h 0 Remove
    - File VPriming.cpp 0 Remove
    - File VPriming.h 0 Remove
    - File VTreatmentBegin.cpp 0 Remove
    - File VTreatmentBegin.h 3 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 9 Remove
    - File VTreatmentEnd.cpp 0 Remove
    - File VTreatmentEnd.h 0 Remove
    - File VView.h 0 Remove
    - File valarmstatus.cpp 0 Remove
    - File valarmstatus.h 0 Remove
    - File vview.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File VTreatmentBegin.cpp 0 Remove
  - File VTreatmentBegin.h 0 Remove
  - File applicationcontroller.cpp 6 Remove
  - File applicationcontroller.h 3 Remove
  - File main.h 0 Remove
- Folder unittests 0
  - File tst_canbus.cpp 0 Remove
  - File tst_canbus.h 3 Remove
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
  - File tst_views.cpp 0 Remove
  - File tst_views.h 0 Remove
- File ConfirmTreatmentTableEntry.qml 3 Remove
- File ProgressLine.qml 3 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 0 Remove
- Folder tools 0
  - File create_dialin_link.sh 0 Remove
  - File run_server.sh 3 Remove
  - File run_tests.sh 0 Remove
  - File startxvfb.sh 0 Remove
  - File stopxvfb.sh 0 Remove
- Folder tst_AlarmCleared 0
  - File config.xml 0 Remove
- Folder tst_AlarmTriggered 0
  - File config.xml 0 Remove
- Folder tst_Alarm_Colors 0
  - File config.xml 0 Remove
  - File test.py 3 Remove
- Folder tst_CANBusFaultCount 0
  - File config.xml 0 Remove
- Folder tst_ConfirmPrimingBegin 0
  - File config.xml 0 Remove
  - File test.py 6 Remove
- Folder tst_CreateTreatment 0
  - File test.py 0 Remove
- Folder tst_DGDrainPumpData 0
  - File config.xml 0 Remove
- Folder tst_DGHeatersData 0
  - File config.xml 0 Remove
- Folder tst_DGLoadCellReadingsData 0
  - File config.xml 0 Remove
- Folder tst_DGPressureData 0
  - File config.xml 0 Remove
- Folder tst_DGReservoirData 0
  - File config.xml 0 Remove
- Folder tst_DGTemperaturesData 0
  - File config.xml 0 Remove
- Folder tst_DGValvesStatesData 0
  - File config.xml 0 Remove
- Folder tst_DebugText 0
  - File config.xml 0 Remove
- Folder tst_HDBloodFlowData 0
  - File config.xml 0 Remove
- Folder tst_HDInletFlowData 0
  - File config.xml 0 Remove
- Folder tst_HDOutletFlowData 0
  - File config.xml 0 Remove
- Folder tst_HDPressureOcclusionData 0
  - File config.xml 0 Remove
- Folder tst_HomeScreen 0
  - File config.xml 0 Remove
- Folder tst_Internals 0
  - File config.xml 0 Remove
- Folder tst_ServiceShutdown 0
  - File config.xml 0 Remove
- Folder tst_TreatmentScreen 0
  - File config.xml 0 Remove
- Folder tst_TreatmentStatesData 0
  - File config.xml 0 Remove
- Folder tst_Treatment_Adjustment_BloodDialysate 0
  - File config.xml 0 Remove
  - File test.py 6 Remove
- Folder tst_Treatment_Adjustment_Duration 0
  - File config.xml 0 Remove
- Folder tst_Treatment_Adjustment_Saline 0
  - File config.xml 0 Remove
- Folder tst_Treatment_Adjustment_Ultrafiltration 0
  - File config.xml 0 Remove
- Folder tst_Treatment_BloodDialysateFlowRate 0
  - File config.xml 0 Remove
- Folder tst_Treatment_ParametersRange 0
  - File config.xml 0 Remove
- Folder tst_Treatment_PressureOcclusion 0
  - File config.xml 0 Remove
- Folder tst_Treatment_Section_BloodDialysate 0
  - File config.xml 0 Remove
- Folder tst_Treatment_Time 0
  - File config.xml 0 Remove
- File .gitignore 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author	4h 49m	46	RESOLVED
Behrouz NematiPour	Reviewer - Complete	6h 28m	80	RESOLVED http://dvm-linux02:8080/browse/DEN-5642
pmontazemi (deleted user)	Reviewer - Complete	1h 3m	12	RESOLVED.
Total		12h 20m	138

Linked issues
- DEN-4598

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee
DEN-5603
DEN-5604

#permalink

General Comments

Behrouz NematiPour

After the Doxygeization effort, all the classes shall have the documentation ...

After the Doxygeization effort, all the classes shall have the documentation with messaging information.
Please add to all your classes.
For example on how to do please refer to the Model/View classes.
And when doc generated it will also be used for SDD.
it should contain:

\brief
\details
Message information
Message Payload information as each field in a line (see example below)
\sa(see also) which has related classes to this class
Logging info which at least has 3 lines (see example below and follow the HTML syntax for formating in doxygen please.)

An example provided. please look at more examples for your specific case in the code on the master branch.

/*!
 * \brief   The MAdjustSalineResponse class
 * \details The Saline Bolus adjustment response model
 *
 * | MSG  | CAN ID | M.Box | Type | Ack | Src | Dest | Description           |
 * |:----:|:------:|:-----:|:----:|:---:|:---:|:----:|:---------------------:|
 * |0x1400| 0x020  | 6     | Rsp  | Y   | HD  | UI   | Saline Bolus Response |
 *
 * | Payload  ||
 * |          ||
 * | #1:(U32) | \ref Data::mAccepted |
 * | #2:(U32) | \ref Data::mReason   |
 * | #3:(U32) | \ref Data::mTarget   |
 *
 * \sa Data
 * \sa MAdjustSalineReq : Saline Bolus Request
 * \sa MTreatmentSaline : Saline Bolus Data
 *
 * <h2 class="groupheader">Logging info</h2>
 * |              ||
 * |              ||
 * | typeText     | Event        |
 * | unitText     | HD           |
 * | infoText     | AdjustSaline |
 *
 */

29 Oct 20

Behrouz NematiPour

Resolved

09 Nov 20

plucia (deleted user)

Done

03 Nov 20

Behrouz NematiPour

RESOLVED

09 Nov 20

Behrouz NematiPour

After I checked out into your feature branch I found out the filesaver(.h,.cp...

After I checked out into your feature branch I found out the filesaver(.h,.cpp) name is not PascalCase.
Please change the filesaver to FileSaver.

29 Oct 20

Behrouz NematiPour

Resolved

03 Nov 20

plucia (deleted user)

Done

30 Oct 20

Behrouz NematiPour

RESOLVED

03 Nov 20

Behrouz NematiPour

As a general note Please try not to create a component for every single use c...

As a general note Please try not to create a component for every single use case.
I'm also started to remove some of the currently defined unnecessary components to keep them more organized.

01 Nov 20

Behrouz NematiPour

Resolved

03 Nov 20

plucia (deleted user)

Sure, makes sense. I removed the ProgressLine component and will keep that in...

Sure, makes sense. I removed the ProgressLine component and will keep that in mind going forward before adding any new components

03 Nov 20

Behrouz NematiPour

RESOLVED

03 Nov 20

Behrouz NematiPour

In general please try to use less components. Components should be more gener...

In general please try to use less components.
Components should be more general and not specific to a screen.
If that is the case think of it as a big(which I call it compound) component and put it in the compounds folder(which I recently created).
Please note that either way we still should create less components/compounds.

09 Nov 20

plucia (deleted user)

I've noted this and will make sure to resolve it later http://dvm-linux02:80...

I've noted this and will make sure to resolve it later

http://dvm-linux02:8080/browse/DEN-5642

10 Nov 20

Behrouz NematiPour

RESOLVED http://dvm-linux02:8080/browse/DEN-5642

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

10 Nov 20

Behrouz NematiPour

I put some comments as notes which don't require to be fixed in this code rev...

I put some comments as notes which don't require to be fixed in this code review but it is expected to be noted and resolved in later on going stories.
So please take notes and consider applying them to any recent story/task.

09 Nov 20

Behrouz NematiPour

Resolved

10 Nov 20

plucia (deleted user)

Okay thank you. I've made a list and will make sure they are resolved later

10 Nov 20

Behrouz NematiPour

RESOLVED

10 Nov 20

Click to load diff

/sources/.../components/RectSelectCreateTreatment.qml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-4598-1

UI-DEN-4598_Confirm Priming Begin

UI-DEN-4598-1 138

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Log time

UI-DEN-4598_Confirm Priming Begin

UI-DEN-4598-1 138

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

Log time