Fisheye on dgfirmware/firmware/App/Modes/ModeFill.c https://devapps.diality.us/changelog/~br%3Drelease%25402fp1/dgfirmware/firmware/App/Modes/ModeFill.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeFill.c dgfirmware (release/p1): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 24 Apr 2024 14:28:42 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=cda0cc9e4314b95cb1002ffba84f74e8435b2e58 https://devapps.diality.us/changelog/dgfirmware?cs=cda0cc9e4314b95cb1002ffba84f74e8435b2e58 Dara Navaei committed cda0cc9 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-17053-release-17-firmware-update and 3 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
]]> dgfirmware (release/p1): DENBUG-236 added the code changes from staging Wed, 24 Apr 2024 12:36:41 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=4ea9bbc23a76d24b2e1ddecbd5a1b9f84c6cc2cf https://devapps.diality.us/changelog/dgfirmware?cs=4ea9bbc23a76d24b2e1ddecbd5a1b9f84c6cc2cf Dara Navaei committed 4ea9bbc on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-17053-release-17-firmware-update and 4 more in dgfirmware DENBUG-236 added the code changes from staging

· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
]]> dgfirmware (release/p1): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 16 Apr 2024 10:23:37 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=79e39eb55935f2b63871ce12050ec4d5c4bd7f46 https://devapps.diality.us/changelog/dgfirmware?cs=79e39eb55935f2b63871ce12050ec4d5c4bd7f46 Dara Navaei committed 79e39eb on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-17053-release-17-firmware-update and 4 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeService.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DENBUG-236 added the changes from staging Tue, 16 Apr 2024 09:24:08 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2d4653fb5bd6b087b5e17d143b55249b7142fa07 https://devapps.diality.us/changelog/dgfirmware?cs=2d4653fb5bd6b087b5e17d143b55249b7142fa07 Dara Navaei committed 2d4653f on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-17053-release-17-firmware-update and 5 more in dgfirmware DENBUG-236 added the changes from staging

· /firmware/App/Controllers/ConcentratePumps.c (-18, +42) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-10, +34) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-1, +7) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-32, +35) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +5) | History | Source | Diff
· /firmware/App/Modes/ModeService.c (-0, +6) | History | Source | Diff
]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 11 Mar 2024 10:38:07 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=eeac2a1df1afbdcf4d1775b62cc810582472404d https://devapps.diality.us/changelog/dgfirmware?cs=eeac2a1df1afbdcf4d1775b62cc810582472404d Dara Navaei committed eeac2a1 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16773-add-chemical-disinfect-enable-institutional-record-2 and 8 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16682-use-cd2-values-for-acid-check-2): DEN-16682 added changes from staging Thu, 07 Mar 2024 11:18:21 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3256cf475a0efba069f79da4459e5fe925f1c356 https://devapps.diality.us/changelog/dgfirmware?cs=3256cf475a0efba069f79da4459e5fe925f1c356 Dara Navaei committed 3256cf4 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16682-use-cd2-values-for-acid-check-2 and 9 more in dgfirmware DEN-16682 added changes from staging

· /firmware/App/Controllers/ConductivitySensors.c (-0, +3) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-2, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-0, +7) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-17, +5) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-66, +68) | History | Source | Diff
]]> dgfirmware (DEN-16682-use-cd2-values-for-acid-check-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 01 Mar 2024 17:24:59 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=23ebb5812ecd93ca42999259f7f62f46fd482ebd https://devapps.diality.us/changelog/dgfirmware?cs=23ebb5812ecd93ca42999259f7f62f46fd482ebd Dara Navaei committed 23ebb58 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16682-use-cd2-values-for-acid-check-2 and 9 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16674 updated the code from staging Fri, 01 Mar 2024 09:27:38 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=61c74b7c3a092f9e2900665f1a4f0391f78c5c03 https://devapps.diality.us/changelog/dgfirmware?cs=61c74b7c3a092f9e2900665f1a4f0391f78c5c03 Dara Navaei committed 61c74b7 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware DEN-16674 updated the code from staging

· /firmware/App/Controllers/ConductivitySensors.c (-10, +21) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-46, +14) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +68) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-7, +94) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-0, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +28) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 21 Feb 2024 10:35:00 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=e592fa77b97bb2de9c43dec6e1137b8a4ead0452 https://devapps.diality.us/changelog/dgfirmware?cs=e592fa77b97bb2de9c43dec6e1137b8a4ead0452 Dara Navaei committed e592fa7 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16666 added new events in Mode Fill Wed, 21 Feb 2024 09:55:52 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8859b84617a5232161d78d4b232a4f8e37f76bf6 https://devapps.diality.us/changelog/dgfirmware?cs=8859b84617a5232161d78d4b232a4f8e37f76bf6 Dara Navaei committed 8859b84 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16666-log-passing-results-of-self-test-2 and 12 more in dgfirmware DEN-16666 added new events in Mode Fill

· /firmware/App/Modes/ModeFill.c (-2, +7) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 08 Jan 2024 14:41:57 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=4bd3bf3483660050d3026f7f9adff43782bfc620 https://devapps.diality.us/changelog/dgfirmware?cs=4bd3bf3483660050d3026f7f9adff43782bfc620 Dara Navaei committed 4bd3bf3 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16499-fw-message-list-testing-issues-2 and 14 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 17 Oct 2023 10:32:13 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=4950894933ebfe1166dd791b0c19a338e5a844e6 https://devapps.diality.us/changelog/dgfirmware?cs=4950894933ebfe1166dd791b0c19a338e5a844e6 Dara Navaei committed 4950894 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines. Mon, 16 Oct 2023 10:26:58 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=506f3f58a353093e1482db57bb1210e3b1cdc128 https://devapps.diality.us/changelog/dgfirmware?cs=506f3f58a353093e1482db57bb1210e3b1cdc128 Sean Nash committed 506f3f5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

· /firmware/App/Modes/ModeFill.c (-0, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 09 Oct 2023 11:23:57 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=d32f890bb6c238c95bcaca54da79d7aa4a1898cb https://devapps.diality.us/changelog/dgfirmware?cs=d32f890bb6c238c95bcaca54da79d7aa4a1898cb Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up Sat, 30 Sep 2023 13:06:29 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=1ada95392e4baf6f97158cb23e3c0e85709c07ba https://devapps.diality.us/changelog/dgfirmware?cs=1ada95392e4baf6f97158cb23e3c0e85709c07ba Dara Navaei committed 1ada953 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

· /firmware/App/Controllers/ROPump.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-7, +9) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-3, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Sat, 30 Sep 2023 13:02:28 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791. Sat, 30 Sep 2023 11:41:29 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 https://devapps.diality.us/changelog/dgfirmware?cs=d371983d84daf213db3e39d21cf30c13161ce062 Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c (-3, +15) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-6, +8) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-67, +84) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-10, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +16) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +118) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +14) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST Wed, 27 Sep 2023 15:32:59 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2f7745ccdb84c09134a43a9b8ca87f619135c478 https://devapps.diality.us/changelog/dgfirmware?cs=2f7745ccdb84c09134a43a9b8ca87f619135c478 Dara Navaei committed 2f7745c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code for VectorCAST

· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +3) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and VectorCAST test cases Wed, 27 Sep 2023 08:57:19 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=18541445702eb8c97b235d17c93c01d956c88dd1 https://devapps.diality.us/changelog/dgfirmware?cs=18541445702eb8c97b235d17c93c01d956c88dd1 Dara Navaei committed 1854144 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code and VectorCAST test cases

· /firmware/App/Modes/ModeFill.c (-1, +5) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes. Sun, 24 Sep 2023 11:02:14 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=b67373adbc581690febb1e1c2bb521f108d9b92e https://devapps.diality.us/changelog/dgfirmware?cs=b67373adbc581690febb1e1c2bb521f108d9b92e Sean Nash committed b67373a on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware DEN-15791: Doxygen comment fixes.

· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-5, +7) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-6, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up Wed, 20 Sep 2023 13:57:09 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=3836fcf6e190a4b6609e31041310eda0dd6e35ee https://devapps.diality.us/changelog/dgfirmware?cs=3836fcf6e190a4b6609e31041310eda0dd6e35ee Dara Navaei committed 3836fcf on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

· /firmware/App/Modes/ModeFill.c (-4, +4) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 20 Sep 2023 13:47:14 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=686955d65645ec1f99350150e49f9030d840b4cc https://devapps.diality.us/changelog/dgfirmware?cs=686955d65645ec1f99350150e49f9030d840b4cc Dara Navaei committed 686955d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume Wed, 20 Sep 2023 09:53:21 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2252531a88ffae920ef57f42e29badbd0d6a5491 https://devapps.diality.us/changelog/dgfirmware?cs=2252531a88ffae920ef57f42e29badbd0d6a5491 Dara Navaei committed 2252531 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware Merge branch 'staging' into DEN-16382-alarm-207-dg-flow-meter-check-failure-triggers-after-alarm-282-bicarbonate-volume

· /firmware/App/Modes/ModeFill.c (-6, +8) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST Wed, 20 Sep 2023 09:12:54 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=4d7bb5dc92d934b7237391503b211f238ba0d254 https://devapps.diality.us/changelog/dgfirmware?cs=4d7bb5dc92d934b7237391503b211f238ba0d254 Dara Navaei committed 4d7bb5d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware DEN-16446 updated the code for VectorCAST

· /firmware/App/Controllers/ConcentratePumps.c (-1, +6) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 19 Sep 2023 13:29:01 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8c22edb621da0832b1e1d9c7b1600dd63c94877d https://devapps.diality.us/changelog/dgfirmware?cs=8c22edb621da0832b1e1d9c7b1600dd63c94877d Dara Navaei committed 8c22edb on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm Tue, 19 Sep 2023 13:12:21 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5f1388ca0f6672b9ab90eef649de8dc921c9beb2 https://devapps.diality.us/changelog/dgfirmware?cs=5f1388ca0f6672b9ab90eef649de8dc921c9beb2 Dara Navaei committed 5f1388c on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware DEN-16382 updated the code to eliminate the extra fill command after the empty bottles alarm

· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-8, +0) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode... Tue, 19 Sep 2023 11:19:10 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=45b9096cf10c20adfaeac9e182ad75e1bf86d6e3 https://devapps.diality.us/changelog/dgfirmware?cs=45b9096cf10c20adfaeac9e182ad75e1bf86d6e3 Dara Navaei committed 45b9096 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 60 more in dgfirmware DEN-16314 added code in the fill mode to set the start fill time if it was 0 even if the previous state in the fill mode was pause

· /firmware/App/Modes/ModeFill.c (-4, +6) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16382: Prevent empty concentrate bottle alarms when mix with water test config is active. Tue, 19 Sep 2023 09:34:55 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=f10c653a13f97ae3d220e16f7ff1a9558606b56a https://devapps.diality.us/changelog/dgfirmware?cs=f10c653a13f97ae3d220e16f7ff1a9558606b56a Sean Nash committed f10c653 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 59 more in dgfirmware DEN-16382: Prevent empty concentrate bottle alarms when mix with water test config is active.

· /firmware/App/Modes/ModeDrain.c (-2, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 15 Sep 2023 16:38:36 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8ee01698b926fa62e7bed563b1137144a3cb32c5 https://devapps.diality.us/changelog/dgfirmware?cs=8ee01698b926fa62e7bed563b1137144a3cb32c5 Dara Navaei committed 8ee0169 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low... Wed, 13 Sep 2023 09:52:18 -0700 James Walter Taylor <jtaylor@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=35a1f7d58d013f95108e38674b01a283970e74a2 https://devapps.diality.us/changelog/dgfirmware?cs=35a1f7d58d013f95108e38674b01a283970e74a2 James Walter Taylor <jtaylor@diality.com> committed 35a1f7d on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

· /firmware/App/Modes/ModeFill.c (-17, +12) | History | Source | Diff
]]>