Fisheye on dgfirmware/firmware/App/Modes/ModeROPermeateSample.h

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:41:57 -0800

Dara Navaei committed 4bd3bf3 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16499-fw-message-list-testing-issues-2 and 14 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:57:02 -0700

Dara Navaei committed d325999 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 106 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff

… 11 more files in changeset.

DG-DEN-15367-1: closed by Dara Navaei

Dara Navaei — Wed, 14 Jun 2023 09:39:48 -0700

Dara Navaei Closed DG-DEN-15367-1

DG-DEN-15367-1: reviewers finished

Wed, 14 Jun 2023 09:12:02 -0700

Sean Nash finished reviewing DG-DEN-15367-1

DG-DEN-15367_HD DG Test Configuration Setup

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 14 Jun 2023 09:05:01 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 15:31:31 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:50:35 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:50:01 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Sean Nash "Still has a payload. Should remove it."

Sean Nash — Tue, 13 Jun 2023 12:48:04 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

Still has a payload. Should remove it.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:47:07 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:46:51 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:46:12 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Dara Navaei "Removed the check to make sure the target speed..."

Dara Navaei — Tue, 13 Jun 2023 12:40:00 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Tue, 13 Jun 2023 11:39:00 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Tue, 13 Jun 2023 11:38:35 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Tue, 13 Jun 2023 11:38:14 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Tue, 13 Jun 2023 11:37:29 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 10:27:19 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Sean Nash "Remove "handle" from this function name. It sh..."

Sean Nash — Tue, 13 Jun 2023 09:37:38 -0700

Sean Nash commented on DG-DEN-15367-1

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 09:37:18 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Dara Navaei "This function will be overhauled."

Dara Navaei — Tue, 13 Jun 2023 09:34:15 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-15367-1

This function will be overhauled.

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 09:33:42 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 09:33:14 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 09:32:47 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 09:27:26 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 09:25:27 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Dara Navaei "This function is only to set the actuators. If ..."

Dara Navaei — Tue, 13 Jun 2023 09:24:29 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

DG-DEN-15367-1: comment by Dara Navaei "This is the lower level function to set the act..."

Dara Navaei — Tue, 13 Jun 2023 09:23:09 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

DG-DEN-15367-1: comment by Dara Navaei "Changed to TRUE. Yes this message is only dispa..."

Dara Navaei — Tue, 13 Jun 2023 09:21:49 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 12 Jun 2023 14:47:08 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.