Fisheye on dgfirmware/firmware/App/Modes/ModeROPermeateSample.h https://devapps.diality.us/changelog/~br%3Drelease%25402fp1_develop/dgfirmware/firmware/App/Modes/ModeROPermeateSample.h Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeROPermeateSample.h DG-DEN-15367-1: closed by Dara Navaei Wed, 14 Jun 2023 09:39:48 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1 https://devapps.diality.us/cru/DG-DEN-15367-1 Dara Navaei Closed DG-DEN-15367-1 ]]> DG-DEN-15367-1: reviewers finished Wed, 14 Jun 2023 09:12:02 -0700 https://devapps.diality.us/cru/DG-DEN-15367-1 https://devapps.diality.us/cru/DG-DEN-15367-1 Sean Nash finished reviewing DG-DEN-15367-1 DG-DEN-15367_HD DG Test Configuration Setup ]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 14 Jun 2023 09:05:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17872 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17872 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 15:31:31 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17859 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17859 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 13 Jun 2023 12:50:35 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17855 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17855 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 13 Jun 2023 12:50:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17854 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17854 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Sean Nash "Still has a payload. Should remove it." Tue, 13 Jun 2023 12:48:04 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17853 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17853 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

Still has a payload. Should remove it.

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 13 Jun 2023 12:47:07 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17852 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17852 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 13 Jun 2023 12:46:51 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17851 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17851 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 13 Jun 2023 12:46:12 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17850 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17850 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Dara Navaei "Removed the check to make sure the target speed..." Tue, 13 Jun 2023 12:40:00 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17849 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17849 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.

]]> DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 13 Jun 2023 11:39:00 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15367-1/#c17845 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17845 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 13 Jun 2023 11:38:35 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15367-1/#c17844 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17844 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 13 Jun 2023 11:38:14 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15367-1/#c17843 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17843 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15367-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 13 Jun 2023 11:37:29 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15367-1/#c17842 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17842 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-15367-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 10:27:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17841 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17841 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Sean Nash "Remove "handle" from this function name. It sh..." Tue, 13 Jun 2023 09:37:38 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17839 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17839 Sean Nash commented on DG-DEN-15367-1

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 13 Jun 2023 09:37:18 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17838 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17838 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Dara Navaei "This function will be overhauled." Tue, 13 Jun 2023 09:34:15 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17837 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17837 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-15367-1

This function will be overhauled.

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 09:33:42 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17836 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17836 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 09:33:14 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17835 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17835 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 09:32:47 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17834 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17834 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 09:27:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17833 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17833 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Dara Navaei "Done" Tue, 13 Jun 2023 09:25:27 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17832 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17832 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

]]> DG-DEN-15367-1: comment by Dara Navaei "This function is only to set the actuators. If ..." Tue, 13 Jun 2023 09:24:29 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17831 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17831 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

]]> DG-DEN-15367-1: comment by Dara Navaei "This is the lower level function to set the act..." Tue, 13 Jun 2023 09:23:09 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17830 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17830 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

]]> DG-DEN-15367-1: comment by Dara Navaei "Changed to TRUE. Yes this message is only dispa..." Tue, 13 Jun 2023 09:21:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15367-1/#c17829 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17829 Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

]]> DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 12 Jun 2023 14:47:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17826 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17826 Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15367-1: comment by Sean Nash "We're always ready? Why does UI need to ask if..." Mon, 12 Jun 2023 14:43:07 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17825 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17825 Sean Nash commented on DG-DEN-15367-1

We're always ready? Why does UI need to ask if DG is ready if always ready?
Replace "1" with "TRUE".

]]> DG-DEN-15367-1: comment by Sean Nash "Should this be a s/w fault?" Mon, 12 Jun 2023 14:39:37 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15367-1/#c17824 https://devapps.diality.us/cru/DG-DEN-15367-1/#c17824 Sean Nash commented on DG-DEN-15367-1

Should this be a s/w fault?

]]>