Fisheye on dgfirmware/firmware/App/Services/Interrupts.h https://devapps.diality.us/changelog/~br%3Drelease%25402fp1_develop/dgfirmware/firmware/App/Services/Interrupts.h Recent activity in "dgfirmware" under directory /firmware/App/Services/Interrupts.h DG-DEN-4217-1: closed by Dara Navaei Thu, 19 Oct 2023 08:28:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: reviewers finished Thu, 19 Oct 2023 08:28:27 -0700 https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei , qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DG-DEN-4217-1 DG-DEN-4217_Level and Shock Detection ]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:28:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:27:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: started by Dara Navaei Thu, 19 Oct 2023 08:26:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei started review DG-DEN-4217-1 ]]> DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-DEN-15336-1: closed by wbracken Mon, 15 May 2023 13:53:03 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15336-1 https://devapps.diality.us/cru/DG-DEN-15336-1 wbracken  (deleted user) Closed DG-DEN-15336-1 ]]> DG-DEN-15336-1: reviewers finished Mon, 15 May 2023 13:52:30 -0700 https://devapps.diality.us/cru/DG-DEN-15336-1 https://devapps.diality.us/cru/DG-DEN-15336-1 jtaylor  (deleted user) , dcox  (deleted user) and Sean Nash finished reviewing DG-DEN-15336-1 DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications ]]> DG-DEN-15336-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 15 May 2023 08:17:20 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17526 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17526 Sean Nash replied to wbracken  (deleted user) in DG-DEN-15336-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15336-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 15 May 2023 08:17:10 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17525 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17525 Sean Nash replied to wbracken  (deleted user) in DG-DEN-15336-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15336-1: comment by wbracken "Removed" Sun, 14 May 2023 19:46:50 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15336-1/#c17524 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17524 wbracken  (deleted user) replied to Sean Nash in DG-DEN-15336-1

Removed

]]> DG-DEN-15336-1: comment by wbracken "Removed" Sun, 14 May 2023 19:46:39 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-15336-1/#c17523 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17523 wbracken  (deleted user) replied to Sean Nash in DG-DEN-15336-1

Removed

]]> DG-DEN-15336-1: comment by Sean Nash "Remove blank line." Sun, 14 May 2023 17:24:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17504 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17504 Sean Nash commented on DG-DEN-15336-1

Remove blank line.

]]> DG-DEN-15336-1: comment by Sean Nash "Remove blank line." Sun, 14 May 2023 17:23:48 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15336-1/#c17503 https://devapps.diality.us/cru/DG-DEN-15336-1/#c17503 Sean Nash commented on DG-DEN-15336-1

Remove blank line.

]]> DG-DEN-15336-1: started by Dara Navaei Sat, 13 May 2023 22:01:52 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15336-1 https://devapps.diality.us/cru/DG-DEN-15336-1 Dara Navaei started review DG-DEN-15336-1 ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-4217-1: closed by Sean Nash Thu, 20 Aug 2020 19:18:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Sean Nash Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:09:03 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3619 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3619 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:08:54 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3618 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3618 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:08:25 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3617 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3617 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 20 Aug 2020 15:06:26 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3616 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3616 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-4217-1: comment by Sean Nash "Agreed. Will address in another branch - maybe..." Thu, 20 Aug 2020 14:58:41 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3615 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3615 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

Agreed. Will address in another branch - maybe Dara's?

]]> DG-DEN-4217-1: comment by pmontazemi "Recommend replacing 2 with DG and do the same f..." Thu, 20 Aug 2020 14:54:57 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3614 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3614 pmontazemi  (deleted user) commented on DG-DEN-4217-1

Recommend replacing 2 with DG and do the same for other Software Items (HD, etc.).

]]> DG-DEN-4217-1: comment by Sean Nash "It's a test build #. They may do several lab r..." Thu, 20 Aug 2020 14:49:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3613 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3613 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

It's a test build #. They may do several lab revisions before test results looks good, then roll minor revision.

]]> DG-DEN-4217-1: comment by Sean Nash "This isn't code - it's a commented equation exp..." Thu, 20 Aug 2020 14:46:20 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3611 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3611 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

This isn't code - it's a commented equation explaining next 2 lines of code. That said, Dara can add spaces for readability on his branch.

]]> DG-DEN-4217-1: comment by pmontazemi "What is lab rev number and how it is different ..." Thu, 20 Aug 2020 14:46:27 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3612 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3612 pmontazemi  (deleted user) commented on DG-DEN-4217-1

What is lab rev number and how it is different from minor rev number?

]]> DG-DEN-4217-1: comment by Sean Nash "This isn't code - it's a commented equation exp..." Thu, 20 Aug 2020 14:45:00 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-4217-1/#c3610 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3610 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-4217-1

This isn't code - it's a commented equation explaining next 2 lines of code. That said, Dara can add spaces for readability on his branch.

]]> DG-DEN-4217-1: comment by pmontazemi "Spaces between arithmetic operation signs." Thu, 20 Aug 2020 14:40:20 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-4217-1/#c3609 https://devapps.diality.us/cru/DG-DEN-4217-1/#c3609 pmontazemi  (deleted user) commented on DG-DEN-4217-1

Spaces between arithmetic operation signs.

]]>