Fisheye on dgfirmware/firmware/checkAlarms.sh https://devapps.diality.us/changelog/~br%3Drelease%25402fp1_develop/dgfirmware/firmware/checkAlarms.sh Recent activity in "dgfirmware" under directory /firmware/checkAlarms.sh DG-DEN-14781-1: closed by Dara Navaei Wed, 15 Feb 2023 20:10:04 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14781-1 https://devapps.diality.us/cru/DG-DEN-14781-1 Dara Navaei Closed DG-DEN-14781-1 ]]> DG-DEN-14781-1: reviewers finished Wed, 15 Feb 2023 16:40:24 -0800 https://devapps.diality.us/cru/DG-DEN-14781-1 https://devapps.diality.us/cru/DG-DEN-14781-1 wbracken  (deleted user) , Sean Nash and Michael Garthwaite finished reviewing DG-DEN-14781-1 DG-DEN-14781_Alarm 117 DG Can Message Not Acked ]]> DG-DEN-14781-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Wed, 15 Feb 2023 13:03:16 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14781-1/#c16497 https://devapps.diality.us/cru/DG-DEN-14781-1/#c16497 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14781-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-14781-1: comment by Dara Navaei "There is not a #define for 0.0F." Wed, 15 Feb 2023 12:54:36 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14781-1/#c16493 https://devapps.diality.us/cru/DG-DEN-14781-1/#c16493 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14781-1

There is not a #define for 0.0F.

]]> DG-DEN-14781-1: comment by wbracken "Should be #define" Wed, 15 Feb 2023 12:53:28 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14781-1/#c16492 https://devapps.diality.us/cru/DG-DEN-14781-1/#c16492 wbracken  (deleted user) commented on DG-DEN-14781-1

Should be #define

]]> DG-DEN-14781-1: started by Dara Navaei Mon, 13 Feb 2023 12:01:32 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14781-1 https://devapps.diality.us/cru/DG-DEN-14781-1 Dara Navaei started review DG-DEN-14781-1 ]]> DG-DEN-14307-1: closed by Dara Navaei Wed, 21 Dec 2022 15:02:13 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14307-1 https://devapps.diality.us/cru/DG-DEN-14307-1 Dara Navaei Closed DG-DEN-14307-1 ]]> DG-DEN-14307-1: reviewers finished Wed, 21 Dec 2022 14:57:24 -0800 https://devapps.diality.us/cru/DG-DEN-14307-1 https://devapps.diality.us/cru/DG-DEN-14307-1 wbracken  (deleted user) and Sean Nash finished reviewing DG-DEN-14307-1 DG-DEN-14307_DG HD Dev HD DG Dvt Update Part 6 ]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODE WALKTRHOUGH." Wed, 21 Dec 2022 14:56:32 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15707 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15707 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODE WALKTRHOUGH.

]]> DG-DEN-14307-1: comment by Dara Navaei "These two variables are local." Wed, 21 Dec 2022 14:55:29 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14307-1/#c15706 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15706 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14307-1

These two variables are local.

]]> DG-DEN-14307-1: comment by wbracken "Add concCap and diaCap to header." Wed, 21 Dec 2022 14:52:49 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15705 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15705 wbracken  (deleted user) commented on DG-DEN-14307-1

Add concCap and diaCap to header.

]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 14:44:32 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15704 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15704 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 13:04:50 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14307-1/#c15697 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15697 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14307-1

Done

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 13:04:04 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15696 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15696 Sean Nash replied to Sean Nash in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:13:27 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15691 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15691 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-14307-1: comment by wbracken "Should add alarmDetectedPendingTrigger and preF..." Wed, 21 Dec 2022 12:12:19 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15690 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15690 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14307-1

Should add alarmDetectedPendingTrigger and preFlushState.

]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:10:54 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15689 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15689 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:09:54 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15688 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15688 wbracken  (deleted user) replied to wbracken  (deleted user) in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:06:24 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15687 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15687 wbracken  (deleted user) replied to wbracken  (deleted user) in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:05:23 -0800 wbracken https://devapps.diality.us/cru/DG-DEN-14307-1/#c15686 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15686 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:36:38 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15671 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15671 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:35:14 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15669 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15669 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:34:45 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15668 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15668 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:34:37 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15667 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15667 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:34:19 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15666 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15666 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:32:51 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15665 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15665 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:32:11 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15664 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15664 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:31:14 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15663 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15663 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:24:02 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15657 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15657 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 11:23:11 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-14307-1/#c15655 https://devapps.diality.us/cru/DG-DEN-14307-1/#c15655 Sean Nash replied to Dara Navaei in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]>