Is it ready for review?

Note for reviewers:
I've created this review ahead of time
I am still working on the implementation

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

As we had a conversation, we will keep that in mind and should see how much that affects UI for something like Logging and so on.

As we had a conversation, the V&V request can be covered in the effort of the three stacks checking their versions and compatibility, then a message can be sent over the HD channel.

Added a FIXME which is more important than TODO.
Updated

Updated

Updated

Updated

remove the before anything

does not (instead of doesn't)

change (instead of changed)

Add TODO

V&V has requested to be able to get the version from the UI using dialin to automate their testing

The UI is already talking with Dialin. Your simulator is using dialin to talk to the UI.
Because the UI doesn't recognize Dialin at all, Dialin has to talk on the HD to UI or DG to UI channels instead when sending up commands to the UI.
This poses a security risk because the UI could never restrict communication to just the DG/HD only. If Dialin can talk to the UI on separate channels then those channels can be ignored in production mode later.

It's your stack so your call but something I think we should consider

If we decide UI to talk with Dialin we need to add Dialin channels later, but it is not the case now.

On the UI side, we have no plan, for now, to listen to Dialin.

These definitions force dialin to talk on an HD/DG channels in order to simulate the UI. Seems like a security risk and that the UI should be able to tell the difference.