Fisheye on application/sources/view/dg/data/VDGReservoirData.h

UI-DEN-SUNRISE-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:54:28 -0800

Dara Navaei Closed UI-DEN-SUNRISE-1

UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE

Fri, 07 Jun 2024 09:05:01 -0700

Dara Navaei removed Sean Nash and vduong (deleted user) from UI-DEN-SUNRISE-1

UI-DEN-SUNRISE

UI-DEN-SUNRISE-1: started by Dara Navaei

Dara Navaei — Fri, 07 Jun 2024 09:04:34 -0700

Dara Navaei started review UI-DEN-SUNRISE-1

application (DEN-16553-UI-BN-WPA3-Support): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 24 Jan 2024 14:28:27 -0800

Dara Navaei committed 2ef03b2 on branch master, @Environement_Swith and 61 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cho.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-2, +2)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.h

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.h

(-1, +1)

| History

| Source

| Diff

… 598 more files in changeset.

UI-UCOMMITS-16: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 17 Jan 2024 13:23:30 -0800

Behrouz NematiPour Closed UI-UCOMMITS-16

UI-UCOMMITS-16: reviewers finished

Wed, 17 Jan 2024 13:22:30 -0800

Tiffany Mejia and Dara Navaei finished reviewing UI-UCOMMITS-16

UI Release/p1_staging Unreviewed Commits

UI-UCOMMITS-16: reviewers added to UI Release/p1_staging Unreviewed Commits

Wed, 17 Jan 2024 12:52:05 -0800

Behrouz NematiPour added Tiffany Mejia to UI-UCOMMITS-16

UI Release/p1_staging Unreviewed Commits

UI-UCOMMITS-16: started by Dara Navaei

Dara Navaei — Wed, 17 Jan 2024 11:42:32 -0800

Dara Navaei started review UI-UCOMMITS-16

UI-DEN-16526-2: closed by Behrouz NematiPour

Behrouz NematiPour — Tue, 31 Oct 2023 18:04:34 -0700

Behrouz NematiPour Closed UI-DEN-16526-2

UI-DEN-16526-2: reviewers finished

Tue, 31 Oct 2023 09:30:54 -0700

msuleiman (deleted user) , jtaylor (deleted user) and vduong (deleted user) finished reviewing UI-DEN-16526-2

UI-DEN-16526-UI-BN-S109-2 [ application ]

UI-DEN-16526-2: reviewers joined UI-DEN-16526-UI-BN-S109-2 [ application ]

Tue, 31 Oct 2023 08:17:59 -0700

jtaylor (deleted user) joined UI-DEN-16526-2

UI-DEN-16526-UI-BN-S109-2 [ application ]

application (bugfix/DEN-16597-UI-BN-S114): DEN-16531: UI: The reservoir message structure has changed on FW and UI needs to adjust.

Behrouz NematiPour — Tue, 31 Oct 2023 01:59:24 -0700

Behrouz NematiPour committed ddd4cdc on branch master, @Environement_Swith and 71 more in application

DEN-16531: UI: The reservoir message structure has changed on FW and UI needs to adjust.

· /sources/canbus/MessageGlobals.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGReservoirData.cpp	(-12, +0)	\| History	\| Source	\| Diff
· /sources/model/dg/data/MDGReservoirData.h	(-9, +0)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGReservoirData.cpp	(-3, +0)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGReservoirData.h	(-3, +0)	\| History	\| Source	\| Diff

UI-DEN-16526-2: started by Dara Navaei

Dara Navaei — Tue, 31 Oct 2023 00:06:08 -0700

Dara Navaei started review UI-DEN-16526-2

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

UI-DEN-15037-3: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 12 Apr 2023 15:53:36 -0700

Behrouz NematiPour Closed UI-DEN-15037-3

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 12 Apr 2023 15:51:34 -0700

Dara Navaei committed 28845c7 on branch master, @Environement_Swith and 157 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /scripts/run.sh	(-1, +1)	\| History	\| Source	\| Diff
· /sources/AlarmGenerator.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/ApplicationPost.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/Slider.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/SliderCreateTreatment.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/TextEntry.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/DiagnosticsDialog.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/settings/SettingsStack.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/settings/SettingsWiFi.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentFlow.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-20, +14)	\| History	\| Source	\| Diff
· /sources/view/VGeneralEvent.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/VGeneralEvent.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGReservoirData.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/view/settings/VDuetRoWaterDG.cpp	(-1, +1)	\| History	\| Source	\| Diff

UI-DEN-15037-3: reviewers finished

Wed, 12 Apr 2023 15:44:04 -0700

Sean Nash and jishii (deleted user) finished reviewing UI-DEN-15037-3

UI-DEN-15037-UI-BN-S94 [ReleaseMisc]

UI-DEN-15037-3: reviewers resumed

Tue, 11 Apr 2023 19:15:24 -0700

Michael Garthwaite and Tiffany Mejia resumed reviewing UI-DEN-15037-3

UI-DEN-15037-UI-BN-S94 [ReleaseMisc]

UI-DEN-15037-3: reviewers resumed

Wed, 05 Apr 2023 08:05:09 -0700

vduong (deleted user) resumed reviewing UI-DEN-15037-3

UI-DEN-15037-UI-BN-S94 [ReleaseMisc]

UI-DEN-15037-3: comment by vduong "RESOLVED"

vduong — Tue, 04 Apr 2023 22:30:11 -0700

vduong (deleted user) replied to Behrouz NematiPour in UI-DEN-15037-3

RESOLVED

UI-DEN-15037-3: comment by Michael Garthwaite "RESOLVED IN CODE WALKTHROUGH."

Michael Garthwaite — Tue, 04 Apr 2023 16:12:17 -0700

Michael Garthwaite replied to Behrouz NematiPour in UI-DEN-15037-3

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15037-3: comment by Behrouz NematiPour "Thank you for pointing that out. The message v..."

Behrouz NematiPour — Tue, 04 Apr 2023 16:09:57 -0700

Behrouz NematiPour replied to Michael Garthwaite in UI-DEN-15037-3

Thank you for pointing that out.
The message view was our of sync as well which has been fixed.

application (bugfix/DEN-16597-UI-BN-S114): http://devapps.diality.us:8060/cru/UI-DEN-15037-3#c17043...

Behrouz NematiPour — Tue, 04 Apr 2023 16:07:56 -0700

Behrouz NematiPour committed c88bfbf on branch master, @Environement_Swith and 158 more in application

http://devapps.diality.us:8060/cru/UI-DEN-15037-3#c17043

- fixed the DG reservoir message

· /sources/gui/qml/dialogs/DiagnosticsDialog.qml	(-3, +3)	\| History	\| Source	\| Diff
· /sources/view/dg/data/VDGReservoirData.h	(-3, +3)	\| History	\| Source	\| Diff

UI-DEN-15037-3: comment by Behrouz NematiPour "Thanks for the comment, Looks tricky to me too..."

Behrouz NematiPour — Tue, 04 Apr 2023 11:04:14 -0700

Behrouz NematiPour replied to vduong (deleted user) in UI-DEN-15037-3

Thanks for the comment,
Looks tricky to me too.
But worked fine for me now.
Will keep track of its behavior.

UI-DEN-15037-3: comment by vduong "This will give you undesired results. I have do..."

vduong — Tue, 04 Apr 2023 10:42:22 -0700

vduong (deleted user) commented on UI-DEN-15037-3

This will give you undesired results. I have done this before and it will end up showing us the intermediate values.

UI-DEN-15037-3: comment by Michael Garthwaite "These values are U32 from FW, do we need to add..."

Michael Garthwaite — Tue, 04 Apr 2023 10:41:14 -0700

Michael Garthwaite commented on UI-DEN-15037-3

These values are U32 from FW, do we need to add the toFixed(2)?

UI-DEN-15037-3: started by Dara Navaei

Dara Navaei — Mon, 03 Apr 2023 20:01:54 -0700

Dara Navaei started review UI-DEN-15037-3