Fisheye on application/sources/view/settings/VBluetooth.h https://devapps.diality.us/changelog/~br%3Drelease%25402fp1b%25402fdevelop/application/sources/view/settings/VBluetooth.h Recent activity in "application" under directory /sources/view/settings/VBluetooth.h UI-DEN-16249-2: closed by vduong Tue, 26 Sep 2023 12:46:04 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16249-2 https://devapps.diality.us/cru/UI-DEN-16249-2 vduong  (deleted user) Closed UI-DEN-16249-2 ]]> UI-DEN-16249-2: reviewers finished Tue, 26 Sep 2023 12:32:54 -0700 https://devapps.diality.us/cru/UI-DEN-16249-2 https://devapps.diality.us/cru/UI-DEN-16249-2 Behrouz NematiPour and Tiffany Mejia finished reviewing UI-DEN-16249-2 UI-DEN-16249_UI VD S104 P1B StatusIndicator BT/Wifi [ ready ] ]]> UI-DEN-16249-2: reviewers finished Wed, 30 Aug 2023 13:11:09 -0700 https://devapps.diality.us/cru/UI-DEN-16249-2 https://devapps.diality.us/cru/UI-DEN-16249-2 msuleiman  (deleted user) finished reviewing UI-DEN-16249-2 UI-DEN-16249_UI VD S104 P1B StatusIndicator BT/Wifi [ ready ] ]]> UI-DEN-16249-2: started by Dara Navaei Mon, 28 Aug 2023 08:05:41 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16249-2 https://devapps.diality.us/cru/UI-DEN-16249-2 Dara Navaei started review UI-DEN-16249-2 ]]> UI-UCOMMITS-3: closed by Sean Nash Thu, 03 Aug 2023 14:23:52 -0700 Sean Nash https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash Closed UI-UCOMMITS-3 ]]> UI-UCOMMITS-3: reviewers finished Thu, 03 Aug 2023 14:05:13 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: reviewers finished Wed, 02 Aug 2023 09:33:38 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: started by Dara Navaei Mon, 08 May 2023 08:49:03 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei started review UI-UCOMMITS-3 ]]> UI-DEN-9626-1: closed by Behrouz NematiPour Sun, 26 Sep 2021 20:25:46 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-9626-1 https://devapps.diality.us/cru/UI-DEN-9626-1 Behrouz NematiPour Closed UI-DEN-9626-1 ]]> UI-DEN-9626-1: reviewers finished Fri, 24 Sep 2021 16:11:30 -0700 https://devapps.diality.us/cru/UI-DEN-9626-1 https://devapps.diality.us/cru/UI-DEN-9626-1 pmontazemi  (deleted user) finished reviewing UI-DEN-9626-1 UI-DEN-9626_DEV Bluetooth Cuff Integration ]]> UI-DEN-9626-1: comment by pmontazemi "RESOLVED." Fri, 24 Sep 2021 16:10:51 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-9626-1/#c10869 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10869 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by pmontazemi "RESOLVED." Fri, 24 Sep 2021 16:10:39 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-9626-1/#c10868 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10868 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by pmontazemi "RESOLVED." Fri, 24 Sep 2021 16:10:24 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-9626-1/#c10867 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10867 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by pmontazemi "RESOLVED." Fri, 24 Sep 2021 16:10:09 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-9626-1/#c10866 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10866 pmontazemi  (deleted user) replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: reviewers finished Thu, 23 Sep 2021 22:42:14 -0700 https://devapps.diality.us/cru/UI-DEN-9626-1 https://devapps.diality.us/cru/UI-DEN-9626-1 Sean Nash finished reviewing UI-DEN-9626-1 UI-DEN-9626_DEV Bluetooth Cuff Integration ]]> UI-DEN-9626-1: comment by Sean Nash "RESOLVED." Thu, 23 Sep 2021 22:38:06 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10865 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10865 Sean Nash replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by Sean Nash "RESOLVED." Thu, 23 Sep 2021 22:32:36 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10864 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10864 Sean Nash replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by Sean Nash "RESOLVED." Thu, 23 Sep 2021 22:32:12 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10863 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10863 Sean Nash replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by Behrouz NematiPour "Thanks for the comment. I removed those two an..." Wed, 22 Sep 2021 14:53:09 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-9626-1/#c10862 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10862 Behrouz NematiPour replied to Sean Nash in UI-DEN-9626-1

Thanks for the comment.
I removed those two and updated the comments as well.

]]> UI-DEN-9626-1: comment by Behrouz NematiPour "Updated the comments to clarify. In ' ..., and..." Wed, 22 Sep 2021 14:51:48 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-9626-1/#c10861 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10861 Behrouz NematiPour replied to Sean Nash in UI-DEN-9626-1

Updated the comments to clarify.
In ' ..., and them,...' it meant logical AND &&.
And added a lot more comments.

]]> UI-DEN-9626-1: comment by Behrouz NematiPour "Removed." Wed, 22 Sep 2021 14:50:48 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-9626-1/#c10860 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10860 Behrouz NematiPour replied to Sean Nash in UI-DEN-9626-1

Removed.

]]> UI-DEN-9626-1: comment by Sean Nash "Remove blank line." Wed, 22 Sep 2021 10:07:16 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10859 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10859 Sean Nash commented on UI-DEN-9626-1

Remove blank line.

]]> UI-DEN-9626-1: comment by Sean Nash "In the header file, the Ethernet and sound test..." Wed, 22 Sep 2021 09:51:00 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10858 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10858 Sean Nash commented on UI-DEN-9626-1

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use).
So this comment appears to be inconsistent with the header file.

]]> UI-DEN-9626-1: comment by Sean Nash ""... and then, and them," - looks like somethin..." Wed, 22 Sep 2021 09:49:30 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10857 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10857 Sean Nash commented on UI-DEN-9626-1

"... and then, and them," - looks like something is wrong with this comment.

]]> UI-DEN-9626-1: comment by Sean Nash "RESOLVED." Tue, 21 Sep 2021 18:26:43 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10855 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10855 Sean Nash replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by Sean Nash "RESOLVED." Tue, 21 Sep 2021 18:26:20 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10854 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10854 Sean Nash replied to Behrouz NematiPour in UI-DEN-9626-1

RESOLVED.

]]> UI-DEN-9626-1: comment by Behrouz NematiPour "In UI we have multiple types of TODOs. DEBUG, ..." Tue, 21 Sep 2021 17:53:55 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-9626-1/#c10853 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10853 Behrouz NematiPour replied to Sean Nash in UI-DEN-9626-1

In UI we have multiple types of TODOs.
DEBUG, FIXME, WARNING, NOTE, TODO

]]> UI-DEN-9626-1: comment by Behrouz NematiPour "This was not a bug, It was a change request fr..." Tue, 21 Sep 2021 17:52:45 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-9626-1/#c10852 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10852 Behrouz NematiPour replied to Sean Nash in UI-DEN-9626-1

This was not a bug,
It was a change request from Sarina to remove the Rinseback Aditional 5 min counter.
I kept it in case we may need it later.

]]> UI-DEN-9626-1: comment by Sean Nash "Does this mean commenting out these 2 lines fix..." Tue, 21 Sep 2021 17:49:22 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10851 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10851 Sean Nash commented on UI-DEN-9626-1

Does this mean commenting out these 2 lines fixed a bug? If so, why not just delete them?

]]> UI-DEN-9626-1: comment by Sean Nash "Temporary? Maybe add a // TODO or is // DEBUG ..." Tue, 21 Sep 2021 17:48:02 -0700 Sean Nash https://devapps.diality.us/cru/UI-DEN-9626-1/#c10850 https://devapps.diality.us/cru/UI-DEN-9626-1/#c10850 Sean Nash commented on UI-DEN-9626-1

Temporary? Maybe add a // TODO or is // DEBUG something you'll know to search for later?

]]>