Fisheye on dgfirmware/firmware/App/Controllers/FlowSensors.c https://devapps.diality.us/changelog/~br%3Drelease%25402fp1b%25402fmaster/dgfirmware/firmware/App/Controllers/FlowSensors.c Recent activity in "dgfirmware" under directory /firmware/App/Controllers/FlowSensors.c dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 07 Feb 2025 17:52:30 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=da0deea71ed5770d98a00943369b9c17321e139f https://devapps.diality.us/changelog/dgfirmware?cs=da0deea71ed5770d98a00943369b9c17321e139f Dara Navaei committed da0deea on branch release/p1b/master in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 08 Jan 2024 14:00:04 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=7d4711edd7b40cd3e29f43e766f79a8a09586fe9 https://devapps.diality.us/changelog/dgfirmware?cs=7d4711edd7b40cd3e29f43e766f79a8a09586fe9 Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> DG-DEN-13460-2: closed by Dara Navaei Wed, 18 Oct 2023 21:20:43 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2 https://devapps.diality.us/cru/DG-DEN-13460-2 Dara Navaei Closed DG-DEN-13460-2 ]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:20:31 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19072 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19072 Dara Navaei replied to Sean Nash in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:19:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19071 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19071 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:19:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19070 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19070 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: started by Dara Navaei Wed, 18 Oct 2023 21:18:57 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2 https://devapps.diality.us/cru/DG-DEN-13460-2 Dara Navaei started review DG-DEN-13460-2 ]]> DG-DEN-13598-2: closed by Dara Navaei Wed, 18 Oct 2023 21:18:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2 https://devapps.diality.us/cru/DG-DEN-13598-2 Dara Navaei Closed DG-DEN-13598-2 ]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:18:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19069 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19069 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:18:03 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19068 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19068 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:17:22 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19067 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19067 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:17:11 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19066 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19066 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:16:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19065 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19065 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:16:38 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19064 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19064 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:16:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19063 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19063 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:15:44 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19062 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19062 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: started by Dara Navaei Wed, 18 Oct 2023 21:15:09 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2 https://devapps.diality.us/cru/DG-DEN-13598-2 Dara Navaei started review DG-DEN-13598-2 ]]> DG-DEN-13834-1: closed by Dara Navaei Wed, 18 Oct 2023 21:05:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1 https://devapps.diality.us/cru/DG-DEN-13834-1 Dara Navaei Closed DG-DEN-13834-1 ]]> DG-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 21:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1/#c19058 https://devapps.diality.us/cru/DG-DEN-13834-1/#c19058 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13834-1: started by Dara Navaei Wed, 18 Oct 2023 21:03:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1 https://devapps.diality.us/cru/DG-DEN-13834-1 Dara Navaei started review DG-DEN-13834-1 ]]> DG-DEN-15791-1: closed by Dara Navaei Sat, 30 Sep 2023 13:05:03 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15791-1 https://devapps.diality.us/cru/DG-DEN-15791-1 Dara Navaei Closed DG-DEN-15791-1 ]]> DG-DEN-15791-1: reviewers finished Sat, 30 Sep 2023 13:03:41 -0700 https://devapps.diality.us/cru/DG-DEN-15791-1 https://devapps.diality.us/cru/DG-DEN-15791-1 Dara Navaei and jtaylor  (deleted user) finished reviewing DG-DEN-15791-1 DG-DEN-15791_DG Software Design Description ]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Sat, 30 Sep 2023 13:02:28 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 https://devapps.diality.us/changelog/dgfirmware?cs=164e1a3ffca18c703676bc7f57f5903c76050600 Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes. Fri, 22 Sep 2023 15:32:16 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=d2ec7bf847131ad0f044fc122aef360d726a2dc5 https://devapps.diality.us/changelog/dgfirmware?cs=d2ec7bf847131ad0f044fc122aef360d726a2dc5 Sean Nash committed d2ec7bf on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware DEN-15791: Doxygen comment fixes.

· /firmware/App/Controllers/ConductivitySensors.h (-3, +0) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-3, +0) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-8, +9) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-4, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
]]> DG-DEN-15791-1: started by Dara Navaei Tue, 29 Aug 2023 14:07:11 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15791-1 https://devapps.diality.us/cru/DG-DEN-15791-1 Dara Navaei started review DG-DEN-15791-1 ]]> dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 09 Aug 2023 17:36:10 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8ebab816fadec93b2f3c6a42f15a07c26b3a4f59 https://devapps.diality.us/changelog/dgfirmware?cs=8ebab816fadec93b2f3c6a42f15a07c26b3a4f59 Dara Navaei committed 8ebab81 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
]]> DG-DEN-16125-1: closed by Dara Navaei Wed, 09 Aug 2023 17:29:40 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16125-1 https://devapps.diality.us/cru/DG-DEN-16125-1 Dara Navaei Closed DG-DEN-16125-1 ]]> DG-DEN-16125-1: reviewers finished Wed, 09 Aug 2023 16:59:27 -0700 https://devapps.diality.us/cru/DG-DEN-16125-1 https://devapps.diality.us/cru/DG-DEN-16125-1 wbracken  (deleted user) and Sean Nash finished reviewing DG-DEN-16125-1 DG-DEN-16125_DG Chem Flush DG Does Not Transition From Flush R1 TO R2 Drain R2 TO Cancel Water ]]> dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed... Wed, 09 Aug 2023 16:44:24 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=56b1e4181f80f63d290101348dacdb3f1c39c538 https://devapps.diality.us/changelog/dgfirmware?cs=56b1e4181f80f63d290101348dacdb3f1c39c538 Dara Navaei committed 56b1e41 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

· /firmware/App/Controllers/ConcentratePumps.c (-8, +7) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +2) | History | Source | Diff
]]> DG-DEN-16125-1: started by Dara Navaei Wed, 09 Aug 2023 12:42:43 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16125-1 https://devapps.diality.us/cru/DG-DEN-16125-1 Dara Navaei started review DG-DEN-16125-1 ]]>