Fisheye on dgfirmware/firmware/App/Controllers/ROPump.c

dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 07 Feb 2025 17:52:30 -0800

Dara Navaei committed da0deea on branch release/p1b/master in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:00:04 -0800

Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 11:23:57 -0700

Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Dara Navaei — Sat, 30 Sep 2023 13:06:29 -0700

Dara Navaei committed 1ada953 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

· /firmware/App/Controllers/ROPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +9)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-3, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 30 Sep 2023 13:02:28 -0700

Dara Navaei committed 164e1a3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 57 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FluidLeak.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-15791.

Sean Nash — Sat, 30 Sep 2023 11:41:29 -0700

Sean Nash committed d371983 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware

Merged staging to DEN-15791.

· /firmware/App/Controllers/ROPump.c	(-3, +15)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-6, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-67, +84)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-10, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +118)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +14)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST changes

Dara Navaei — Thu, 28 Sep 2023 16:44:38 -0700

Dara Navaei committed 8533726 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code for VectorCAST changes

· /firmware/App/Controllers/ROPump.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-15791: Doxygen comment fixes.

Sean Nash — Fri, 22 Sep 2023 15:32:16 -0700

Sean Nash committed d2ec7bf on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 58 more in dgfirmware

DEN-15791: Doxygen comment fixes.

· /firmware/App/Controllers/ConductivitySensors.h	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FluidLeak.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-8, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-4, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 13 Sep 2023 09:33:58 -0700

Dara Navaei committed c7d750b on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Update per code review comments

Fri, 01 Sep 2023 13:35:08 -0700

Bill Bracken committed 2fcf9be on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Update per code review comments

· /firmware/App/Controllers/ROPump.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Requirements changes

Thu, 31 Aug 2023 23:23:43 -0700

Bill Bracken committed 758a99a on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Requirements changes

· /firmware/App/Controllers/ROPump.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change to alarm limits and persistence values

Thu, 31 Aug 2023 14:38:15 -0700

Bill Bracken committed 5a76689 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Change to alarm limits and persistence values

· /firmware/App/Controllers/Pressures.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Move max pwm check to execROPumpMonitor

Wed, 30 Aug 2023 10:08:05 -0700

Bill Bracken committed b37ec50 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Move max pwm check to execROPumpMonitor

· /firmware/App/Controllers/ROPump.c

(-6, +5)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

Fri, 25 Aug 2023 17:23:56 -0700

Bill Bracken committed 4a57af4 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

· /firmware/App/Controllers/ROPump.c

(-1, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Address code review comments

Fri, 25 Aug 2023 16:59:31 -0700

Bill Bracken committed b9ffb58 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Address code review comments

· /firmware/App/Controllers/ROPump.c

(-3, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change persistence to 12 seconds

Wed, 23 Aug 2023 10:59:22 -0700

Bill Bracken committed 2632acc on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Change persistence to 12 seconds

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Change #define name

Mon, 21 Aug 2023 14:31:08 -0700

Bill Bracken committed e26d6d6 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Change #define name

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Correct #define name

Fri, 18 Aug 2023 13:59:06 -0700

Bill Bracken committed 719751a on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Correct #define name

· /firmware/App/Controllers/ROPump.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-13973 Rename alarm

Fri, 18 Aug 2023 13:53:50 -0700

Bill Bracken committed 784b7a2 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-13973 Rename alarm

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15973 Add RO Pump max PWM alarm

Fri, 18 Aug 2023 13:31:01 -0700

Bill Bracken committed e57a786 on branch DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more in dgfirmware

DEN-15973 Add RO Pump max PWM alarm

· /firmware/App/Controllers/ROPump.c

(-0, +11)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 26 Jul 2023 11:39:37 -0700

Dara Navaei committed 9b8889b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 92 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921, DEN-15868 changed the direction of the pumps in RO permeate sample mode. Changed the code to check the flow i...

Dara Navaei — Tue, 25 Jul 2023 08:49:32 -0700

Dara Navaei committed e240618 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921, DEN-15868 changed the direction of the pumps in RO permeate sample mode. Changed the code to check the flow in heat disinfect and active cool to only when the system is not hot

· /firmware/App/Controllers/DrainPump.c	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 12 Jul 2023 11:15:25 -0700

Dara Navaei committed ff9e67d on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 99 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15802 Correct alarm 191.192 testing based upon specific modes.

Fri, 07 Jul 2023 17:53:54 -0700

Bill Bracken committed bd782e4 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 100 more in dgfirmware

DEN-15802 Correct alarm 191.192 testing based upon specific modes.

· /firmware/App/Controllers/ROPump.c

(-2, +3)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): STRL-15802 Add Heat Disinfect Active Cool to logic to test for 191, 192

Fri, 07 Jul 2023 11:23:03 -0700

Bill Bracken committed 13cb530 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 100 more in dgfirmware

STRL-15802 Add Heat Disinfect Active Cool to logic to test for 191, 192

· /firmware/App/Controllers/ROPump.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:57:02 -0700

Dara Navaei committed d325999 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 106 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff

… 11 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367 addressed the code review comments

Dara Navaei — Tue, 13 Jun 2023 10:37:58 -0700

Dara Navaei committed fab0257 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 107 more in dgfirmware

DEN-15367 addressed the code review comments

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-3, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367, DEN-15404 worked on RO permeate sample mode

Dara Navaei — Fri, 09 Jun 2023 17:42:57 -0700

Dara Navaei committed 8822f86 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 107 more in dgfirmware

DEN-15367, DEN-15404 worked on RO permeate sample mode

· /firmware/App/Controllers/ROPump.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-7, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 02 Jun 2023 12:45:17 -0700

Dara Navaei committed 782cbac on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 109 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15455 updated chem disinfect and chem flush disinfect to not clear the acid insert and remove alarms

Dara Navaei — Wed, 31 May 2023 14:59:01 -0700

Dara Navaei committed 46a9148 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 110 more in dgfirmware

DEN-15455 updated chem disinfect and chem flush disinfect to not clear the acid insert and remove alarms

· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-0, +5)	\| History	\| Source	\| Diff