· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	| History	| Source	| Diff

]]> Mon, 16 Jun 2025 16:21:03 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=a888f0f268896151a649da228f5a5119bbe2aa33 https://devapps.diality.us/changelog/dgfirmware?cs=a888f0f268896151a649da228f5a5119bbe2aa33 Dara Navaei committed a888f0f on branch release/p1b/master in dgfirmware Merged release/p1b/staging

· /firmware/App/Controllers/ConductivitySensors.c	(-11, +39)	| History	| Source	| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeDrain.c	(-41, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFill.c	(-181, +60)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFill.h	(-10, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-29, +4)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-5, +40)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-56, +56)	| History	| Source	| Diff
· /firmware/App/Services/Reservoirs.c	(-69, +65)	| History	| Source	| Diff
· /firmware/App/Services/SystemComm.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-64, +71)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-6, +9)	| History	| Source	| Diff

]]> Mon, 16 Jun 2025 15:23:32 -0700 https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Michael Garthwaite finished reviewing DG-DEN-17299-1 DG-DEN-17299_Release 22 P1B Staging ]]> Fri, 13 Jun 2025 14:33:31 -0700 https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Sean Nash finished reviewing DG-DEN-17299-1 DG-DEN-17299_Release 22 P1B Staging ]]> Fri, 13 Jun 2025 09:44:52 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=75c1e08603496809a6554b7540c9b78a66cb3733 https://devapps.diality.us/changelog/dgfirmware?cs=75c1e08603496809a6554b7540c9b78a66cb3733 Dara Navaei committed 75c1e08 on branch DEN-17299-release_22_p1b_staging, DENBUG-327-baro-sensor-data-refresh-P1B_STAGING_TRANSFER and 2 more in dgfirmware DEN-17299 added the code changes from staging

· /firmware/App/Controllers/ConductivitySensors.c	(-11, +39)	| History	| Source	| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Modes/ModeDrain.c	(-41, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFill.c	(-181, +59)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFill.h	(-10, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-29, +4)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-5, +40)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-56, +56)	| History	| Source	| Diff
· /firmware/App/Services/Reservoirs.c	(-69, +65)	| History	| Source	| Diff
· /firmware/App/Services/SystemComm.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.c	(-64, +71)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommMessages.h	(-6, +9)	| History	| Source	| Diff

]]> Fri, 13 Jun 2025 09:11:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Dara Navaei started review DG-DEN-17299-1 ]]> Thu, 12 Jun 2025 15:01:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1 Dara Navaei Closed DG-DENBUG-318-1 ]]> Mon, 09 Jun 2025 09:33:33 -0700 https://devapps.diality.us/cru/DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1 Michael Garthwaite finished reviewing DG-DENBUG-318-1 DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging ]]> Thu, 05 Jun 2025 16:20:08 -0700 https://devapps.diality.us/cru/DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1 Sean Nash finished reviewing DG-DENBUG-318-1 DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging ]]> Thu, 05 Jun 2025 16:19:53 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22161 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22161 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

Done

hd mode should be >= standby mode. You have it backward.

RESOLVED in CODE WALKTHROUGH.

Done.

Should we have before and after values in event data?

RESOLVED in CODE WALKTHROUGH.

Removed. UI is updated too.

RESOLVED in CODE WALKTHROUGH.

Done

It is an input - don't remove flag there. It is not an output - so remove it there.

Done

RESOLVED in CODE WALKTHROUGH.

I don't see the flag being set in this function.

Why are we keeping these in the broadcast?

RESOLVED in CODE WALKTHROUGH.

Done

Done

Should you do something with the received max ratio? It's local, so it's just being dropped.

max ratio