Fisheye on hdfirmware/firmware/App/Services/AlarmMgmt.c

hdfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 10 Apr 2025 15:02:45 -0700

Dara Navaei committed d390fa5 on branch release/p1b/master in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/SalineBolus.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/SalineBolus.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/TreatmentRecirc.c

(-2, +2)

| History

| Source

| Diff

… 5 more files in changeset.

HD-DENBUG-298-2: closed by Dara Navaei

Dara Navaei — Thu, 10 Apr 2025 15:01:07 -0700

Dara Navaei Closed HD-DENBUG-298-2

hdfirmware (release/p1b/master): Merged release/p1b/staging

Dara Navaei — Thu, 10 Apr 2025 14:58:53 -0700

Dara Navaei committed 8639aa0 on branch release/p1b/master in hdfirmware

Merged release/p1b/staging

· /firmware/App/Controllers/DialInFlow.c

(-3, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.h

(-54, +55)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.c

(-389, +40)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.h

(-21, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-6, +46)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-20, +131)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.h

(-0, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-18, +49)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.h

(-2, +17)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-0, +31)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-15, +14)

| History

| Source

| Diff

· /firmware/App/Modes/TreatmentRecirc.c

(-1, +10)

| History

| Source

| Diff

· /firmware/App/Modes/TreatmentStop.c

(-2, +40)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-528, +550)

| History

| Source

| Diff

… 3 more files in changeset.

HD-DENBUG-298-2: reviewers finished

Wed, 09 Apr 2025 16:45:04 -0700

Michael Garthwaite and Sean Nash finished reviewing HD-DENBUG-298-2

HD-DENBUG-298_User Unable TO Deliver Saline P1B Staging

hdfirmware (release/p1b/staging): DENBUG-298 updated the code from staging

Dara Navaei — Tue, 08 Apr 2025 16:23:10 -0700

Dara Navaei committed 2f98074 on branch DEN-17273-release_21_cpp_check_fix-P1B-STAGING, DEN-17299-release_22_p1b_staging and 4 more in hdfirmware

DENBUG-298 updated the code from staging

· /firmware/App/Controllers/DialInFlow.c

(-3, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.h

(-54, +55)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.c

(-389, +40)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.h

(-21, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-6, +46)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-20, +131)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.h

(-0, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-18, +49)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.h

(-2, +17)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-0, +31)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-15, +14)

| History

| Source

| Diff

· /firmware/App/Modes/SalineBolus.c

(-0, +432)

| History

| Source

· /firmware/App/Modes/SalineBolus.h

(-0, +69)

| History

| Source

· /firmware/App/Modes/TreatmentRecirc.c

(-1, +10)

| History

| Source

| Diff

… 5 more files in changeset.

HD-DENBUG-298-2: started by Dara Navaei

Dara Navaei — Tue, 08 Apr 2025 14:25:29 -0700

Dara Navaei started review HD-DENBUG-298-2

HD-DENBUG-298-1: closed by Dara Navaei

Dara Navaei — Fri, 04 Apr 2025 14:57:54 -0700

Dara Navaei Closed HD-DENBUG-298-1

HD-DENBUG-298-1: reviewers finished

Fri, 04 Apr 2025 13:56:36 -0700

Michael Garthwaite and Sean Nash finished reviewing HD-DENBUG-298-1

HD-DENBUG-298_User Unable TO Deliver Saline Bolus During Alarm Conditions Where The Blood Pump IS Recirculating

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 04 Apr 2025 12:50:09 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Dara Navaei "Done"

Dara Navaei — Fri, 04 Apr 2025 12:47:27 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

HD-DENBUG-298-1: comment by Sean Nash "Bad practice to have two calls to same function..."

Sean Nash — Fri, 04 Apr 2025 12:37:00 -0700

Sean Nash commented on HD-DENBUG-298-1

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 04 Apr 2025 12:26:59 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Dara Navaei "Yes. I think we should have these events to inf..."

Dara Navaei — Fri, 04 Apr 2025 10:54:19 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Yes. I think we should have these events to information.

HD-DENBUG-298-1: comment by Sean Nash "Are these permanent?"

Sean Nash — Thu, 03 Apr 2025 09:00:58 -0700

Sean Nash commented on HD-DENBUG-298-1

Are these permanent?

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 01 Apr 2025 08:34:57 -0700

Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Mon, 31 Mar 2025 09:05:20 -0700

Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Sean Nash "Add comment explaining what we're doing here."

Sean Nash — Fri, 28 Mar 2025 13:17:43 -0700

Sean Nash commented on HD-DENBUG-298-1

Add comment explaining what we're doing here.

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 28 Mar 2025 13:17:14 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Dara Navaei "Moved it to OperationModes"

Dara Navaei — Fri, 28 Mar 2025 13:15:45 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Moved it to OperationModes

HD-DENBUG-298-1: comment by Sean Nash "For other confirmations, an executive (e.g. ala..."

Sean Nash — Fri, 28 Mar 2025 10:54:16 -0700

Sean Nash commented on HD-DENBUG-298-1

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 28 Mar 2025 10:25:17 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 26 Mar 2025 17:52:51 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 26 Mar 2025 09:28:16 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Sean Nash "2 blank lines above/below test banner."

Sean Nash — Wed, 26 Mar 2025 09:21:12 -0700

Sean Nash commented on HD-DENBUG-298-1

2 blank lines above/below test banner.

HD-DENBUG-298-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 25 Mar 2025 09:41:32 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 25 Mar 2025 09:37:41 -0700

Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Sean Nash "Last condition is wrong (dialysate recirc block..."

Sean Nash — Tue, 25 Mar 2025 09:36:56 -0700

Sean Nash commented on HD-DENBUG-298-1

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 25 Mar 2025 09:33:34 -0700

Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Sean Nash "These alarms we're demoting from HD fault shoul..."

Sean Nash — Fri, 21 Mar 2025 10:33:33 -0700

Sean Nash commented on HD-DENBUG-298-1

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 21 Mar 2025 08:53:39 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.