Fisheye on ro-firmware/

ro-firmware (staging): LDT-1809 merge into staging

Raghu Kallala — Thu, 04 Sep 2025 13:27:42 -0700

Raghu Kallala committed c3d50a5 on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

LDT-1809 merge into staging

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 Resolved conflicts while merging staging

Raghu Kallala — Thu, 04 Sep 2025 13:19:55 -0700

Raghu Kallala committed 60df6fd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 Resolved conflicts while merging staging

· /firmware/App/Controllers/ROPump.c	(-16, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 latest from staging

Raghu Kallala — Tue, 02 Sep 2025 11:10:25 -0700

Raghu Kallala committed 62c5b1e on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 latest from staging

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1928 merge into staging

Raghu Kallala — Tue, 02 Sep 2025 11:04:07 -0700

Raghu Kallala committed 29a01b8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

LDT-1928 merge into staging

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1928 latest from staging

Raghu Kallala — Tue, 02 Sep 2025 10:56:00 -0700

Raghu Kallala committed 8613be9 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

LDT-1928 latest from staging

ro-firmware (LDT-1735-test-config-support-for-dd): Updated ToDo check for inletpressurecheck init call

Raghu Kallala — Thu, 28 Aug 2025 13:40:10 -0700

Raghu Kallala committed c97730c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Updated ToDo check for inletpressurecheck init call

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed indentation and review comments

Raghu Kallala — Wed, 27 Aug 2025 14:54:27 -0700

Raghu Kallala committed 98b3a57 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed indentation and review comments

· /firmware/App/Controllers/ROPump.c

(-18, +18)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comment to remove flag assignment in paused state.

Raghu Kallala — Wed, 27 Aug 2025 08:16:33 -0700

Raghu Kallala committed f31d172 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comment to remove flag assignment in paused state.

· /firmware/App/Modes/InletPressureCheck.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): fixed review comments

Raghu Kallala — Tue, 26 Aug 2025 14:54:23 -0700

Raghu Kallala committed 71ea7fe on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

fixed review comments

· /firmware/App/Controllers/ROPump.c	(-30, +53)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-0, +55)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-0, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Raghu Kallala — Tue, 26 Aug 2025 10:37:51 -0700

Raghu Kallala committed ba9341b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

· /firmware/App/Controllers/ROPump.c	(-100, +62)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): removed commented code per review comments

Raghu Kallala — Wed, 20 Aug 2025 08:59:24 -0700

Raghu Kallala committed ff3e2e3 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

removed commented code per review comments

· /firmware/App/Controllers/ROPump.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments.

Raghu Kallala — Wed, 20 Aug 2025 06:31:28 -0700

Raghu Kallala committed e91ecdf on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments.

· /firmware/App/Modes/InletPressureCheck.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments to remove unwanted code lines and handled state assignment.

Raghu Kallala — Tue, 19 Aug 2025 10:24:42 -0700

Raghu Kallala committed 44b3345 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments to remove unwanted code lines and handled state assignment.

· /firmware/App/Modes/InletPressureCheck.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): declared result at the top of the scope for test functions

Raghu Kallala — Tue, 19 Aug 2025 10:14:41 -0700

Raghu Kallala committed 4dec0c9 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

declared result at the top of the scope for test functions

· /firmware/App/Controllers/ROPump.c

(-3, +6)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Removed commented code lines

Raghu Kallala — Wed, 13 Aug 2025 15:00:35 -0700

Raghu Kallala committed 5b95672 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Removed commented code lines

· /firmware/App/Controllers/ROPump.c

(-2, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Addressed review comments and modified the override behavior as discussed.

Raghu Kallala — Wed, 13 Aug 2025 13:46:21 -0700

Raghu Kallala committed d305dff on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Addressed review comments and modified the override behavior as discussed.

· /firmware/App/Controllers/ROPump.c	(-174, +161)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Implemented Inlet Pressure check functionality with Boost Pump

Raghu Kallala — Wed, 13 Aug 2025 07:58:53 -0700

Raghu Kallala committed bdf1e3a on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Implemented Inlet Pressure check functionality with Boost Pump

· /firmware/App/Modes/InletPressureCheck.c	(-0, +371)	\| History	\| Source
· /firmware/App/Modes/InletPressureCheck.h	(-0, +53)	\| History	\| Source
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Addressed review comments to remove blank lines

Raghu Kallala — Mon, 11 Aug 2025 10:15:49 -0700

Raghu Kallala committed 04a86b2 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Addressed review comments to remove blank lines

· /firmware/App/Controllers/ROPump.c

(-6, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fix for RO Pump override set and reset.

Raghu Kallala — Fri, 08 Aug 2025 11:53:01 -0700

Raghu Kallala committed 75ccce2 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fix for RO Pump override set and reset.

· /firmware/App/Controllers/ROPump.c

(-75, +239)

| History

| Source

| Diff

ro-firmware (): Modified handlers to change state based on data value rather than using get functions.

Raghu Kallala — Fri, 08 Aug 2025 11:34:13 -0700

Raghu Kallala committed a354b53 on branch in ro-firmware

Modified handlers to change state based on data value rather than using get functions.

· /firmware/App/Controllers/ROPump.c

(-11, +11)

| History

| Source

| Diff

ro-firmware (): Fixed the override reset behavior in test function

Raghu Kallala — Thu, 07 Aug 2025 14:22:12 -0700

Raghu Kallala committed 5404c0f on branch in ro-firmware

Fixed the override reset behavior in test function

· /firmware/App/Controllers/ROPump.c

(-3, +12)

| History

| Source

| Diff

ro-firmware (): Changes for RO pump override reset.

Raghu Kallala — Thu, 07 Aug 2025 12:08:30 -0700

Raghu Kallala committed 3936f36 on branch in ro-firmware

Changes for RO pump override reset.

· /firmware/App/Controllers/ROPump.c

(-31, +10)

| History

| Source

| Diff

ro-firmware (): Updated code for multiple override.

Raghu Kallala — Thu, 07 Aug 2025 08:46:37 -0700

Raghu Kallala committed 91982bb on branch in ro-firmware

Updated code for multiple override.

· /firmware/App/Controllers/ROPump.c

(-61, +153)

| History

| Source

| Diff

ro-firmware (): WIP for setting multiple overrides

Raghu Kallala — Tue, 05 Aug 2025 12:41:00 -0700

Raghu Kallala committed 2169bb1 on branch in ro-firmware

WIP for setting multiple overrides

· /firmware/App/Controllers/ROPump.c

(-5, +14)

| History

| Source

| Diff

ro-firmware (): removed check for zero flow rate

Raghu Kallala — Tue, 05 Aug 2025 10:24:57 -0700

Raghu Kallala committed 8a8d1df on branch in ro-firmware

removed check for zero flow rate

· /firmware/App/Controllers/ROPump.c

(-5, +0)

| History

| Source

| Diff

ro-firmware (): Added backup variable for pump data and fixed set function behavior

Raghu Kallala — Tue, 05 Aug 2025 10:22:04 -0700

Raghu Kallala committed e2d09e0 on branch in ro-firmware

Added backup variable for pump data and fixed set function behavior

· /firmware/App/Controllers/ROPump.c

(-74, +154)

| History

| Source

| Diff