Comment Search

RESOLVED in CODE WALKTHROUGH.

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes , right now its void , so that's why i didn't change that . I will push new code

RESOLVED in CODE WALKTHROUGH.

I don't think you have a variable defined for state yet.

RESOLVED.

Rename blood_leak_state to blood_leak_data.

I will test this in DEN-12224.

RESOLVED in CODE WALKTHROUGH.

Please remove the box column, we decided not to use it in the Application documentation.
Please do this for all the new models added.

Changed function prototype from BOOL checkForPrimeOcclusion( BOOL stopPump ) to BOOL checkForPrimeOcclusion( void );

DG_MODE_SOLO does not have DG_STANDBY_MODE_STATE_IDLE.

Do we need to fix this?

RESOLVED.

That is correct and I have something in mind to improve the code.

But I believe this is more related to Dialin bugs:
1 - First one which we talked about that Dialin creates all the objects even it is not being used in the _init_.py files which cause different use-cases of the API to be not compatible together and can't be used together.
2 - the other issue is that the Dialin as an API should by nature be a passive code and just have the capabilities to be extended those observers have to be removed from Dialin.

For now, I'll put a workaround for this, and later we should discuss the better implementation of the Dialin API.

Actually, this is correct.
And it should not have parenthesis like you said, otherwise it becomes incorrect.
if I write it like :

 ( ( x * ( maximum - minimum ) ) / width ) + minimum 

then too many /redundant parentheses make it confusing.

Thanks for your attention to the details.
I think you are right.
Probably the code review is duplicate, my bad.

Removed line heparinBolusTargetRate.data = heparinBolusTargetRate.ovInitData;

RESOLVED in CODE WALKTHROUGH.

I uncommented the code.

RESOLVED in CODE WALKTHROUGH.

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

Do we not need a battery remaining percent override function for testing?