application

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7320: Addressed code review comments

    • -15
    • +21
    /sources/gui/qml/globals/Variables.qml
    • -2
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
Are these the only measurable levels?

Are these the only measurable levels?

Did you do the Code Coverage? If not please remove these lines which I think are the leftovers of copy/paste. so later we test them.

Did you do the Code Coverage?
If not please remove these lines which I think are the leftovers of copy/paste.
so later we test them.

I see that you nicely put the _keyboard.setVisible(true) in the TextEntry component. Don't you think it would be better to put _keyboard.setVisible(false) on onEnteredPressed in the TextEntry compo...

I see that you nicely put the _keyboard.setVisible(true) in the TextEntry component.
Don't you think it would be better to put _keyboard.setVisible(false) on onEnteredPressed in the TextEntry component as well, somewehere next to the lines below?

onFocusChanged: {
    if (focus) {ome whereo
        selectAll()
        _keyboard.setVisible(true)
    }
}

onAccepted: {
    _root.enterPressed()
} 
Why onPressed? Should be onClicked.

Why onPressed?
Should be onClicked.

Do we need to set the background color? I think the default ScreenItem backgroundColor would be fine!

Do we need to set the background color?
I think the default ScreenItem backgroundColor would be fine!

Recently I'm removing the "Response" from the log's "infoText" function, since the log already has the source we will see it is coming from HD/DG and it make the "Response" useless and gets more sp...

Recently I'm removing the "Response" from the log's "infoText" function, since the log already has the source we will see it is coming from HD/DG and it make the "Response" useless and gets more space only.
Please apply the same for the DG.
And don't forget to update the doxygen comment as well.

Please use a consistent "else" style. we are currently using Stroustrup style which is like: } else { or use something like: } else {

Please use a consistent "else" style.
we are currently using Stroustrup style which is like:

}
else {

or use something like:

} else {
since you are setting the bottom margin we need to think about the object that are showing up on the bottom of the screen and since the mainMenu comes on top then it's height may not be relevant ...
  • since you are setting the bottom margin we need to think about the object that are showing up on the bottom of the screen and since the mainMenu comes on top then it's height may not be relevant to the bottom of the screen area.
    Could be better to use notificationHeight which is used for the notifications that are showing up at the bottom.
  • why it has been used by twise the size?
Please give a better name to this rect. like _contentRect so it gives the idea of why it has been defined.

Please give a better name to this rect. like _contentRect so it gives the idea of why it has been defined.

This process is called in the main thread (GUI thread), and any issue will freeze the UI. Let's talk about it before any decision. I need to know more about the code structure.

This process is called in the main thread (GUI thread), and any issue will freeze the UI.
Let's talk about it before any decision.
I need to know more about the code structure.

QStringLiteral should be used for a constant string that we know is not going to change so those will be created at compile time and not every time. Here seem all the options have to run and buil...
  • QStringLiteral should be used for a constant string that we know is not going to change so those will be created at compile time and not every time.
    Here seem all the options have to run and build at runtime.
  • Why used QLatin1Char instead of only "0"?
    This is a constant leading zero.
couldn't we use the date command instead which is more common?

couldn't we use the date command instead which is more common?

Please put more description of why we should have these two lines?

Please put more description of why we should have these two lines?

Wouldn't be better to define just one set of common "settings..." variables and bind the others to that instead of having a chain of binding? Preffered: settings<1>: 85 settings<2>: 75 settingsBLE...

Wouldn't be better to define just one set of common "settings..." variables and bind the others to that instead of having a chain of binding?
Preffered:

settings<1>: 85
settings<2>: 75

settingsBLE<1>:settings<1>
....
settingsWifi<1>: settings<1>
...

instead of the chain of:

settings<1>: 85
settings<2>: 75

settingsBLE<1>:settings<1>
....
settingsWifi<1>: settingsBLE<1>
...
DEN-7461: Meetings & Support - Pre-Treatment Integration

- Integration modifications

- UF Modifications request

- Saline Modification request

- Updated the validation mAccepted to be 1=true and 0=false.

- Heparin Stopped stated modification request

    • -1
    • +2
    /sources/gui/qml/components/Footer.qml
    • -1
    • +1
    /sources/gui/qml/components/TextRect.qml
    • -0
    • +3
    /sources/gui/qml/pages/ManagerStack.qml
    • -0
    • +3
    /sources/gui/qml/pages/SettingsStack.qml
  1. … 17 more files in changeset.
DEN-7523, DEN-7050: Upon bootup, connection to DialityWEP, DialityWAPA, DialityWAPB, and DilaityIoT succeeded with ping test.

    • -0
    • +1
    /scripts/wifi_request_auto_assigned_ip.sh
    • -2
    • +8
    /sources/gui/qml/components/TextEntry.qml
    • -0
    • +18
    /sources/gui/qml/pages/SettingsWifi.qml
DEN-7408: preTx: Implementation [Navigation] ( 3 )

- Added Rejection reason texts.

- Removed unused view.

- Fixed heparin ranges.

DEN-7518: preTx: Implementation [Screens] ( 3 )

- The first round of the pre-treatment flow works.

    • -10
    • +10
    /sources/canbus/MessageDispatcher.cpp
    • -9
    • +9
    /sources/canbus/MessageInterpreter.cpp
  1. … 52 more files in changeset.
No Msg Box?

No Msg Box?

No Msg Box?

No Msg Box?

DEN-7420: preTx: Implementation [Messaging] ( 3 )

    • -41
    • +144
    /sources/canbus/MessageDispatcher.cpp
    • -6
    • +17
    /sources/canbus/MessageDispatcher.h
    • -19
    • +40
    /sources/canbus/MessageGlobals.h
    • -39
    • +52
    /sources/canbus/MessageInterpreter.cpp
  1. … 50 more files in changeset.
DEN-7518: preTx: Implementation [Screens] ( 3 )

    • -2
    • +5
    /sources/gui/qml/globals/Variables.qml
DEN-7050, DEN-7522, DEN-7523: Improved auto dhcp assignment time, connected to DialityWEP, DialityWAPA, DialityWAPB, and DilaityIoT consecutively in one test.

    • -0
    • +7
    /scripts/wifi_generate_wpa_supplicant.sh
    • -34
    • +6
    /scripts/wifi_request_auto_assigned_ip.sh
    • -0
    • +12
    /scripts/wifi_save_dhcp_interface.sh
    • -0
    • +9
    /scripts/wifi_save_static_interface_assignments.sh
  1. … 6 more files in changeset.
DEN-7139: preTx: Implementation [Screens] ( 2 )

    • -1
    • +1
    /sources/gui/qml/components/Circle.qml
    • -0
    • +35
    /sources/gui/qml/components/Footer.qml
    • -1
    • +1
    /sources/gui/qml/components/StepIndicator.qml
    • -0
    • +68
    /sources/gui/qml/components/TimeCircle.qml
    • -5
    • +5
    /sources/gui/qml/compounds/CheckListView.qml
    • -0
    • +68
    /sources/gui/qml/compounds/StepNavigationTitleBar.qml
    • -1
    • +8
    /sources/gui/qml/globals/Variables.qml
  1. … 25 more files in changeset.
DEN-7050: Added missing echo to dns script

DEN-7050: Added missing " in dns script

DEN-7050: Updated set dns script

DEN-7315: Removed unneeded import

UI-DEN-7035_Date Time Set
UI-DEN-7035_Date Time Set