application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Mar 2021
3:26 pm

Peter Lucia <plucia@diality.com>

DEN-7320: Removed unused datetime functions

Options
    • -50
    • +0
    /sources/view/VDateTime.cpp
    • -5
    • +0
    /sources/view/VDateTime.h
2:50 pm

plucia  (deleted user)

Sure, I've updated it to use the date command.

Sure, I've updated it to use the date command.

2:50 pm

plucia  (deleted user)

Done

Done

2:50 pm

plucia  (deleted user)

Sounds good, I've removed setting the background color

Sounds good, I've removed setting the background color

2:50 pm

plucia  (deleted user)

Done

Done

2:49 pm

plucia  (deleted user)

Done

Done

2:49 pm

plucia  (deleted user)

There is one use case with the manual BP / HR entry where the keyboard is kept visible after the user presses 'Enter'. This allows the focus to move from systolic -> diastolic -> HR automatically w...

There is one use case with the manual BP / HR entry where the keyboard is kept visible after the user presses 'Enter'. This allows the focus to move from systolic -> diastolic -> HR automatically without causing it to flash invisible and then visible. So at the time it was left it up to the developer of the component to decide when to minimize the keyboard in case it would need to stay up as they kept moved between input fields.

If we remove automatically transitioning from one input field to the next in the manual BP / HR entry pop up, then I'd say there's no reason not to hide the keyboard inside the TextEntry component when Enter is pressed.

2:49 pm

plucia  (deleted user)

Done

Done

2:49 pm

plucia  (deleted user)

Sure, I've updated it to remove the chain of bindings

Sure, I've updated it to remove the chain of bindings

2:49 pm

plucia  (deleted user)

From my design meeting notes I have it written down that we will always be in pacific time as no other timezones will be supported. So, these lines just force the timezone to PST. I've moved this t...

From my design meeting notes I have it written down that we will always be in pacific time as no other timezones will be supported. So, these lines just force the timezone to PST. I've moved this to setup.sh since it really only needs to be run once. Then later more work can be done to add support for timezone adjustment.

2:48 pm

plucia  (deleted user)

Same as above

Same as above

2:48 pm

plucia  (deleted user)

The mail box has been removed from all message actually, as they are no longer needed. I've now removed it from the docstring here as well

The mail box has been removed from all message actually, as they are no longer needed. I've now removed it from the docstring here as well

2:48 pm

plucia  (deleted user)

Twice the size of the main menu height (140) happened to leave a good sized margin between minimized alarm + main menu and the save button. I've updated it to be defined more clearly so the notific...

Twice the size of the main menu height (140) happened to leave a good sized margin between minimized alarm + main menu and the save button.
I've updated it to be defined more clearly so the notification height (60) + the main menu height (70) + settingsNotificationMargin (10) decides the bottomMargin instead of just 2x the main menu height.

2:48 pm

plucia  (deleted user)

Done

Done

2:48 pm

Peter Lucia <plucia@diality.com>

DEN-7320: Addressed code review comments

Options
    • -6
    • +7
    /scripts/date_time_set.sh
    • -0
    • +5
    /scripts/setup.sh
    • -15
    • +21
    /sources/gui/qml/globals/Variables.qml
    • -2
    • +2
    /sources/gui/qml/pages/SettingsDateTimeSet.qml
    • -2
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -6
    • +6
    /sources/model/dg/adjustment/MAdjustDGDateTimeResponse.h
    • -4
    • +4
    /sources/model/hd/adjustment/MAdjustHDDateTimeResponse.h
    • -6
    • +6
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -4
    • +2
    /sources/view/VDateTime.cpp
    • -2
    • +0
    /sources/view/VDateTime.h
12:46 pm

pmontazemi  (deleted user)

Are these the only measurable levels?

Are these the only measurable levels?

12:13 pm

Behrouz NematiPour

Did you do the Code Coverage? If not please remove these lines which I think are the leftovers of copy/paste. so later we test them.

Did you do the Code Coverage?
If not please remove these lines which I think are the leftovers of copy/paste.
so later we test them.

12:10 pm

Behrouz NematiPour

I see that you nicely put the _keyboard.setVisible(true) in the TextEntry component. Don't you think it would be better to put _keyboard.setVisible(false) on onEnteredPressed in the TextEntry compo...

I see that you nicely put the _keyboard.setVisible(true) in the TextEntry component.
Don't you think it would be better to put _keyboard.setVisible(false) on onEnteredPressed in the TextEntry component as well, somewehere next to the lines below?

onFocusChanged: {
    if (focus) {ome whereo
        selectAll()
        _keyboard.setVisible(true)
    }
}

onAccepted: {
    _root.enterPressed()
}
11:52 am

Behrouz NematiPour

Why onPressed? Should be onClicked.

Why onPressed?
Should be onClicked.

11:51 am

Behrouz NematiPour

Do we need to set the background color? I think the default ScreenItem backgroundColor would be fine!

Do we need to set the background color?
I think the default ScreenItem backgroundColor would be fine!

11:46 am

Behrouz NematiPour

Recently I'm removing the "Response" from the log's "infoText" function, since the log already has the source we will see it is coming from HD/DG and it make the "Response" useless and gets more sp...

Recently I'm removing the "Response" from the log's "infoText" function, since the log already has the source we will see it is coming from HD/DG and it make the "Response" useless and gets more space only.
Please apply the same for the DG.
And don't forget to update the doxygen comment as well.

11:35 am

Behrouz NematiPour

Please use a consistent "else" style. we are currently using Stroustrup style which is like: } else { or use something like: } else {

Please use a consistent "else" style.
we are currently using Stroustrup style which is like:

}
else {

or use something like:

} else {
11:22 am

Behrouz NematiPour

since you are setting the bottom margin we need to think about the object that are showing up on the bottom of the screen and since the mainMenu comes on top then it's height may not be relevant ...
  • since you are setting the bottom margin we need to think about the object that are showing up on the bottom of the screen and since the mainMenu comes on top then it's height may not be relevant to the bottom of the screen area.
    Could be better to use notificationHeight which is used for the notifications that are showing up at the bottom.
  • why it has been used by twise the size?
11:19 am

Behrouz NematiPour

Please give a better name to this rect. like _contentRect so it gives the idea of why it has been defined.

Please give a better name to this rect. like _contentRect so it gives the idea of why it has been defined.

11:09 am

Behrouz NematiPour

This process is called in the main thread (GUI thread), and any issue will freeze the UI. Let's talk about it before any decision. I need to know more about the code structure.

This process is called in the main thread (GUI thread), and any issue will freeze the UI.
Let's talk about it before any decision.
I need to know more about the code structure.

11:00 am

Behrouz NematiPour

QStringLiteral should be used for a constant string that we know is not going to change so those will be created at compile time and not every time. Here seem all the options have to run and buil...
  • QStringLiteral should be used for a constant string that we know is not going to change so those will be created at compile time and not every time.
    Here seem all the options have to run and build at runtime.
  • Why used QLatin1Char instead of only "0"?
    This is a constant leading zero.
10:37 am

Behrouz NematiPour

couldn't we use the date command instead which is more common?

couldn't we use the date command instead which is more common?

10:36 am

Behrouz NematiPour

Please put more description of why we should have these two lines?

Please put more description of why we should have these two lines?

10:32 am

Behrouz NematiPour

Wouldn't be better to define just one set of common "settings..." variables and bind the others to that instead of having a chain of binding? Preffered: settings<1>: 85 settings<2>: 75 settingsBLE...

Wouldn't be better to define just one set of common "settings..." variables and bind the others to that instead of having a chain of binding?
Preffered:

settings<1>: 85
settings<2>: 75

settingsBLE<1>:settings<1>
....
settingsWifi<1>: settings<1>
...

instead of the chain of:

settings<1>: 85
settings<2>: 75

settingsBLE<1>:settings<1>
....
settingsWifi<1>: settingsBLE<1>
...
Tuesday 23 Mar 2021
11:06 pm

Behrouz NematiPour

DEN-7461: Meetings & Support - Pre-Treatment Integration

- Integration modifications

- UF Modifications request

- Saline Modification request

- Updated the validation mAccepted to be 1=true and 0=false.

- Heparin Stopped stated modification request

Options
    • -2
    • +2
    /denali.pro.user
    • -1
    • +2
    /sources/gui/qml/components/Footer.qml
    • -1
    • +1
    /sources/gui/qml/components/TextRect.qml
    • -1
    • +2
    /sources/gui/qml/compounds/InstructionView.qml
    • -2
    • +2
    /sources/gui/qml/compounds/StepNavigationTitleBar.qml
    • -3
    • +6
    /sources/gui/qml/pages/MainStack.qml
    • -0
    • +3
    /sources/gui/qml/pages/ManagerStack.qml
    • -0
    • +3
    /sources/gui/qml/pages/SettingsStack.qml
    • -1
    • +3
    /sources/gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -5
    • +9
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -2
    • +7
    /sources/gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -0
    • +3
    /sources/gui/qml/pages/pretreatment/PreTreatmentMainStack.qml
    • -26
    • +48
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
    • -0
    • +3
    /sources/gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
    • -0
    • +3
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
  16. … 17 more files in changeset.