application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Mar 2021
12:17 pm

Behrouz NematiPour

DEN-7137: preTx: Update Design Documents

- Filled all the screen with the dynamic instruction so be able to capture for SDD.

- Removed the idea of reset and clear the stack, since it is not working.

Options
    • -8
    • +54
    /resources/settings/instructions/instructions.conf
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
10:40 am

Behrouz NematiPour

UI-DEN-7135_UI Pre Treatment
UI-DEN-7135_UI Pre Treatment
10:25 am

Behrouz NematiPour

Why Network being registered?

Why Network being registered?

9:35 am

Behrouz NematiPour

Please take a closer look at the code. At this moment you are still in the main thread and not in the Wifi Thread.

Please take a closer look at the code.
At this moment you are still in the main thread and not in the Wifi Thread.

9:31 am

Behrouz NematiPour

This is an exception that you have a view which you don't have access to its object but in general: whoever wants to use it to connect to a signal of another class should connect to that signal in ...

This is an exception that you have a view which you don't have access to its object but in general:
whoever wants to use it to connect to a signal of another class should connect to that signal in its own scop/class and do it with its private slots.
So in a case like this, these connections should be moved to the interface.
But as I said it is an exception and there no better way than what has been done here.

9:24 am

Behrouz NematiPour

If you made sure your threading is fine please remove these debug which will fill up the log so fast. Please remove the other ones as well if not needed.

If you made sure your threading is fine please remove these debug which will fill up the log so fast.
Please remove the other ones as well if not needed.

9:18 am

Behrouz NematiPour

This one might be on_ not do_. and should be private! A little confusing that if the signal comes from the interface how come the doAdd.... is public access? What happens if it has been called on t...

This one might be on_ not do_. and should be private!
A little confusing that if the signal comes from the interface how come the doAdd.... is public access?
What happens if it has been called on the qml side.
Could you please explain?

9:11 am

Behrouz NematiPour

This screen is a child of ScreenItem and not a StackItem. How come the pop() function is working here! Which Push, pop methods is being called here? If that's the one from SettingsStack, would be m...

This screen is a child of ScreenItem and not a StackItem.
How come the pop() function is working here!
Which Push, pop methods is being called here?
If that's the one from SettingsStack, would be more cleaner to move the push and pop functions in the SettingsStack.
It's fine for now but keep that in mind for later.

9:04 am

Behrouz NematiPour

Please Just make sure that the Alarm can show up and cover any dialog also.

Please Just make sure that the Alarm can show up and cover any dialog also.

8:54 am

Behrouz NematiPour

Would be better to use a non-profit website for the internet test.

Would be better to use a non-profit website for the internet test.

8:44 am

Behrouz NematiPour

This line caused some issues, we need to remove the log of the application output for now. please change it to by adding & and # before 2>>: $HOME/denali -u & # 2>> $HOME/filesystem.err &

This line caused some issues,
we need to remove the log of the application output for now.
please change it to by adding & and # before 2>>:
$HOME/denali -u & # 2>> $HOME/filesystem.err &

8:25 am

Behrouz NematiPour

8:16 am

Behrouz NematiPour

DEN-7377: preTx: Implementation [Dynamic Instruction Loading] ( 2 )

DEN-7457: Meetings & Support - General purpose

Options
    • -8
    • +30
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /en_US.udic
    • -0
    • +1
    /main.cpp
    • binary
    /resources/NotAttachedTestImages/1.png
    • binary
    /resources/NotAttachedTestImages/2.png
    • binary
    /resources/NotAttachedTestImages/3.png
    • binary
    /resources/settings/instructions/1.png
    • binary
    /resources/settings/instructions/2.png
    • binary
    /resources/settings/instructions/3.png
    • -0
    • +10
    /resources/settings/instructions/instructions.conf
    • -0
    • +25
    /resources/settings/instructions/readme.md
    • -6
    • +59
    /sources/ApplicationController.cpp
    • -5
    • +28
    /sources/ApplicationController.h
    • -8
    • +0
    /sources/Threads.h
  16. … 37 more files in changeset.
Friday 26 Mar 2021
4:59 pm

Peter Lucia <plucia@diality.com>

DEN-7521: Ensure wifi reconnects on reboot

Options
    • -6
    • +0
    /scripts/run.sh
    • -1
    • +0
    /scripts/wifi_request_auto_assigned_ip.sh
    • -1
    • +0
    /scripts/wifi_save_static_interface_assignments.sh
    • -1
    • +0
    /scripts/wifi_set_auto_assigned_ip.sh
    • -1
    • +1
    /scripts/wifi_set_gateway.sh
    • -0
    • +17
    /sources/storage/StorageGlobals.cpp
    • -0
    • +14
    /sources/storage/StorageGlobals.h
    • -4
    • +4
    /sources/view/VNetworkModel.cpp
    • -8
    • +130
    /sources/wifi/WifiInterface.cpp
    • -1
    • +6
    /sources/wifi/WifiInterface.h
10:58 am

Peter Lucia <plucia@diality.com>

DEN-7521: Adding rest of support for static IP assignments.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /denali.qrc
    • -2
    • +2
    /scripts/wifi_reset_interface.sh
    • -0
    • +0
    /scripts/wifi_save_dhcp_interface.sh
    • -2
    • +1
    /scripts/wifi_set_dns.sh
    • -0
    • +0
    /scripts/wifi_set_gateway.sh
    • -0
    • +9
    /scripts/wifi_set_static_ip.sh
    • -0
    • +9
    /scripts/wifi_set_subnetmask.sh
    • -0
    • +0
    /scripts/wifi_test_internet.sh
    • -97
    • +0
    /sources/gui/qml/dialogs/JoinNetwork.qml
    • -0
    • +103
    /sources/gui/qml/dialogs/WifiJoinDisconnect.qml
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -10
    • +28
    /sources/gui/qml/pages/SettingsWifi.qml
    • -0
    • +2
    /sources/storage/StorageGlobals.cpp
    • -0
    • +2
    /sources/storage/StorageGlobals.h
  16. … 4 more files in changeset.
Thursday 25 Mar 2021
1:37 am

Behrouz NematiPour

DEN-7408: Code improvement for navigation

- VTreatmentCreate is cleaned up. (still needs a lot of work)

Options
    • -1
    • +1
    /denali.pro.user
    • -8
    • +8
    /sources/gui/qml/components/ConfirmTreatmentTable.qml
    • -3
    • +4
    /sources/gui/qml/components/ConfirmTreatmentTableEntry.qml
    • -4
    • +11
    /sources/gui/qml/pages/MainHome.qml
    • -2
    • +10
    /sources/gui/qml/pages/MainStack.qml
    • -8
    • +5
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -0
    • +577
    /sources/view/VTreatmentCreate (legacy).cpp
    • -0
    • +258
    /sources/view/VTreatmentCreate (legacy).h
    • -569
    • +47
    /sources/view/VTreatmentCreate.cpp
    • -79
    • +31
    /sources/view/VTreatmentCreate.h
    • -15
    • +6
    /unittests/tst_views.cpp
Wednesday 24 Mar 2021
6:23 pm

Behrouz NematiPour

DEN-7408: Code improvement for navigation

- added vCondition to the page function for the stack item to pass the state property value.

- added fault , service and initial placeholder pages.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +2
    /sources/gui/qml/components/PlaceHolderText.qml
    • -3
    • +12
    /sources/gui/qml/components/StackItem.qml
    • -0
    • +2
    /sources/gui/qml/pages/MainHome.qml
    • -20
    • +33
    /sources/gui/qml/pages/MainStack.qml
    • -2
    • +2
    /sources/gui/qml/pages/postTreatment/PostTreatmentEndStack.qml
    • -2
    • +2
    /sources/gui/qml/pages/postTreatment/PostTreatmentRecirculateStack.qml
    • -5
    • +5
    /sources/gui/qml/pages/postTreatment/PostTreatmentRinsebackStack.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -3
    • +3
    /sources/gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -8
    • +8
    /sources/gui/qml/pages/pretreatment/PreTreatmentMainStack.qml
    • -11
    • +11
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
    • -13
    • +12
    /sources/gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
    • -1
    • +1
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
    • -9
    • +9
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml
4:18 pm

plucia  (deleted user)

4:13 pm

Behrouz NematiPour

We talked about a settingcontroller to be implemented later. RESOLVED

We talked about a settingcontroller to be implemented later.
RESOLVED

4:09 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:05 pm

Behrouz NematiPour

Good Point. Isn't the BLE case apply everywhere? I was thinking why we even want to hide the keyboard while users can hide it by the keyboard button on the keyboard. We may give it more thoughts. R...

Good Point.
Isn't the BLE case apply everywhere?
I was thinking why we even want to hide the keyboard while users can hide it by the keyboard button on the keyboard.
We may give it more thoughts.
RESOLVED

4:04 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

4:03 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

3:42 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:41 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:41 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:40 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:39 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:39 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:33 pm

Behrouz NematiPour

RESOLVED

RESOLVED