application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 01 Apr 2021
2:18 pm

Behrouz NematiPour

DEN-7832: Implementations [Saline and Heparin change request]

- Also removed the UF state from response.

Options
    • -1
    • +0
    /sources/ApplicationController.cpp
    • -10
    • +6
    /sources/gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +3
    /sources/gui/qml/pages/treatment/sections/TreatmentHeparin.qml
    • -1
    • +2
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -4
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustHeparinResponse.cpp
    • -3
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustHeparinResponse.h
    • -9
    • +5
    /sources/model/hd/adjustment/MTreatmentAdjustSalineResponse.cpp
    • -8
    • +5
    /sources/model/hd/adjustment/MTreatmentAdjustSalineResponse.h
    • -4
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp
    • -3
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h
    • -2
    • +2
    /sources/storage/StorageGlobals.cpp
    • -15
    • +14
    /sources/view/hd/adjustment/VTreatmentAdjustmentHeparin.cpp
    • -9
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentHeparin.h
    • -14
    • +19
    /sources/view/hd/adjustment/VTreatmentAdjustmentSaline.cpp
  16. … 6 more files in changeset.
1:27 pm

plucia  (deleted user)

It is now removed, WifiNetworkData is added to REGISTER_MODEL_METATYPES now

It is now removed, WifiNetworkData is added to REGISTER_MODEL_METATYPES now

1:26 pm

Peter Lucia <plucia@diality.com>

DEN-7054: Added Network.h to Model namespace, refactoring

Options
    • -1
    • +1
    /denali.pro
    • -358
    • +358
    /denali.pro.user
    • -1
    • +0
    /sources/gui/GuiGlobals.cpp
    • -0
    • +1
    /sources/model/MModel.h
    • -0
    • +210
    /sources/model/MWifiNetwork.h
    • -17
    • +17
    /sources/view/VNetworkModel.cpp
    • -8
    • +8
    /sources/view/VNetworkModel.h
    • -197
    • +0
    /sources/wifi/Network.h
    • -27
    • +27
    /sources/wifi/WifiInterface.cpp
    • -11
    • +11
    /sources/wifi/WifiInterface.h
    • -11
    • +11
    /unittests/tst_utilities.cpp
    • -1
    • +1
    /unittests/tst_utilities.h
11:25 am

plucia  (deleted user)

Moved this to onStart() and calling start() in main.cpp which emits a private signal didStart() that is connected to onStart as we discussed

Moved this to onStart() and calling start() in main.cpp which emits a private signal didStart() that is connected to onStart as we discussed

11:25 am

plucia  (deleted user)

Done

Done

11:25 am

plucia  (deleted user)

I agree it should be private. I've updated it to onAddNetwork and it is now private

I agree it should be private. I've updated it to onAddNetwork and it is now private

11:25 am

plucia  (deleted user)

Updated it to use the settings stack specifically when popping or pushing

Updated it to use the settings stack specifically when popping or pushing

11:24 am

plucia  (deleted user)

Just tested this and confirmed the alarm dialog shows up in front of the join / disconnect dialog

Just tested this and confirmed the alarm dialog shows up in front of the join / disconnect dialog

11:24 am

plucia  (deleted user)

Done

Done

11:24 am

plucia  (deleted user)

Done

Done

11:24 am

plucia  (deleted user)

These are just thresholds by which to categorize the signal strength of an AP. So, the actual measured signal strength will vary independently of these levels.

These are just thresholds by which to categorize the signal strength of an AP. So, the actual measured signal strength will vary independently of these levels.

11:22 am

Peter Lucia <plucia@diality.com>

DEN-7054: Addressed code review comments

Options
    • -0
    • +1
    /main.cpp
    • -1
    • +1
    /scripts/run.sh
    • -1
    • +1
    /scripts/wifi_test_internet.sh
    • -4
    • +4
    /sources/gui/qml/pages/SettingsHome.qml
    • -8
    • +2
    /sources/view/VNetworkModel.cpp
    • -1
    • +1
    /sources/view/VNetworkModel.h
    • -20
    • +22
    /sources/wifi/WifiInterface.cpp
    • -0
    • +5
    /sources/wifi/WifiInterface.h
10:29 am

pmontazemi  (deleted user)

Clarify comment..."...and will a response..." Not clear on what that means.

Clarify comment..."...and will a response..." Not clear on what that means.

9:27 am

pmontazemi  (deleted user)

...cannot...

...cannot...

9:26 am

pmontazemi  (deleted user)

Note...will not (instead of won't informal language)...for more than...

Note...will not (instead of won't informal language)...for more than...

9:26 am

pmontazemi  (deleted user)

...each instruction...

...each instruction...

9:26 am

pmontazemi  (deleted user)

...instruction-based...

...instruction-based...

9:25 am

pmontazemi  (deleted user)

...that has...for each instruction-based...

...that has...for each instruction-based...

9:25 am

pmontazemi  (deleted user)

, the application

, the application

9:25 am

pmontazemi  (deleted user)

When...VM, (comma after VM)...the application

When...VM, (comma after VM)...the application

9:24 am

pmontazemi  (deleted user)

This...required...application...instruction-based.

This...required...application...instruction-based.

9:24 am

pmontazemi  (deleted user)

It..., for application...

It..., for application...

12:14 am

Behrouz NematiPour

DEN-7147: Fixed a bug on arterial/venous pressures

- which was causing user to move low/high other than current default to be able to confirm for FW validation.

Options
    • -3
    • +3
    /denali.pro.user
    • -0
    • +2
    /sources/gui/qml/components/RangeSlider.qml
    • -4
    • +8
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
Wednesday 31 Mar 2021
6:03 pm

Behrouz NematiPour

DEN-7147: Fixed a bug on Sub-StepIndicator on bottom of the instructions

- Which was causing that to not to show correct number of the steps and titles.

- removed #include "MModel.h" in all the possible cases and include the specific model since the MModel has too much include.

- Showing the Heparin setup in the CART_INSTALL state only if we have a heparin volume setup.

- created a common template function name enumString in Gui namespace to get the enum name as string.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +3
    /en_US.udic
    • -8
    • +15
    /sources/ApplicationController.cpp
    • -6
    • +1
    /sources/ApplicationController.h
    • -1
    • +0
    /sources/gui/GuiGlobals.cpp
    • -0
    • +26
    /sources/gui/GuiGlobals.h
    • -4
    • +11
    /sources/gui/qml/components/StepIndicator.qml
    • -1
    • +1
    /sources/gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -2
    • +18
    /sources/gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -5
    • +5
    /sources/main.h
    • -0
    • +5
    /sources/model/MModel.h
    • -0
    • +2
    /sources/model/settings/MSettings.h
    • -1
    • +0
    /sources/storage/Settings.cpp
    • -1
    • +1
    /sources/view/VPowerOff.h
    • -7
    • +1
    /sources/view/VTreatmentCreate.cpp
  16. … 58 more files in changeset.
Tuesday 30 Mar 2021
5:00 pm

Behrouz NematiPour

DEN-7147: preTx: Code Review 0

- The little count down progress circles become bigger.

- The completed text on the bottom of some screens with check marks become settable by code.

- Duplicate group removed from instruction file

- "Recirculate ..." text has been removed from the priming screen

- Added syringe pump state

Options
    • -1
    • +1
    /denali.pro.user
    • -5
    • +0
    /resources/settings/instructions/instructions.conf
    • -1
    • +2
    /sources/gui/qml/compounds/CheckListView.qml
    • -1
    • +1
    /sources/gui/qml/globals/Fonts.qml
    • -1
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -4
    • +8
    /sources/gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -0
    • +1
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -10
    • +15
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
    • -0
    • +1
    /sources/view/hd/data/VPreTreatmentStatesData.cpp
    • -0
    • +1
    /sources/view/hd/data/VPreTreatmentStatesData.h
    • -6
    • +11
    /sources/view/settings/VSettings.cpp
Monday 29 Mar 2021
12:17 pm

Behrouz NematiPour

DEN-7137: preTx: Update Design Documents

- Filled all the screen with the dynamic instruction so be able to capture for SDD.

- Removed the idea of reset and clear the stack, since it is not working.

Options
    • -8
    • +54
    /resources/settings/instructions/instructions.conf
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
10:40 am

Behrouz NematiPour

UI-DEN-7135_UI Pre Treatment
UI-DEN-7135_UI Pre Treatment
10:25 am

Behrouz NematiPour

Why Network being registered?

Why Network being registered?

9:35 am

Behrouz NematiPour

Please take a closer look at the code. At this moment you are still in the main thread and not in the Wifi Thread.

Please take a closer look at the code.
At this moment you are still in the main thread and not in the Wifi Thread.

9:31 am

Behrouz NematiPour

This is an exception that you have a view which you don't have access to its object but in general: whoever wants to use it to connect to a signal of another class should connect to that signal in ...

This is an exception that you have a view which you don't have access to its object but in general:
whoever wants to use it to connect to a signal of another class should connect to that signal in its own scop/class and do it with its private slots.
So in a case like this, these connections should be moved to the interface.
But as I said it is an exception and there no better way than what has been done here.