application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 07 Apr 2021
4:15 pm

Behrouz NematiPour

DEN-7147: Code Review 0

- DEN-7823: Meetings & Support - General Purpose - Kushen Pre-Treatment Images.

Options
    • -1
    • +1
    /denali.pro.user
    • -27
    • +29
    /resources/settings/instructions/instructions.conf
    • binary
    /resources/settings/instructions/slide1_filter_v2.png
    • binary
    /resources/settings/instructions/slide1_filter_v2b.png
    • binary
    /resources/settings/instructions/slide2_filter-connect_v1.png
    • -1
    • +5
    /sources/gui/qml/compounds/InstructionView.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -4
    • +4
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
9:52 am

plucia  (deleted user)

RESOLVED

RESOLVED

9:50 am

plucia  (deleted user)

Thanks. Are we going to need to review your merge commits as well?

Thanks. Are we going to need to review your merge commits as well?

9:40 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:35 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Tuesday 06 Apr 2021
1:34 pm

Behrouz NematiPour

it is an alias name for ISO/IEC_8859-1 character encoding standard. https://en.wikipedia.org/wiki/ISO/IEC_8859-1

it is an alias name for ISO/IEC_8859-1 character encoding standard.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1

7:17 am

pmontazemi  (deleted user)

Why Latin1 and not Latin? Are there two or more Latins?

Why Latin1 and not Latin? Are there two or more Latins?

Monday 05 Apr 2021
1:27 pm

Peter Lucia <plucia@diality.com>

DEN-7521: Ensure static IP assignments display after reboot

Options
    • -0
    • +12
    /sources/wifi/WifiInterface.cpp
10:24 am

plucia  (deleted user)

Will '[' and ']' always be on the same line?

Will '[' and ']' always be on the same line?

10:22 am

plucia  (deleted user)

Can this be deleted?

Can this be deleted?

10:20 am

plucia  (deleted user)

Don't think prepend("/") is needed here since according to https://doc.qt.io/qt-5/qfileinfo.html#absolutePath, "On Unix the absolute path will always begin with the root, '/', directory."

Don't think prepend("/") is needed here since according to https://doc.qt.io/qt-5/qfileinfo.html#absolutePath, "On Unix the absolute path will always begin with the root, '/', directory."

10:16 am

plucia  (deleted user)

If '=' is the last character or first character in the line this won't work

If '=' is the last character or first character in the line this won't work

10:13 am

plucia  (deleted user)

This function only returns 0 so it can be void

This function only returns 0 so it can be void

10:13 am

plucia  (deleted user)

Is there protection in case the file is being written to while you are trying to read it? Doesn't QSettings do all of this for us already?

Is there protection in case the file is being written to while you are trying to read it? Doesn't QSettings do all of this for us already?

10:10 am

plucia  (deleted user)

Is this needed or can it be deleted?

Is this needed or can it be deleted?

10:07 am

plucia  (deleted user)

I see, could you update the comment to say "other than only just logging" so it's clearer? I was totally confused by it

I see, could you update the comment to say "other than only just logging" so it's clearer? I was totally confused by it

10:04 am

Behrouz NematiPour

These are test files for now. Later when we have a real file designed these will be replaced with some real names.

These are test files for now.
Later when we have a real file designed these will be replaced with some real names.

10:03 am

plucia  (deleted user)

Is this class really needed? QSettings is already thread-safe. What does this class do that QSettings doesn't already do?

Is this class really needed? QSettings is already thread-safe. What does this class do that QSettings doesn't already do?

10:01 am

plucia  (deleted user)

Docstrings are missing in this class

Docstrings are missing in this class

10:01 am

plucia  (deleted user)

vGroup is being used so I think you can remove Q_UNUSED

vGroup is being used so I think you can remove Q_UNUSED

10:00 am

Behrouz NematiPour

Thanks for reminding me that, Yes I saw that. I Will taking care of it.

Thanks for reminding me that, Yes I saw that.
I Will taking care of it.

9:58 am

Behrouz NematiPour

I was trying to say the sorting may require to change later because the birthTime is not returning a valid date. And maybe sorting on the name which always returns a valid value is better. Also has...

I was trying to say the sorting may require to change later because the birthTime is not returning a valid date.
And maybe sorting on the name which always returns a valid value is better.
Also has a note that if it is going to change, be careful that it is going to use for different purposes other than only logging.

9:57 am

plucia  (deleted user)

I added these already to staging, but they are named BUILD_FOR_DESKTOP and BUILD_FOR_TARGET. So when you merge staging to your branch or vice versa be sure to rename all of mine or make sure all of...

I added these already to staging, but they are named BUILD_FOR_DESKTOP and BUILD_FOR_TARGET. So when you merge staging to your branch or vice versa be sure to rename all of mine or make sure all of them are named the same since there's no need for duplicates. Also, are we still going to review merges as I don't think there is a merge commit yet from staging to this branch in this code review.

9:47 am

plucia  (deleted user)

RESOLVED

RESOLVED

9:41 am

plucia  (deleted user)

Not sure I follow the comment you added here, can you clarify?

Not sure I follow the comment you added here, can you clarify?

9:28 am

plucia  (deleted user)

This image filename could be more descriptive. Will it have to be renamed if the order is changed?

This image filename could be more descriptive. Will it have to be renamed if the order is changed?

Friday 02 Apr 2021
2:38 am

Behrouz NematiPour

DEN-7832: Implementations [Saline and Heparin change request]

- Reverted back the ultrafiltration state removal. The UF requires the state in the response message since we don't have any specific ultrafiltration adjustment state message .

Options
    • -0
    • +4
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp
    • -0
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h
    • -0
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationState.cpp
    • -0
    • +8
    /sources/view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationState.h
    • -1
    • +33
    /sources/view/hd/data/VHDTreatmentStatesData.cpp
    • -1
    • +5
    /sources/view/hd/data/VHDTreatmentStatesData.h
Thursday 01 Apr 2021
8:53 pm

Behrouz NematiPour

It's working on the Sprint37 branch of the Common. FW hasn't updated on the master yet.

It's working on the Sprint37 branch of the Common.
FW hasn't updated on the master yet.

8:49 pm

Behrouz NematiPour

DEN-7832 Implementations [Saline and Heparin change request]

- updated the messages length

- disabled used on heparin complete state to resume the heparin

- fixed the issue caused the entire section stay touchable and send the request on saline and heparin.

- updated the wording of the heparin state messages.

- added a define to disable the UI Check-In

Options
    • -2
    • +2
    /denali.pro.user
    • -0
    • +2
    /sources/MainTimer.cpp
    • -0
    • +8
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +3
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -18
    • +21
    /sources/gui/qml/pages/treatment/sections/TreatmentHeparin.qml
    • -5
    • +6
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -0
    • +2
    /sources/storage/Logger.h
5:08 pm

plucia  (deleted user)

When I tried to test out your branch, I got a compilation error saying that DRY_SELF_TESTS_SYRINGE_PUMP_PRIME_STATE doesn't currently exist in HDDefs.h. My common has the latest changes

When I tried to test out your branch, I got a compilation error saying that DRY_SELF_TESTS_SYRINGE_PUMP_PRIME_STATE doesn't currently exist in HDDefs.h. My common has the latest changes