application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7147: preTx: Code Review 0

    • -1
    • +36
    /sources/model/settings/MSettings.cpp
If needed, sure. Every commit has to be reviewed otherwise the bamboo scripts will not let the build happen.

If needed, sure.
Every commit has to be reviewed otherwise the bamboo scripts will not let the build happen.

Yes, it has to be on the same line to be the group.

Yes, it has to be on the same line to be the group.

You are half right. The intention is not to force to have always a key or a value since the use case might be different in various situations. But a good catch that in our specific case if the valu...

You are half right.
The intention is not to force to have always a key or a value since the use case might be different in various situations.
But a good catch that in our specific case if the value(image) is empty qml was complaining about not finding the image which fixed in:
InstructionView.qml:~97

I'm not sure that QSettings does that for us. But the design, for now, is that the settings are for reading only at boot up and no to write. Later when we decided to have it save the settings will ...

I'm not sure that QSettings does that for us.
But the design, for now, is that the settings are for reading only at boot up and no to write.
Later when we decided to have it save the settings will do the rest for the write/read protection.

I was hoping the same but in our setting, the order is so important but QSettings doesn't guaranty the reading order and will reorder the read key, value pairs. So I had to implement our own reader...

I was hoping the same but in our setting, the order is so important but QSettings doesn't guaranty the reading order and will reorder the read key, value pairs.
So I had to implement our own reader.
For the groups, it doesn't matter much but for the key, values which are going to be the instruction pair of title, image the order is so important.
please don't confuse that the designated key and values are always correct but the lines are not in correct order.

DEN-7823: Meetings & Support - General purpose

- Added Alarm No Minimize so user can't minimize some alarms regarding the Alarm message received.

- Spell & doc correct

- Used MSG26 (Tx ranges) for the ultrafiltration pre-treatment max value.

- Fixed the Dynamic Instructions location on the device.

    • -1
    • +1
    /sources/gui/qml/components/TimeCircle.qml
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -13
    • +13
    /sources/view/hd/data/VPreTreatmentStatesData.cpp
Done

Done

DEN-7054: Addressed code review comments

Addressed - ready for review

Addressed - ready for review

DEN-7054: Addressed code review comments

    • -108
    • +106
    /sources/model/MWifiNetwork.h
RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Please move it to line 139

Please move it to line 139

Thanks for doing this. But that is not what I meant. Struct Data should only have basic data types which require to be sending between threads. What is implemented here is an immediate struct defin...

Thanks for doing this.
But that is not what I meant.
Struct Data should only have basic data types which require to be sending between threads.
What is implemented here is an immediate struct definition in a class which will be passed and is literally the same as a class and has the only overhead of a struct defined in the class.
Please use Data as the data and remove the functions from the struct Data.
I think the concept of having the struct Data is not clarified, let me know if I need to explain mor.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

DEN-7147: Code Review 0

- DEN-7823: Meetings & Support - General Purpose - Kushen Pre-Treatment Images.

    • binary
    /resources/settings/instructions/slide1_filter_v2.png
    • binary
    /resources/settings/instructions/slide1_filter_v2b.png
RESOLVED

RESOLVED

Thanks. Are we going to need to review your merge commits as well?

Thanks. Are we going to need to review your merge commits as well?

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

it is an alias name for ISO/IEC_8859-1 character encoding standard. https://en.wikipedia.org/wiki/ISO/IEC_8859-1

it is an alias name for ISO/IEC_8859-1 character encoding standard.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1

Why Latin1 and not Latin? Are there two or more Latins?

Why Latin1 and not Latin? Are there two or more Latins?

DEN-7521: Ensure static IP assignments display after reboot

Will '[' and ']' always be on the same line?

Will '[' and ']' always be on the same line?

Can this be deleted?

Can this be deleted?