application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Apr 2021
10:12 pm

Behrouz NematiPour

DEN-7147: preTx: Code Review 0

Options
    • -9
    • +9
    /resources/settings/instructions/readme.md
    • -4
    • +4
    /sources/gui/GuiGlobals.h
    • -3
    • +3
    /sources/gui/qml/compounds/InstructionView.qml
    • -1
    • +36
    /sources/model/settings/MSettings.cpp
    • -1
    • +1
    /sources/storage/FileHandler.cpp
    • -14
    • +1
    /sources/storage/Settings.cpp
    • -1
    • +0
    /sources/storage/Settings.h
10:10 pm

Behrouz NematiPour

If needed, sure. Every commit has to be reviewed otherwise the bamboo scripts will not let the build happen.

If needed, sure.
Every commit has to be reviewed otherwise the bamboo scripts will not let the build happen.

10:08 pm

Behrouz NematiPour

Yes, it has to be on the same line to be the group.

Yes, it has to be on the same line to be the group.

10:07 pm

Behrouz NematiPour

You are half right. The intention is not to force to have always a key or a value since the use case might be different in various situations. But a good catch that in our specific case if the valu...

You are half right.
The intention is not to force to have always a key or a value since the use case might be different in various situations.
But a good catch that in our specific case if the value(image) is empty qml was complaining about not finding the image which fixed in:
InstructionView.qml:~97

9:33 pm

Behrouz NematiPour

I'm not sure that QSettings does that for us. But the design, for now, is that the settings are for reading only at boot up and no to write. Later when we decided to have it save the settings will ...

I'm not sure that QSettings does that for us.
But the design, for now, is that the settings are for reading only at boot up and no to write.
Later when we decided to have it save the settings will do the rest for the write/read protection.

9:29 pm

Behrouz NematiPour

I was hoping the same but in our setting, the order is so important but QSettings doesn't guaranty the reading order and will reorder the read key, value pairs. So I had to implement our own reader...

I was hoping the same but in our setting, the order is so important but QSettings doesn't guaranty the reading order and will reorder the read key, value pairs.
So I had to implement our own reader.
For the groups, it doesn't matter much but for the key, values which are going to be the instruction pair of title, image the order is so important.
please don't confuse that the designated key and values are always correct but the lines are not in correct order.

8:10 pm

Behrouz NematiPour

DEN-7823: Meetings & Support - General purpose

- Added Alarm No Minimize so user can't minimize some alarms regarding the Alarm message received.

- Spell & doc correct

- Used MSG26 (Tx ranges) for the ultrafiltration pre-treatment max value.

- Fixed the Dynamic Instructions location on the device.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /sources/gui/qml/AlarmItem.qml
    • -1
    • +1
    /sources/gui/qml/components/TimeCircle.qml
    • -2
    • +2
    /sources/gui/qml/compounds/InstructionView.qml
    • -0
    • +3
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -1
    • +1
    /sources/gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -1
    • +1
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -1
    • +1
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentUltrafiltration.qml
    • -1
    • +1
    /sources/storage/StorageGlobals.cpp
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.h
    • -2
    • +2
    /sources/view/hd/data/VPreTreatmentSelfTestNoCartridgeData.h
    • -13
    • +13
    /sources/view/hd/data/VPreTreatmentStatesData.cpp
    • -3
    • +3
    /sources/view/hd/data/VPreTreatmentStatesData.h
Thursday 08 Apr 2021
5:49 pm

plucia  (deleted user)

Done

Done

5:49 pm

Peter Lucia <plucia@diality.com>

DEN-7054: Addressed code review comments

Options
    • -1
    • +1
    /denali.pro
5:47 pm

plucia  (deleted user)

Addressed - ready for review

Addressed - ready for review

5:43 pm

Peter Lucia <plucia@diality.com>

DEN-7054: Addressed code review comments

Options
    • -108
    • +106
    /sources/model/MWifiNetwork.h
    • -1
    • +1
    /sources/view/VNetworkModel.cpp
    • -21
    • +21
    /sources/wifi/WifiInterface.cpp
    • -2
    • +4
    /sources/wifi/WifiInterface.h
Wednesday 07 Apr 2021
4:37 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:36 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:32 pm

Behrouz NematiPour

Please move it to line 139

Please move it to line 139

4:30 pm

Behrouz NematiPour

Thanks for doing this. But that is not what I meant. Struct Data should only have basic data types which require to be sending between threads. What is implemented here is an immediate struct defin...

Thanks for doing this.
But that is not what I meant.
Struct Data should only have basic data types which require to be sending between threads.
What is implemented here is an immediate struct definition in a class which will be passed and is literally the same as a class and has the only overhead of a struct defined in the class.
Please use Data as the data and remove the functions from the struct Data.
I think the concept of having the struct Data is not clarified, let me know if I need to explain mor.

4:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:20 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:19 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:15 pm

Behrouz NematiPour

DEN-7147: Code Review 0

- DEN-7823: Meetings & Support - General Purpose - Kushen Pre-Treatment Images.

Options
    • -1
    • +1
    /denali.pro.user
    • -27
    • +29
    /resources/settings/instructions/instructions.conf
    • binary
    /resources/settings/instructions/slide1_filter_v2.png
    • binary
    /resources/settings/instructions/slide1_filter_v2b.png
    • binary
    /resources/settings/instructions/slide2_filter-connect_v1.png
    • -1
    • +5
    /sources/gui/qml/compounds/InstructionView.qml
    • -2
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -4
    • +4
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
9:52 am

plucia  (deleted user)

RESOLVED

RESOLVED

9:50 am

plucia  (deleted user)

Thanks. Are we going to need to review your merge commits as well?

Thanks. Are we going to need to review your merge commits as well?

9:40 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:35 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Tuesday 06 Apr 2021
1:34 pm

Behrouz NematiPour

it is an alias name for ISO/IEC_8859-1 character encoding standard. https://en.wikipedia.org/wiki/ISO/IEC_8859-1

it is an alias name for ISO/IEC_8859-1 character encoding standard.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1

7:17 am

pmontazemi  (deleted user)

Why Latin1 and not Latin? Are there two or more Latins?

Why Latin1 and not Latin? Are there two or more Latins?

Monday 05 Apr 2021
1:27 pm

Peter Lucia <plucia@diality.com>

DEN-7521: Ensure static IP assignments display after reboot

Options
    • -0
    • +12
    /sources/wifi/WifiInterface.cpp
10:24 am

plucia  (deleted user)

Will '[' and ']' always be on the same line?

Will '[' and ']' always be on the same line?

10:22 am

plucia  (deleted user)

Can this be deleted?

Can this be deleted?