application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Apr 2021
2:38 pm

Behrouz NematiPour

DEN-8303 Meeting & Support - General Purpose

- Adding two other Alarms parameters to the log

- Fixed the ProgressCircle component circle color.

- Adding a simple detail screen for the Treatment Log Review screen

- Popping up the keyboard when get into the Date/Time screen.

-

Options
    • -22
    • +21
    /cppcheck.err
    • -187
    • +408
    /cppcheck.log
    • -2
    • +2
    /denali.pro.user
    • -0
    • +2
    /sources/gui/GuiGlobals.h
    • -1
    • +1
    /sources/gui/qml/components/ProgressCircle.qml
    • -0
    • +4
    /sources/gui/qml/pages/posttreatment/PostTreatmentReview.qml
    • -0
    • +10
    /sources/gui/qml/pages/posttreatment/PostTreatmentStack.qml
    • -0
    • +5
    /sources/gui/qml/pages/settings/SettingsDateTime.qml
    • -1
    • +2
    /sources/gui/qml/pages/settings/SettingsStack.qml
    • -7
    • +139
    /sources/model/hd/alarm/MAlarmTriggered.cpp
    • -2
    • +28
    /sources/model/hd/alarm/MAlarmTriggered.h
11:37 am

Behrouz NematiPour

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used. So it would be better to have key or value as QStringList properties and change these prop...

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used.
So it would be better to have key or value as QStringList properties and change these properties to just values.

11:34 am

Behrouz NematiPour

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

11:32 am

Behrouz NematiPour

please put tr() for translation.

please put tr() for translation.

11:32 am

Behrouz NematiPour

please put tr() for translation.

please put tr() for translation.

11:24 am

Behrouz NematiPour

The one which has been used in the VDateTime is much cleaner: if (_process.state() == QProcess::Running) { return; }

The one which has been used in the VDateTime is much cleaner:

if (_process.state() == QProcess::Running) {
    return;
}
11:18 am

Behrouz NematiPour

please move it in an appropriate folder(hd/adjustment)

please move it in an appropriate folder(hd/adjustment)

11:17 am

Behrouz NematiPour

please move it in an appropriate folder(dg/adjustment)

please move it in an appropriate folder(dg/adjustment)

11:11 am

Behrouz NematiPour

Where it is used?

Where it is used?

11:09 am

Behrouz NematiPour

please change this to eDG.

please change this to eDG.

11:07 am

Behrouz NematiPour

Please use 'fontPixel' prefix for your font's pixelSize variables to distinguish between the different properties of the font.

Please use 'fontPixel' prefix for your font's pixelSize variables to distinguish between the different properties of the font.

10:56 am

Behrouz NematiPour

Please don't use "%0" as we discussed.

Please don't use "%0" as we discussed.

10:54 am

Behrouz NematiPour

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

10:51 am

Behrouz NematiPour

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

10:48 am

Behrouz NematiPour

Was there a reason the tee command is being used, instead of simply using > like : echo "$1" > /sys/class/backlight/backlight-mipi/brightness ?

Was there a reason the tee command is being used, instead of simply using > like :

echo "$1" > /sys/class/backlight/backlight-mipi/brightness

?

10:30 am

Behrouz NematiPour

What is this line used for?

What is this line used for?

10:24 am

Behrouz NematiPour

Interesting. Why it is a broadcast instead of a request/response? Why does UI need a broadcast message while it will always be adjusted by UI?

Interesting.
Why it is a broadcast instead of a request/response?
Why does UI need a broadcast message while it will always be adjusted by UI?

10:18 am

plucia  (deleted user)

It prevents updates to alarmVolume by the HD broadcast while we're editing the alarm volume. Otherwise, alarmVolume could be incorrectly updated by an HD broadcast of a set alarm volume that the us...

It prevents updates to alarmVolume by the HD broadcast while we're editing the alarm volume.
Otherwise, alarmVolume could be incorrectly updated by an HD broadcast of a set alarm volume that the user decided to cancel.

10:08 am

plucia  (deleted user)

alarmVolumeTemp is the temporary volume being selected by the user while they are adjusting. alarmVolume is the kept alarm volume when the user exits the alarm volume screen. alarmVolume is set to ...

alarmVolumeTemp is the temporary volume being selected by the user while they are adjusting.
alarmVolume is the kept alarm volume when the user exits the alarm volume screen.
alarmVolume is set to alarmVolumeTemp only if the user hits confirm
Upon confirm, alarmVolume is updated to be the same value as alarmVolumeTemp and is then sent down to the HD.
Upon back / cancel, alarmVolume is left unchanged and is sent down to the HD to undo the temporary setting
FW does not expose a play alarm volume without set message so we have to set the volume each time it is played for the user while they are adjusting.

9:56 am

Behrouz NematiPour

What is Temp mean, if it means default please put def, and if it is the step please put Step. Or if it is the previous value you kept for back to be sent back to HD, Please use prev/previous.

What is Temp mean, if it means default please put def, and if it is the step please put Step.
Or if it is the previous value you kept for back to be sent back to HD, Please use prev/previous.

9:53 am

Behrouz NematiPour

Could you please explain why do you need this flag?

Could you please explain why do you need this flag?

9:50 am

Behrouz NematiPour

Please modify the signal's name so it always has the Clicked/Pressed/... at the end. Please apply for every other occurance.

Please modify the signal's name so it always has the Clicked/Pressed/... at the end.
Please apply for every other occurance.

9:44 am

Behrouz NematiPour

Wednesday 28 Apr 2021
4:27 pm

plucia  (deleted user)

UI-DEN-7752_Device Information
UI-DEN-7752_Device Information
4:25 pm

plucia  (deleted user)

UI-DEN-8085_Alarm Volume Brightness
UI-DEN-8085_Alarm Volume Brightness
1:10 pm

Peter Lucia <plucia@diality.com>

DEN-8081: Added missing message length, updated needs ack table.

Options
    • -0
    • +1
    /sources/canbus/MessageDispatcher.h
    • -0
    • +1
    /sources/canbus/MessageGlobals.h
10:36 am

Peter Lucia <plucia@diality.com>

Merge DEN-7752_Device_Information into DEN-8058_Alarm_Volume_Brightness

Options
    • -0
    • +4
    /denali.pro
    • -0
    • +13
    /sources/canbus/MessageDispatcher.cpp
    • -2
    • +5
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +3
    /sources/gui/GuiGlobals.h
    • -1
    • +5
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +15
    /sources/model/MModel.h
    • -0
    • +30
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
10:28 am

Peter Lucia <plucia@diality.com>

DEN-8083: Added HD and DG last and next service dates

Options
    • -0
    • +4
    /denali.pro
    • -0
    • +13
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +3
    /sources/canbus/MessageGlobals.h
    • -2
    • +5
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +3
    /sources/gui/GuiGlobals.h
    • -2
    • +2
    /sources/gui/qml/pages/SettingsDeviceInformation.qml
    • -1
    • +5
    /sources/gui/qml/pages/SettingsHome.qml
    • -2
    • +17
    /sources/model/MModel.h
    • -0
    • +31
    /sources/model/dg/adjustment/MAdjustDGServiceResponse.cpp
    • -0
    • +68
    /sources/model/dg/adjustment/MAdjustDGServiceResponse.h
    • -0
    • +31
    /sources/model/hd/adjustment/MAdjustHDServiceResponse.cpp
    • -0
    • +68
    /sources/model/hd/adjustment/MAdjustHDServiceResponse.h
    • -0
    • +30
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +3
    /sources/view/VDateTime.cpp
    • -6
    • +47
    /sources/view/VDeviceInformation.cpp
  16. … 3 more files in changeset.
9:05 am

Peter Lucia <plucia@diality.com>

DEN-8062, DEN-8081: Alarm volume improvements

Options
    • -1
    • +1
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/gui/GuiGlobals.h
    • -15
    • +9
    /sources/gui/qml/pages/SettingsAlarmVolume.qml
    • -2
    • +2
    /sources/gui/qml/pages/SettingsHome.qml
    • -4
    • +4
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -9
    • +31
    /sources/view/VAlarmVolume.cpp
    • -2
    • +4
    /sources/view/VAlarmVolume.h
Tuesday 27 Apr 2021
1:11 pm

Peter Lucia <plucia@diality.com>

DEN-D8062, DEN-8081, DEN-8082: Added alarm volume and brightness

Options
    • -1
    • +7
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /denali.qrc
    • -0
    • +10
    /scripts/brightness_set.sh
    • -0
    • +3
    /scripts/setup.sh
    • -0
    • +13
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +1
    /sources/canbus/MessageDispatcher.h
    • -0
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +2
    /sources/gui/GuiGlobals.cpp
    • -0
    • +2
    /sources/gui/GuiGlobals.h
    • -1
    • +1
    /sources/gui/qml/components/pretreatment/SliderCreateTreatment.qml
    • -0
    • +4
    /sources/gui/qml/main.qml
    • -0
    • +127
    /sources/gui/qml/pages/SettingsAlarmVolume.qml
    • -0
    • +125
    /sources/gui/qml/pages/SettingsBrightness.qml
    • -1
    • +26
    /sources/gui/qml/pages/SettingsHome.qml
  16. … 11 more files in changeset.