Activity application/

I think VDateTime.h is less safe in this case. It should be updated to match if (_process.state() != QProcess::NotRunning) { return; } to prevent re-starting the process when its already in the "S...

I think VDateTime.h is less safe in this case. It should be updated to match

if (_process.state() != QProcess::NotRunning) { return; }

to prevent re-starting the process when its already in the "Starting" state as well as the "Running" state.

    enum ProcessState {
        NotRunning,
        Starting,
        Running
    };

12:51 pm

plucia (deleted user)

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

12:51 pm

plucia (deleted user)

More
Re: UI-DEN-8085-1
replied to plucia (deleted user)

AlarmVolumeTemp has been removed

12:51 pm

plucia (deleted user)

It is removed now

12:50 pm

plucia (deleted user)

Done

12:50 pm

Peter Lucia <plucia@diality.com>

More
62d4bbe
changed 18 files
DEN-8058_Alarm_Volume_Brightness UI-DEN-8085-1 UI-DEN-8058-1

DEN-8064: Addressed code review comments

- -0
- +2
/denali.pro
- History
- Source
- Diff
/denali.pro
- -0
- +1
/sources/canbus/MessageGlobals.h
- History
- Source
- Diff
/sources/canbus/MessageGlobals.h
- -0
- +1
/sources/canbus/MessageInterpreter.cpp
- History
- Source
- Diff
/sources/canbus/MessageInterpreter.cpp
- -0
- +1
/sources/gui/GuiGlobals.h
- History
- Source
- Diff
/sources/gui/GuiGlobals.h
- -16
- +16
/sources/gui/qml/pages/SettingsAlarmVolume.qml
- History
- Source
- Diff
/sources/gui/.../SettingsAlarmVolume.qml
- -2
- +2
/sources/gui/qml/pages/SettingsBluetooth.qml
- History
- Source
- Diff
/sources/gui/.../pages/SettingsBluetooth.qml
- -4
- +4
/sources/gui/qml/pages/SettingsBrightness.qml
- History
- Source
- Diff
/sources/gui/.../pages/SettingsBrightness.qml
- -2
- +2
/sources/gui/qml/pages/SettingsDateTimeSet.qml
- History
- Source
- Diff
/sources/gui/.../SettingsDateTimeSet.qml
- -2
- +2
/sources/gui/qml/pages/SettingsDeviceInformation.qml
- History
- Source
- Diff
/sources/.../SettingsDeviceInformation.qml
- -8
- +7
/sources/gui/qml/pages/SettingsHome.qml
- History
- Source
- Diff
/sources/gui/qml/pages/SettingsHome.qml
- -2
- +2
/sources/gui/qml/pages/SettingsWifi.qml
- History
- Source
- Diff
/sources/gui/qml/pages/SettingsWifi.qml
- -0
- +5
/sources/model/MModel.h
- History
- Source
- Diff
/sources/model/MModel.h
- -0
- +45
/sources/model/hd/adjustment/MAdjustHDAlarmVolumeResponse.cpp
- History
- Source
/sources/.../MAdjustHDAlarmVolumeResponse.cpp
- -0
- +82
/sources/model/hd/adjustment/MAdjustHDAlarmVolumeResponse.h
- History
- Source
/sources/model/.../MAdjustHDAlarmVolumeResponse.h
- -4
- +2
/sources/model/hd/adjustment/MTreatmentAdjustRequests.h
- History
- Source
- Diff
/sources/model/.../MTreatmentAdjustRequests.h
… 3 more files in changeset.

4:34 am

Behrouz NematiPour

More
64acc3d
changed 1 file
master, @Environement_Swith and 221 more UI-DEN-8308-1

Updated the Alarm List

- -2
- +4
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

4:27 am

Behrouz NematiPour

More
2216ac6
changed 54 files
master, @Environement_Swith and 221 more UI-DEN-8308-1

DEN-8316: TxLog: Implementation [Simulator/Testing]

- -2
- +5
/denali.pro
- History
- Source
- Diff
/denali.pro
- -1
- +1
/denali.pro.user
- History
- Source
- Diff
/denali.pro.user
- -0
- +8
/en_US.udic
- History
- Source
- Diff
/en_US.udic
- -0
- +14
/resources/license
- History
- Source
/resources/license
- binary
/resources/settings/Instructions/1.png
- History
- Source
/resources/settings/Instructions/1.png
- binary
/resources/settings/Instructions/2.png
- History
- Source
/resources/settings/Instructions/2.png
- binary
/resources/settings/Instructions/3.png
- History
- Source
/resources/settings/Instructions/3.png
- -0
- +8
/resources/settings/Instructions/Instructions.conf
- History
- Source
/resources/settings/.../Instructions.conf
- binary
/resources/settings/Instructions/slide1_filter_v2.png
- History
- Source
/resources/settings/.../slide1_filter_v2.png
- binary
/resources/settings/Instructions/slide1_filter_v2b.png
- History
- Source
/resources/settings/.../slide1_filter_v2b.png
- binary
/resources/settings/Instructions/slide2_filter-connect_v1.png
- History
- Source
/resources/.../slide2_filter-connect_v1.png
- -0
- +22
/resources/settings/TreatmentParameters/DataList.conf
- History
- Source
/resources/settings/.../DataList.conf
- -0
- +4
/resources/settings/TreatmentParameters/Formats.conf
- History
- Source
/resources/settings/.../Formats.conf
- binary
/resources/settings/instructions/1.png
- History
- Source
- Diff
/resources/settings/instructions/1.png
- binary
/resources/settings/instructions/2.png
- History
- Source
- Diff
/resources/settings/instructions/2.png
… 39 more files in changeset.

1:46 pm

plucia (deleted user)

More
UI-DEN-7524-2
started review

UI-DEN-7529_Service Mode

2:38 pm

Behrouz NematiPour

More
e8ffaa5
changed 11 files
master, @Environement_Swith and 221 more UI-DEN-8308-1

DEN-8303 Meeting & Support - General Purpose

- Adding two other Alarms parameters to the log

- Fixed the ProgressCircle component circle color.

- Adding a simple detail screen for the Treatment Log Review screen

- Popping up the keyboard when get into the Date/Time screen.

-

- -22
- +21
/cppcheck.err
- History
- Source
- Diff
/cppcheck.err
- -187
- +408
/cppcheck.log
- History
- Source
- Diff
/cppcheck.log
- -2
- +2
/denali.pro.user
- History
- Source
- Diff
/denali.pro.user
- -0
- +2
/sources/gui/GuiGlobals.h
- History
- Source
- Diff
/sources/gui/GuiGlobals.h
- -1
- +1
/sources/gui/qml/components/ProgressCircle.qml
- History
- Source
- Diff
/sources/gui/.../ProgressCircle.qml
- -0
- +4
/sources/gui/qml/pages/posttreatment/PostTreatmentReview.qml
- History
- Source
- Diff
/sources/gui/.../PostTreatmentReview.qml
- -0
- +10
/sources/gui/qml/pages/posttreatment/PostTreatmentStack.qml
- History
- Source
- Diff
/sources/gui/.../PostTreatmentStack.qml
- -0
- +5
/sources/gui/qml/pages/settings/SettingsDateTime.qml
- History
- Source
- Diff
/sources/gui/.../SettingsDateTime.qml
- -1
- +2
/sources/gui/qml/pages/settings/SettingsStack.qml
- History
- Source
- Diff
/sources/gui/.../settings/SettingsStack.qml
- -7
- +139
/sources/model/hd/alarm/MAlarmTriggered.cpp
- History
- Source
- Diff
/sources/model/.../alarm/MAlarmTriggered.cpp
- -2
- +28
/sources/model/hd/alarm/MAlarmTriggered.h
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmTriggered.h

11:37 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used. So it would be better to have key or value as QStringList properties and change these prop...

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used.
So it would be better to have key or value as QStringList properties and change these properties to just values.

11:34 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

11:32 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

please put tr() for translation.

11:32 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

please put tr() for translation.

11:24 am

Behrouz NematiPour

More
Re: UI-DEN-8085-1
commented on review

The one which has been used in the VDateTime is much cleaner: if (_process.state() == QProcess::Running) { return; }

The one which has been used in the VDateTime is much cleaner:

if (_process.state() == QProcess::Running) {
    return;
}

11:18 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

please move it in an appropriate folder(hd/adjustment)

11:17 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

please move it in an appropriate folder(dg/adjustment)

11:11 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

Where it is used?

11:09 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

please change this to eDG.

11:07 am

Behrouz NematiPour

More
Re: UI-DEN-7752-1
commented on review

Please use 'fontPixel' prefix for your font's pixelSize variables to distinguish between the different properties of the font.

10:56 am

Behrouz NematiPour

More
Re: UI-DEN-8085-1
commented on review

Please don't use "%0" as we discussed.

10:54 am

Behrouz NematiPour

More
Re: UI-DEN-8085-1
commented on review

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

10:51 am

Behrouz NematiPour

More
Re: UI-DEN-8085-1
commented on review

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

application

Stats

Commits this week: 6

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Peter Lucia <plucia@diality.com>

plucia (deleted user)

Peter Lucia <plucia@diality.com>

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

Peter Lucia <plucia@diality.com>

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

plucia (deleted user)

Peter Lucia <plucia@diality.com>

Behrouz NematiPour

Behrouz NematiPour

plucia (deleted user)

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour