application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8316: TxLog: Implementation [Simulator/Testing]

    • binary
    /resources/settings/Instructions/water sampling_v1.png
Now updated to just variables since they are not used in qml

Now updated to just variables since they are not used in qml

The m is now removed and replaced with underscores to indicate that they are private.

The m is now removed and replaced with underscores to indicate that they are private.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

DEN-7756: Addressed code review comments

    • -22
    • +0
    /sources/model/MDGSerialNumberResponse.cpp
    • -64
    • +0
    /sources/model/MDGSerialNumberResponse.h
    • -21
    • +0
    /sources/model/MHDSerialNumberResponse.cpp
    • -64
    • +0
    /sources/model/MHDSerialNumberResponse.h
    • -0
    • +22
    /sources/model/dg/adjustment/MDGSerialNumberResponse.cpp
    • -0
    • +64
    /sources/model/dg/adjustment/MDGSerialNumberResponse.h
    • -0
    • +21
    /sources/model/hd/adjustment/MHDSerialNumberResponse.cpp
    • -0
    • +64
    /sources/model/hd/adjustment/MHDSerialNumberResponse.h
    • -37
    • +37
    /sources/view/VDeviceInformation.cpp
    • -14
    • +12
    /sources/view/VDeviceInformation.h
This is used in INTERPRET_RECVD_MT_MESSAGE in MessageInterpreter.cpp. It is overridden so a broadcast is sent out instead of a direct message to the HD.

This is used in INTERPRET_RECVD_MT_MESSAGE in MessageInterpreter.cpp.
It is overridden so a broadcast is sent out instead of a direct message to the HD.

DEN-8064: Addressed code review comments

Done

Done

DEN-8064: Addressed code review comments

    • -39
    • +0
    /sources/model/hd/data/MAlarmVolumeData.cpp
    • -74
    • +0
    /sources/model/hd/data/MAlarmVolumeData.h
Fixed

Fixed

Done

Done

That works too. No need for tee here. I've updated it

That works too. No need for tee here. I've updated it

DEN-8064: Addressed code review comments

I think VDateTime.h is less safe in this case. It should be updated to match if (_process.state() != QProcess::NotRunning) { return; } to prevent re-starting the process when its already in the "S...

I think VDateTime.h is less safe in this case. It should be updated to match

if (_process.state() != QProcess::NotRunning) { return; }

to prevent re-starting the process when its already in the "Starting" state as well as the "Running" state.

    enum ProcessState {
        NotRunning,
        Starting,
        Running
    }; 
I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

AlarmVolumeTemp has been removed

AlarmVolumeTemp has been removed

It is removed now

It is removed now

Done

Done

DEN-8064: Addressed code review comments

    • -0
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/SettingsBluetooth.qml
    • -4
    • +4
    /sources/gui/qml/pages/SettingsBrightness.qml
    • -8
    • +7
    /sources/gui/qml/pages/SettingsHome.qml
    • -2
    • +2
    /sources/gui/qml/pages/SettingsWifi.qml
    • -0
    • +82
    /sources/model/hd/adjustment/MAdjustHDAlarmVolumeResponse.h
  1. … 3 more files in changeset.
Updated the Alarm List

    • -2
    • +4
    /sources/model/hd/alarm/MAlarmMapping.cpp
DEN-8316: TxLog: Implementation [Simulator/Testing]

    • binary
    /resources/settings/Instructions/1.png
    • binary
    /resources/settings/Instructions/2.png
    • binary
    /resources/settings/Instructions/3.png
    • -0
    • +8
    /resources/settings/Instructions/Instructions.conf
    • binary
    /resources/settings/Instructions/slide1_filter_v2.png
    • binary
    /resources/settings/Instructions/slide1_filter_v2b.png
    • binary
    /resources/settings/instructions/1.png
    • binary
    /resources/settings/instructions/2.png
  1. … 39 more files in changeset.
UI-DEN-7529_Service Mode
UI-DEN-7529_Service Mode
DEN-8303 Meeting & Support - General Purpose

- Adding two other Alarms parameters to the log

- Fixed the ProgressCircle component circle color.

- Adding a simple detail screen for the Treatment Log Review screen

- Popping up the keyboard when get into the Date/Time screen.

-

    • -7
    • +139
    /sources/model/hd/alarm/MAlarmTriggered.cpp
    • -2
    • +28
    /sources/model/hd/alarm/MAlarmTriggered.h
As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used. So it would be better to have key or value as QStringList properties and change these prop...

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used.
So it would be better to have key or value as QStringList properties and change these properties to just values.

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.