Activity application/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	14
Last Commit:	17 Apr
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 21 Dec 2021

1:58 pm

Dara Navaei

More
da8e9b8
changed 1 file
master, @Environement_Swith and 200 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

1:41 pm

Dara Navaei

More
Re: UI-DEN-10205-1
commented on review

Do you still need this case?

Do you still need this case?

1:29 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:27 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:27 pm

Michael Garthwaite

Thanks.

Thanks.

1:08 pm

Behrouz NematiPour

That is a very good question. As much as possible we have to put the #includes in the CPP files and not the header. The #include in the header will always be imported even if you don't compile the ...

That is a very good question.
As much as possible we have to put the #includes in the CPP files and not the header.
The #include in the header will always be imported even if you don't compile the code (only CPP is compiled in c, not the header) as opposed to just including when needed to compile in CPP.
This also helps the compiler to optimize the code better and faster to compile.
you only need to put it in the header if you inherit from the class defined in the class included or you have a variable/parameter defined of that file in the header.

1:04 pm

Behrouz NematiPour

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

1:03 pm

Behrouz NematiPour

These changes have been requested by SysEngz. Let them have a look and decide if it's what they want.

These changes have been requested by SysEngz.
Let them have a look and decide if it's what they want.

11:30 am

Michael Garthwaite

RESOLVED

RESOLVED

11:20 am

Michael Garthwaite

More
Re: UI-DEN-10205-1
commented on review

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

10:26 am

Michael Garthwaite

More
Re: UI-DEN-10205-1
commented on review

This file was changed but no changes are highlighted, any idea what happened?

This file was changed but no changes are highlighted, any idea what happened?

10:16 am

Michael Garthwaite

More
Re: UI-DEN-10205-1
commented on review

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file? Edit: I understand that BluetoothInterface.h is need...

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file?

Edit: I understand that BluetoothInterface.h is needed, but what about the others?

10:11 am

Dara Navaei

More
1861a36
changed 1 file
master, @Environement_Swith and 205 more UI-DEN-10602-1

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

10:09 am

Michael Garthwaite

More
Re: UI-DEN-10205-1
commented on review

This is calling didAttributeResponse from DeviceGlobals.h, correct?

This is calling didAttributeResponse from DeviceGlobals.h, correct?

9:36 am

Michael Garthwaite

More
Re: UI-DEN-10205-1
commented on review

is $PAIRED_DEVICE_INFO an environment variable?

is $PAIRED_DEVICE_INFO an environment variable?

Saturday 18 Dec 2021

10:00 am

Dara Navaei

More
80d4d9c
changed 1 file
master, @Environement_Swith and 200 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

Friday 17 Dec 2021

6:45 pm

Behrouz NematiPour

Fixed. Thanks for your attention to the details.

Fixed.
Thanks for your attention to the details.

6:43 pm

Behrouz NematiPour

More
f7e2326
changed 1 file
master, @Environement_Swith and 205 more UI-DEN-10602-1

UI-DEN-10602: UI-DEN-10602-1

- http://dvm-linux02:8060/cru/UI-DEN-10602-1#CFR-27866

- -8
- +8
/sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml
- History
- Source
- Diff
/sources/gui/.../PreTreatmentCreateStack.qml

6:05 pm

Behrouz NematiPour

More
dac7a4e
changed 0 files
master, @Environement_Swith and 200 more

Merge branch 'DEN-10602_UI_DEV_Add_PatientID_PreTreatment' into develop

5:30 pm

Behrouz NematiPour

More
6e9e702
changed 39 files
master, @Environement_Swith and 205 more UI-DEN-10602-1

DEN-10979: Can we move Unhandled.conf file to common folder so that f/w team can make updates

The settings file have all been removed from the applicaion and moved to ui.conf repo.

- -0
- +1
/resources/settings
- History
- Source
/resources/settings
- binary
/resources/settings/Instructions/Dialysate lines to DG Y v4-01.png
- History
- Source
- Diff
/resources/.../Dialysate lines to DG Y v4-01.png
- binary
/resources/settings/Instructions/HD door open_v1.png
- History
- Source
- Diff
/resources/settings/.../HD door open_v1.png
- -80
- +0
/resources/settings/Instructions/Instructions.conf
- History
- Source
- Diff
/resources/settings/.../Instructions.conf
- binary
/resources/settings/Instructions/PBo connect_72.png
- History
- Source
- Diff
/resources/settings/.../PBo connect_72.png
- binary
/resources/settings/Instructions/Remove_patient connection temp.png
- History
- Source
- Diff
/resources/.../Remove_patient connection temp.png
- binary
/resources/settings/Instructions/Twist shunt_temp.png
- History
- Source
- Diff
/resources/settings/.../Twist shunt_temp.png
- binary
/resources/settings/Instructions/alt connect fistula_72.png
- History
- Source
- Diff
/resources/.../alt connect fistula_72.png
- binary
/resources/settings/Instructions/arterial to saline_v1.png
- History
- Source
- Diff
/resources/.../arterial to saline_v1.png
- binary
/resources/settings/Instructions/cassette clamp lock v2-01.png
- History
- Source
- Diff
/resources/.../cassette clamp lock v2-01.png
- binary
/resources/settings/Instructions/cassette clamp release v1.png
- History
- Source
- Diff
/resources/.../cassette clamp release v1.png
- binary
/resources/settings/Instructions/concentrate door open-v1.png
- History
- Source
- Diff
/resources/.../concentrate door open-v1.png
- binary
/resources/settings/Instructions/connect acid line v2-01.png
- History
- Source
- Diff
/resources/.../connect acid line v2-01.png
- binary
/resources/settings/Instructions/connect bicarb ine-v2-01.png
- History
- Source
- Diff
/resources/.../connect bicarb ine-v2-01.png
- binary
/resources/settings/Instructions/door down v2.png
- History
- Source
- Diff
/resources/settings/.../door down v2.png
… 24 more files in changeset.

4:41 pm

Dara Navaei

More
70012ac
changed 1 file
master, @Environement_Swith and 200 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

4:41 pm

Behrouz NematiPour

More
3a2f526
changed 0 files
master, @Environement_Swith and 200 more

Merge branch 'DEN-10602_UI_DEV_Add_PatientID_PreTreatment' into develop

4:40 pm

Behrouz NematiPour

More
30577e4
changed 1 file
master, @Environement_Swith and 205 more UI-DEN-10602-1

DEN-11199: No HD/DG fan info in UI log

- The first letter capital was the issue in reading the unhandled messages.

- -1
- +1
/sources/canbus/MessageInterpreter.cpp
- History
- Source
- Diff
/sources/canbus/MessageInterpreter.cpp

4:02 pm

Michael Garthwaite

More
Re: UI-DEN-10602-1
commented on review

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Thursday 16 Dec 2021

6:19 pm

Dara Navaei

More
7d20aa3
changed 1 file
master, @Environement_Swith and 200 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

6:18 pm

Behrouz NematiPour

More
7040a20
changed 0 files
master, @Environement_Swith and 200 more

Merge branch 'DEN-10602_UI_DEV_Add_PatientID_PreTreatment' into develop

6:17 pm

Behrouz NematiPour

More
c80676d
changed 2 files
master, @Environement_Swith and 205 more UI-DEN-10602-1

DEN-9278 UI: Brightness

- All the issues in this bug has been resolved.

- -1
- +1
/denali.pro.user
- History
- Source
- Diff
/denali.pro.user
- -1
- +3
/scripts/brightness_set.sh
- History
- Source
- Diff
/scripts/brightness_set.sh

Wednesday 15 Dec 2021

7:58 pm

Behrouz NematiPour

More
6377409
changed 0 files
master, @Environement_Swith and 200 more

Merge remote-tracking branch 'origin/develop' into develop

7:58 pm

Behrouz NematiPour

More
3a611e9
changed 1 file
master, @Environement_Swith and 200 more

Merge branch 'DEN-10602_UI_DEV_Add_PatientID_PreTreatment' into develop

- -0
- +7
/sources/cloudsync/CloudSyncController.cpp
- History
- Source
- Diff
/sources/.../CloudSyncController.cpp

5:56 pm

Dara Navaei

More
f967278
changed 1 file
master, @Environement_Swith and 200 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-05-06 08:14 -0700