application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Dec 2021
8:45 pm

Behrouz NematiPour

DEN-11367: OMRON name/logo from Bluetooth Settings image

- removed the Omron and intelliSence texts from the image.

Options
    • binary
    /resources/images/Omron-bp7000.png
12:57 pm

Michael Garthwaite

12:57 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

RESOLVED

RESOLVED

12:56 pm

Michael Garthwaite

Thank you!

Thank you!

11:25 am

Behrouz NematiPour

A very important concept. I refer you to the Qt connection concept for detailed information. https://doc.qt.io/qt-5/signalsandslots.html The idea is, the connect has 4 parameter 1 - Signal owner ob...

A very important concept.
I refer you to the Qt connection concept for detailed information.
https://doc.qt.io/qt-5/signalsandslots.html
The idea is, the connect has 4 parameter
1 - Signal owner object
2 - Signal member function
3 - Slot owner object
4 - Slot member function
When the signal owner is emit-ed, the slot owner will call its slot by the passed parameter from the signal function.
It is very important to use the connection concept, in opposed to the simple call, in case the signal owner and slot owner, objects, are in two different threads.
It is the Qt way of thread-safe calling.

11:11 am

Behrouz NematiPour

Ummm, Haven't ever thought about it, this is a very good point. Will look into it, since the actual friend class will not ever be available in the production code.

Ummm,
Haven't ever thought about it, this is a very good point.
Will look into it, since the actual friend class will not ever be available in the production code.

11:09 am

Behrouz NematiPour

if the parameter is not used, the name will not be specified so the compiler won't complain about the parameter not being used. Note the difference between parameters and arguments: *Function pa...

if the parameter is not used, the name will not be specified so the compiler won't complain about the parameter not being used.

Note the difference between parameters and arguments:

  • Function parameters are the names listed in the function's definition.
  • Function arguments are the real values passed to the function.
11:06 am

Behrouz NematiPour

The vScript parameter will accept the arguments which will be changed in the function, so has been defined as a reference with no const.

The vScript parameter will accept the arguments which will be changed in the function, so has been defined as a reference with no const.

10:59 am

Behrouz NematiPour

it has been fixed on the merge conflict. 748e088be863e08a1f8d12ff895c2525cd891e31

it has been fixed on the merge conflict.
748e088be863e08a1f8d12ff895c2525cd891e31

Tuesday 21 Dec 2021
2:35 pm

Dara Navaei

Why is vScript not a const?

Why is vScript not a const?

2:32 pm

Dara Navaei

Why does not this function have an argument name?

Why does not this function have an argument name?

2:21 pm

Dara Navaei

I understand that the friend classes are for dev testing, are we planning to disable them later during the release?

I understand that the friend classes are for dev testing, are we planning to disable them later during the release?

2:20 pm

Behrouz NematiPour

I would rather keep it for debugging purposes in case of error.

I would rather keep it for debugging purposes in case of error.

2:03 pm

Michael Garthwaite

1:58 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
1:41 pm

Dara Navaei

Do you still need this case?

Do you still need this case?

1:29 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:27 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:27 pm

Michael Garthwaite

Thanks.

Thanks.

1:08 pm

Behrouz NematiPour

That is a very good question. As much as possible we have to put the #includes in the CPP files and not the header. The #include in the header will always be imported even if you don't compile the ...

That is a very good question.
As much as possible we have to put the #includes in the CPP files and not the header.
The #include in the header will always be imported even if you don't compile the code (only CPP is compiled in c, not the header) as opposed to just including when needed to compile in CPP.
This also helps the compiler to optimize the code better and faster to compile.
you only need to put it in the header if you inherit from the class defined in the class included or you have a variable/parameter defined of that file in the header.

1:04 pm

Behrouz NematiPour

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

1:03 pm

Behrouz NematiPour

These changes have been requested by SysEngz. Let them have a look and decide if it's what they want.

These changes have been requested by SysEngz.
Let them have a look and decide if it's what they want.

11:30 am

Michael Garthwaite

RESOLVED

RESOLVED

11:20 am

Michael Garthwaite

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

With Off and Complete being two different properties, should we have Complete say "Off" to the user and not "Complete?"

10:26 am

Michael Garthwaite

This file was changed but no changes are highlighted, any idea what happened?

This file was changed but no changes are highlighted, any idea what happened?

10:16 am

Michael Garthwaite

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file? Edit: I understand that BluetoothInterface.h is need...

Out of curiosity, could you explain the difference between what #include go into the header file to those that are #include in the source file?

Edit: I understand that BluetoothInterface.h is needed, but what about the others?

10:11 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
10:09 am

Michael Garthwaite

This is calling didAttributeResponse from DeviceGlobals.h, correct?

This is calling didAttributeResponse from DeviceGlobals.h, correct?