Activity application/

10:26 am

Behrouz NematiPour

More
c1ceb8d
changed 4 files
master, @Environement_Swith and 114 more UI-DEN-15905-2

http://devapps.diality.us:8060/cru/UI-DEN-15905-2

- -1
- +1
/denali.qrc
- History
- Source
- Diff
/denali.qrc
- -1
- +0
/sources/gui/qml/pages/endtreatment/EndTreatmentRecirculateStack.qml
- History
- Source
- Diff
/sources/.../EndTreatmentRecirculateStack.qml
- -66
- +0
/sources/gui/qml/pages/endtreatment/rinseback/EndTreatmentRinsebaReconnect.qml
- History
- Source
- Diff
/sources/.../EndTreatmentRinsebaReconnect.qml
- -0
- +65
/sources/gui/qml/pages/endtreatment/rinseback/EndTreatmentRinsebackReconnect.qml
- History
- Source
/sources/.../EndTreatmentRinsebackReconnect.qml

10:24 am

Behrouz NematiPour

More
Re: UI-DEN-15905-2
replied to vduong (deleted user)

this will automatically get corrected when the file name is changed in the file explorer of the QtCreator.

10:22 am

Behrouz NematiPour

More
Re: UI-DEN-15905-2
replied to vduong (deleted user)

the file and the actual Class name does not necessary should be the same. to make sure these are not dependent, I use alias in the qrc. so although the name was not correct this still works.

the file and the actual Class name does not necessary should be the same.
to make sure these are not dependent, I use alias in the qrc.
so although the name was not correct this still works.

10:19 am

Behrouz NematiPour

More
Re: UI-DEN-15905-2
replied to vduong (deleted user)

Correct, that is for clarification since in each of the child(ish) classes in stack back and confirm have different meaning.

7:15 am

vduong (deleted user)

More
Re: UI-DEN-15896-1
commented on review

We should check with Behrouz, but I think we should comment out the entire item instead of just the text property because the Text item still takes up space. For this case, we didn't define a fixed...

We should check with Behrouz, but I think we should comment out the entire item instead of just the text property because the Text item still takes up space. For this case, we didn't define a fixed width, but if we did, there will be a gap.

7:06 am

vduong (deleted user)

More
Re: UI-DEN-15896-1
commented on review

Do we need to do this? The previous text binding had the "pairedAddr" in it.

5:55 pm

Dara Navaei

More
9e2c862
changed 1 file
master, @Environement_Swith and 113 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -16
- +22
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

5:54 pm

Dara Navaei

More
c39c7d4
changed 1 file
master, @Environement_Swith and 113 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

4:25 pm

Mohammed Suleiman <msuleiman@diality.com>

More
7d48439
changed 1 file
master, @Environement_Swith and 114 more UI-DEN-15896-1

DEN-15826: Bluetooth cuff state overlaps with vital timer in treatment screen

Bluetooth cuff state overlaps with Vital Timer

- -6
- +2
/sources/gui/qml/main.qml
- History
- Source
- Diff
/sources/gui/qml/main.qml

4:15 pm

Dara Navaei

More
29fbc54
changed 1 file
master, @Environement_Swith and 113 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -14
- +20
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

4:14 pm

Dara Navaei

More
c15b86e
changed 1 file
master, @Environement_Swith and 113 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

5:21 am

vduong (deleted user)

More
Re: UI-DEN-15905-2
commented on review

If the file is indeed incorrectly named, please also correct here

5:19 am

vduong (deleted user)

More
Re: UI-DEN-15905-2
commented on review

This should not have worked considering the QML file is misnamed. Please re-check

5:19 am

vduong (deleted user)

More
Re: UI-DEN-15905-2
commented on review

Please remove empty space.

5:18 am

vduong (deleted user)

More
Re: UI-DEN-15905-2
commented on review

"compeleted" => "completed"

5:18 am

vduong (deleted user)

More
Re: UI-DEN-15905-2
commented on review

I am assuming you are purposely adding "treatmentBackClicked" signal for clarity here? The back signal from the base (EndTreatmentBase) can be detected as part of the EndTreatmentRinseBackConnect I...

I am assuming you are purposely adding "treatmentBackClicked" signal for clarity here? The back signal from the base (EndTreatmentBase) can be detected as part of the EndTreatmentRinseBackConnect Item.

5:16 am