Activity application/

8:23 am

Dara Navaei

More
9718173
changed 1 file
master, @Environement_Swith and 107 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -20
- +14
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

7:36 am

Vy <vduong@sunriselabs.com>

More
c6f6bf4
changed 1 file
master, @Environement_Swith and 104 more UI-DEN-15918-3

DEN-16037: Updated - System does not Erase Treatment Logs When Folder is Full

Remove unnecessary newline added

- -1
- +0
/sources/storage/StorageGlobals.cpp
- History
- Source
- Diff
/sources/storage/StorageGlobals.cpp

7:35 am

vduong (deleted user)

Done

7:35 am

vduong (deleted user)

After our conversation, I have changed as requested.

7:35 am

vduong (deleted user)

Changed as requested

7:35 am

vduong (deleted user)

Changed as requested

7:34 am

vduong (deleted user)

I have removed the added and using the Settings_Path()

7:24 am

Vy <vduong@sunriselabs.com>

More
2afdc76
changed 5 files
master, @Environement_Swith and 104 more UI-DEN-15918-3

DEN-16037: Updated - System does not Erase Treatment Logs When Folder is Full

Updated code based on CR requests

- add signals to follow device<device>StateChange and device<device>SpaceChange

- Add proper handling of the added signals (slots and connections)

- remove the added encrypted path and use settings_path() instead

- -19
- +42
/sources/device/DeviceController.cpp
- History
- Source
- Diff
/sources/device/DeviceController.cpp
- -4
- +20
/sources/device/DeviceController.h
- History
- Source
- Diff
/sources/device/DeviceController.h
- -2
- +51
/sources/storage/Logger.cpp
- History
- Source
- Diff
/sources/storage/Logger.cpp
- -0
- +2
/sources/storage/Logger.h
- History
- Source
- Diff
/sources/storage/Logger.h
- -2
- +0
/sources/storage/StorageGlobals.cpp
- History
- Source
- Diff
/sources/storage/StorageGlobals.cpp

5:11 am

vduong (deleted user)

More
Re: UI-DEN-15918-3
replied to vduong (deleted user)

I resolved my own message because of the conversation we had in terms of why I am making the change suggested.

7:44 am

vduong (deleted user)

I don't believe we need did * spaceChange. I am not interested in when the space changes. I am only interested when that partition gets too low on available space. Unless there is a case that you h...

I don't believe we need did * spaceChange. I am not interested in when the space changes.
I am only interested when that partition gets too low on available space. Unless there is a
case that you have which indicates otherwise.
This signal is similar to didSDCardSpaceTooLow, line 231

7:25 am

vduong (deleted user)

For SD card case, when the SD card is not ready, we update the visuals to set the "available" and "used" to 0 and emit the update. For this case, we are not updating any visuals. The need we have f...

For SD card case, when the SD card is not ready, we update the visuals to set the
"available" and "used" to 0 and emit the update. For this case, we are not updating
any visuals. The need we have for this function is to determine whether we are
low on available partition space and if we are, emit the "low" signal to handle

4:41 pm

Behrouz NematiPour

More
Re: UI-DEN-15918-3
commented on review

as has been mentioned follow the other two (USB, Sd-Card) methods naming and signature.

4:39 pm

Behrouz NematiPour

More
Re: UI-DEN-15918-3
commented on review

please follow the same naming and arguments for the did<device>SpaceChange(bool vReady, ....) did<device>StateChange( ... ) don't think we need toolow fir this one.

please follow the same naming and arguments for the
did<device>SpaceChange(bool vReady, ....)
did<device>StateChange( ... )

don't think we need toolow fir this one.

4:32 pm