application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 10 Aug 2023
3:23 pm

Vy <vduong@sunriselabs.com>

DEN-15112: Added - UI: UI Does not Display (Pending) Treatment Logs on Export Logs Screen

Add the log list model for SD card and USB in CPP

Updated the SettingLogExport QML to reflect CPP model addition

Options
    • -0
    • +2
    /denali.pro
    • -0
    • +1
    /sources/gui/GuiGlobals.cpp
    • -0
    • +4
    /sources/gui/qml/main.qml
    • -122
    • +28
    /sources/gui/qml/pages/settings/SettingsExportLogs.qml
    • -0
    • +2
    /sources/gui/qml/pages/settings/SettingsStack.qml
    • -2
    • +3
    /sources/storage/Logger.cpp
    • -0
    • +1
    /sources/storage/Logger.h
    • -0
    • +2
    /sources/view/VView.h
    • -0
    • +258
    /sources/view/settings/VLogFileListModel.cpp
    • -0
    • +101
    /sources/view/settings/VLogFileListModel.h
10:04 am

Dara Navaei

[ On Hold - P1B ] UI-DEN-16181_UI VD S103 Filemodel
[ On Hold - P1B ] UI-DEN-16181_UI VD S103 Filemodel
8:48 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
8:47 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
8:23 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
8:23 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
7:36 am

Vy <vduong@sunriselabs.com>

DEN-16037: Updated - System does not Erase Treatment Logs When Folder is Full

Remove unnecessary newline added

Options
    • -1
    • +0
    /sources/storage/StorageGlobals.cpp
7:35 am

vduong  (deleted user)

Done

Done

7:35 am

vduong  (deleted user)

After our conversation, I have changed as requested.

After our conversation, I have changed as requested.

7:35 am

vduong  (deleted user)

Changed as requested

Changed as requested

7:35 am

vduong  (deleted user)

Changed as requested

Changed as requested

7:34 am

vduong  (deleted user)

I have removed the added and using the Settings_Path()

I have removed the added and using the Settings_Path()

7:24 am

Vy <vduong@sunriselabs.com>

DEN-16037: Updated - System does not Erase Treatment Logs When Folder is Full

Updated code based on CR requests

- add signals to follow device<device>StateChange and device<device>SpaceChange

- Add proper handling of the added signals (slots and connections)

- remove the added encrypted path and use settings_path() instead

Options
    • -19
    • +42
    /sources/device/DeviceController.cpp
    • -4
    • +20
    /sources/device/DeviceController.h
    • -2
    • +51
    /sources/storage/Logger.cpp
    • -0
    • +2
    /sources/storage/Logger.h
    • -2
    • +0
    /sources/storage/StorageGlobals.cpp
5:11 am

vduong  (deleted user)

I resolved my own message because of the conversation we had in terms of why I am making the change suggested.

I resolved my own message because of the conversation we had in terms of why I am making the change suggested.

Wednesday 09 Aug 2023
7:44 am

vduong  (deleted user)

I don't believe we need did * spaceChange. I am not interested in when the space changes. I am only interested when that partition gets too low on available space. Unless there is a case that you h...

I don't believe we need did * spaceChange. I am not interested in when the space changes.
I am only interested when that partition gets too low on available space. Unless there is a
case that you have which indicates otherwise.
This signal is similar to didSDCardSpaceTooLow, line 231

7:25 am

vduong  (deleted user)

For SD card case, when the SD card is not ready, we update the visuals to set the "available" and "used" to 0 and emit the update. For this case, we are not updating any visuals. The need we have f...

For SD card case, when the SD card is not ready, we update the visuals to set the
"available" and "used" to 0 and emit the update. For this case, we are not updating
any visuals. The need we have for this function is to determine whether we are
low on available partition space and if we are, emit the "low" signal to handle

Tuesday 08 Aug 2023
4:41 pm

Behrouz NematiPour

as has been mentioned follow the other two (USB, Sd-Card) methods naming and signature.

as has been mentioned follow the other two (USB, Sd-Card) methods naming and signature.

4:39 pm

Behrouz NematiPour

please follow the same naming and arguments for the did<device>SpaceChange(bool vReady, ....) did<device>StateChange( ... ) don't think we need toolow fir this one.

please follow the same naming and arguments for the
did<device>SpaceChange(bool vReady, ....)
did<device>StateChange( ... )

don't think we need toolow fir this one.

4:32 pm

Behrouz NematiPour

we already have the same variable define as Settings_Path_Name. Please use that

we already have the same variable define as Settings_Path_Name.
Please use that

4:28 pm

Behrouz NematiPour

Why it is different than the same function for the SD-card? It is a mounted drive.

Why it is different than the same function for the SD-card?
It is a mounted drive.

4:27 pm

Behrouz NematiPour

please add //DEBUG

please add //DEBUG

2:29 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
2:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /sources/ApplicationController.cpp
    • -1
    • +1
    /sources/ApplicationController.h
    • -1
    • +1
    /sources/ApplicationPost.h
    • -1
    • +1
    /sources/gui/GuiController.cpp
    • -1
    • +1
    /sources/gui/GuiController.h
    • -1
    • +1
    /sources/main.h
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -1
    • +1
    /sources/storage/Logger.h
    • -1
    • +1
    /sources/storage/Settings.cpp
    • -1
    • +1
    /sources/storage/Settings.h
    • -1
    • +1
    /sources/view/hd/data/VTreatmentRanges.cpp
    • -1
    • +1
    /sources/view/hd/data/VTreatmentRanges.h
    • -1
    • +1
    /sources/view/settings/VAdjustmentAlarmVolume.cpp
    • -1
    • +1
    /sources/view/settings/VAdjustmentAlarmVolume.h
    • -1
    • +1
    /sources/view/settings/VDuetRoWaterDG.cpp
1:54 pm

Behrouz NematiPour

Merge branch 'DEN-15833-UI-VD-S101_POST_ConfigFilesCheck' into staging

Options
    • -29
    • +70
    /sources/ApplicationController.cpp
    • -3
    • +6
    /sources/ApplicationController.h
    • -0
    • +9
    /sources/gui/GuiController.cpp
    • -0
    • +8
    /sources/main.h
    • -0
    • +1
    /sources/storage/Logger.h
    • -11
    • +24
    /sources/storage/Settings.cpp
    • -1
    • +5
    /sources/storage/Settings.h
1:45 pm

vduong  (deleted user)

1:44 pm

Behrouz NematiPour and Tiffany Mejia

1:18 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
1:17 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
11:46 am

Behrouz NematiPour

11:28 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp