application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Nov 2023
6:08 am

Vy <vduong@sunriselabs.com>

DEN-16465: Fixed - TestSuites : Integration testing update

Fixed the unit tests to be able to compile and run

Options
    • -10
    • +19
    /unittests/tst_logging.cpp
    • -11
    • +39
    /unittests/tst_messaging.cpp
    • -205
    • +212
    /unittests/tst_models.cpp
    • -2
    • +2
    /unittests/tst_models.h
    • -334
    • +279
    /unittests/tst_views.cpp
    • -2
    • +2
    /unittests/tst_views.h
Friday 03 Nov 2023
12:37 pm

Behrouz NematiPour

12:35 pm

Behrouz NematiPour

Merge branch 'DEN-16526-UI-BN-S109-3' into staging

Options
12:29 pm

jtaylor  (deleted user) , vduong  (deleted user) , msuleiman  (deleted user) and Michael Garthwaite

12:28 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH you're welcome.

RESOLVED in CODE WALKTHROUGH
you're welcome.

12:05 pm

Behrouz NematiPour

compatibility needs the separator before the value

Options
    • -1
    • +1
    /main.cpp
12:01 pm

vduong  (deleted user)

RESOLVED

RESOLVED

12:00 pm

Behrouz NematiPour

Oh, I see, I am missing an "n". Fixed

Oh, I see, I am missing an "n".
Fixed

11:58 am

Behrouz NematiPour

Addressing code review comments

Options
    • -5
    • +5
    /sources/gui/qml/components/TouchRect.qml
11:57 am

vduong  (deleted user)

RESOLVE

RESOLVE

11:57 am

vduong  (deleted user)

Yes, that's the other typo.

Yes, that's the other typo.

11:51 am

Behrouz NematiPour

I fixed both, isn't it? that is what I see.

I fixed both,
isn't it?
that is what I see.

11:50 am

vduong  (deleted user)

You're missing an n in the "clickDeboucing" same issue with the others

You're missing an n in the "clickDeboucing" same issue with the others

11:50 am

Behrouz NematiPour

fixed, thanks for pointing that out.

fixed,
thanks for pointing that out.

11:50 am

Behrouz NematiPour

Used your exact suggestion. thanks,

Used your exact suggestion.
thanks,

11:46 am

Behrouz NematiPour

Addressing Code Review comments

Options
    • -4
    • +4
    /sources/gui/qml/AlarmItem.qml
    • -11
    • +10
    /sources/gui/qml/components/TouchRect.qml
11:36 am

jtaylor  (deleted user)

Suggestion (spell check): // When alarm status 0 is sent from HD to clear/hide the AlarmDialog, it comes with priority 0 // priority 0 has no clear definition; therefore, UI will set the coloring ...

Suggestion (spell check):

// When alarm status 0 is sent from HD to clear/hide the AlarmDialog, it comes with priority 0
// priority 0 has no clear definition; therefore, UI will set the coloring to the default system theme: blue.
// The blue color is confusing users, so we skip this coloring.

11:34 am

vduong  (deleted user)

typo for debounce in the property name and also the timer's ID.

typo for debounce in the property name and also the timer's ID.

11:30 am

jtaylor  (deleted user)

9:12 am

Dara Navaei

UI-DEN-16526-UI-BN-S109-3 [ application ]
UI-DEN-16526-UI-BN-S109-3 [ application ]
Thursday 02 Nov 2023
11:49 pm

Behrouz NematiPour

DENBUG-182 , DENBUG-185

DENBUG-185: UI shows version without period in between (ECO-11648, ECO-11616)

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

Options
    • -5
    • +11
    /main.cpp
    • -0
    • +5
    /sources/gui/qml/AlarmItem.qml
    • -5
    • +20
    /sources/gui/qml/components/TouchRect.qml
Tuesday 31 Oct 2023
6:04 pm

Behrouz NematiPour

5:37 pm

Behrouz NematiPour

Merge branch 'DEN-16526-UI-BN-S109-2' into staging

Options
9:30 am

msuleiman  (deleted user) , jtaylor  (deleted user) and vduong  (deleted user)

8:17 am

jtaylor  (deleted user)

2:06 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
1:59 am

Behrouz NematiPour

Merge branch 'DEN-16526-UI-BN-S109-2' into develop

Options
1:59 am

Behrouz NematiPour

DEN-16531: UI: The reservoir message structure has changed on FW and UI needs to adjust.

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -12
    • +0
    /sources/model/dg/data/MDGReservoirData.cpp
    • -9
    • +0
    /sources/model/dg/data/MDGReservoirData.h
    • -3
    • +0
    /sources/view/dg/data/VDGReservoirData.cpp
    • -3
    • +0
    /sources/view/dg/data/VDGReservoirData.h
1:59 am

Behrouz NematiPour

DENBUG-204: UI: The reservoir message structure has changed on FW and UI needs to adjust.

DEN-16531: UI: The reservoir message structure has changed on FW and UI needs to adjust.

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -12
    • +0
    /sources/model/dg/data/MDGReservoirData.cpp
    • -9
    • +0
    /sources/model/dg/data/MDGReservoirData.h
    • -3
    • +0
    /sources/view/dg/data/VDGReservoirData.cpp
    • -3
    • +0
    /sources/view/dg/data/VDGReservoirData.h
1:16 am

Behrouz NematiPour

DEN-16532 UI: Remove any comma from the texts being added in the Treatment Report

Options
    • -3
    • +2
    /sources/storage/TreatmentLog.cpp
    • -11
    • +13
    /sources/storage/TreatmentLog.h