Barlow-Regular.ttf

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-1710_Acknow
UI-DEN-1710_Acknow
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Updated.

Updated.

They didn't intended to be removed. Commented for a while and forget to revert back. Updated.

They didn't intended to be removed.
Commented for a while and forget to revert back.
Updated.

modified.

modified.

OCD? They where not aligned.

OCD?
They where not aligned.

What was wrong with the ; at the end of each line?

What was wrong with the ; at the end of each line?

Misspelling in word "application", also what is voved?

Misspelling in word "application", also what is voved?

Remove commented lines.

Remove commented lines.

What is this comment line for?

What is this comment line for?

UI-DEN-1710_Acknow
UI-DEN-1710_Acknow
DEN-1437 : Implementation

- Added concurrent in Project as document says. I don't know why it's required since it was working event without adding it. Added anyway.

- Added required fonts as part of the repo. They should not be added as resources since they are huge and make application unnecessary big and is not required and should be referred to as a real file not as a qrc:/ .

  1. … 18 more files in changeset.
RESOLVED

RESOLVED

Leo, Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will r...

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

seems like when I replied the emails were not working Just as a reminder.

seems like when I replied the emails were not working
Just as a reminder.

Thanks for the comment. static class member variable can not be initialized in header. Please take a look at the applicationcontroller.cpp@21. It has been initialized with nullptr. Note : To see ...

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

initialize with nullptr for consistency

initialize with nullptr for consistency