application / sources

canbus

Clone Tools

Stats

Commits this week: 2
Total Committers: 10
Last Commit: 11:09
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Jun 2023
8:20 pm

Behrouz NematiPour

DEN-15737 UI: Call the lockdown.sh before quits

- DEN-15402 is disabled for now, just to release the Cybersecurity release

# I set to always enabled for now to always go to the manufacturing mode

# 1 - Even for normal setup start is moving files to /home/root, so the lockdown needs to run to move files.

# 2 - The UI still needs to be executed to decrypt the /var/configurations, otherwise the configurations can not be updated,

# and I don't have the ability to just decrypt and exit right now.

# Note: after the Cybersecurity release I will improve the user experience and will make it easier for manufacturing.

Options
    • -0
    • +2
    ./CanInterface.cpp
    • -0
    • +1
    ./CanInterface.h
  3. … 12 more files in changeset.
Thursday 22 Jun 2023
2:46 pm

Behrouz NematiPour

[~pvedantam] The Ethernet POST is not a requirement, and if it fails UI will not fail the POST.

[~pvedantam]
The Ethernet POST is not a requirement, and if it fails UI will not fail the POST.

11:19 am

pvedantam  (deleted user)

It appears that we are checking string fields of the ethernet driver and not performing a POST for the driver, is that being performed elsewhere ?, for example ethtool or similar

It appears that we are checking string fields of the ethernet driver and not performing a POST for the driver, is that being performed elsewhere ?, for example ethtool or similar

10:41 am

pvedantam  (deleted user)

The comment " Exit code is not used", if case of a failure, what would be the state of the instrument ?

The comment " Exit code is not used", if case of a failure, what would be the state of the instrument ?

Tuesday 20 Jun 2023
5:16 pm

pvedantam  (deleted user)

Bruce as we had discussed, please investigate if we forking the CAN, BT, WiFI, Touchscreen helps from a startup time, i.e. the individual process could wait for a certain state to happen or you cou...

Bruce as we had discussed, please investigate if we forking the CAN, BT, WiFI, Touchscreen helps from a startup time, i.e. the individual process could wait for a certain state to happen or you could reorder the startup sequence.

4:06 pm

pvedantam  (deleted user)

Please add function headers as needed

Please add function headers as needed

3:59 pm

pvedantam  (deleted user)

It would be nice to be consistent on the casing of the messages, "YES" , "NO" or "Yes" / "No"

It would be nice to be consistent on the casing of the messages, "YES" , "NO" or "Yes" / "No"

3:41 pm

Behrouz NematiPour

2:38 pm

jishii  (deleted user)

5:33 am

vduong  (deleted user)

missing doxygen comment

missing doxygen comment

5:31 am

vduong  (deleted user)

Doxygen comment incorrect for below function

Doxygen comment incorrect for below function

5:30 am

vduong  (deleted user)

This comment is incorrect

This comment is incorrect

5:29 am

vduong  (deleted user)

"reenalbe" -> "reenable"

"reenalbe" -> "reenable"

5:23 am

vduong  (deleted user)

"trasnlated" - > "translated"

"trasnlated" - > "translated"

5:23 am

vduong  (deleted user)

Very minor, but do you want this to be "eError_No_SettingsFile" where settings is plural?

Very minor, but do you want this to be "eError_No_SettingsFile" where settings is plural?

5:22 am

vduong  (deleted user)

Missing doxygen comment

Missing doxygen comment

5:01 am

vduong  (deleted user)

Function name here does not match the actual function

Function name here does not match the actual function

4:58 am

vduong  (deleted user)

typo, "Continueing" -> "Continuing"

typo, "Continueing" -> "Continuing"

Wednesday 14 Jun 2023
8:01 pm

Behrouz NematiPour

I created a case for this, please resolve and we will follow up under the case is being displayed above ( DEN-15646 ).

I created a case for this,
please resolve and we will follow up under the case is being displayed above ( DEN-15646 ).

6:35 am

vduong  (deleted user)

RESOLVED

RESOLVED

6:35 am

vduong  (deleted user)

RESOLVED

RESOLVED

6:34 am

vduong  (deleted user)

RESOLVED

RESOLVED

6:34 am

vduong  (deleted user)

RESOLVED

RESOLVED

6:34 am

vduong  (deleted user)

RESOLVED

RESOLVED

6:34 am

vduong  (deleted user)

RESOLVED

RESOLVED

Tuesday 13 Jun 2023
1:01 pm

vduong  (deleted user)

RESOLVED

RESOLVED

Monday 12 Jun 2023
1:54 am

Behrouz NematiPour

Thanks, Fixed.

Thanks,
Fixed.

1:54 am

Behrouz NematiPour

Thanks, Fixed.

Thanks,
Fixed.

1:53 am

Behrouz NematiPour

Thanks, Fixed.

Thanks,
Fixed.

1:53 am

Behrouz NematiPour

Thanks, Fixed.

Thanks,
Fixed.