application / sources / gui / qml

components

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 03 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Mar 2023
6:52 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start: Arrows - Additional changes based on Behrouz's feedback

Options
    • -2
    • +4
    ./SliderCreateTreatment.qml
  2. … 4 more files in changeset.
Monday 13 Mar 2023
2:08 pm

Behrouz NematiPour

RESOLVED. Thanks for the test, that is what I remembered. Fine then

RESOLVED.

Thanks for the test, that is what I remembered.
Fine then

2:02 pm

Behrouz NematiPour

1 - The component instance has been used in the same file, and that is the new feature, and previously we have to create a file to use the component instance, or directly return the created compone...

1 - The component instance has been used in the same file, and that is the new feature, and previously we have to create a file to use the component instance, or directly return the created component for one instance use.
2 - The Loader is used inside of the component, which doesn't seem right, the idea is to use inline components so, if possible, avoid loaders.
3 - Multiple components for the line tickmarks and round ones are created since it seems only a property change to make it rounded, since QML doesn't have a line or circle and all are Rectangle, it makes sense to update the underlying rectangle properties to get the desired shape.

1:43 pm

Behrouz NematiPour

Thanks, Sorry for the confusion. Yes, please, as we talked, the active progress should be orange, and the background I think can stay as it was. Then you can remove that extra Rectangle.

Thanks,
Sorry for the confusion.
Yes, please, as we talked, the active progress should be orange, and the background I think can stay as it was.
Then you can remove that extra Rectangle.

1:00 pm

vduong  (deleted user)

This may be a new concept for the project, but it's something that I've used and have seen used before in other QML projects. This also guarantees that you are only loading the object when you nee...

This may be a new concept for the project, but it's something that I've used and have seen used before in other QML projects.

This also guarantees that you are only loading the object when you need it when you use it with the Loader.

The Component itself, if you look at the Qt documentation, you will find "The component encapsulates the QML types within, as if they were defined in a separate QML file, and is not loaded until requested (in this case, by the two Loader objects)."

So, I am sure this is efficient.

12:56 pm

vduong  (deleted user)

We had this discussion this morning, I have already tested it also. It is working as we expected. It only prints out the round tick's Component.onCompleted log messages of the round tick marks and ...

We had this discussion this morning, I have already tested it also. It is working as we expected. It only prints out the round tick's Component.onCompleted log messages of the round tick marks and not both the round and lined tick marks. This is operating as we expected.

12:55 pm

vduong  (deleted user)

Ok, easy change over.

Ok, easy change over.

12:55 pm

vduong  (deleted user)

We had a discussion about what needed to be done and you had mentioned that the progressRect would be transparent. In order for that to be transparent, we needed a background rectangle color. BUT w...

We had a discussion about what needed to be done and you had mentioned that the progressRect would be transparent. In order for that to be transparent, we needed a background rectangle color. BUT we had talked this morning and I will remove this rectangle and just set the progress rect's color as w/e the active color is.

12:54 pm

vduong  (deleted user)

I believe this is leftover code that I missed from the slider bug fixes. I'll remove it for this branch.

I believe this is leftover code that I missed from the slider bug fixes. I'll remove it for this branch.

10:26 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start - Arrows - Modify code based on feedback from Behrouz -- take out the CircleButton and make use of TouchRect -- Add left and right arrow images

Options
    • -62
    • +0
    ./CircleButton.qml
    • -0
    • +99
    ./SliderArrows.qml
    • -42
    • +9
    ./SliderCreateTreatment.qml
  4. … 4 more files in changeset.
5:19 am

Behrouz NematiPour

Why was this Rectangle added? the ProgressRect is a Rectangle and can be used for the active color, and the _progressRectBackground seems redundant.

Why was this Rectangle added?
the ProgressRect is a Rectangle and can be used for the active color, and the _progressRectBackground seems redundant.

5:18 am

Behrouz NematiPour

Why was this property added?

Why was this property added?

4:45 am

Behrouz NematiPour

Regarding our new design change requests all tick marks shall be round by default.

Regarding our new design change requests all tick marks shall be round by default.

4:33 am

Behrouz NematiPour

Why In-Line Component is used. The idea behind the loader is to set them active if only it is set active. Does the in-line component have the same efficiency? Please test and provide proof of conce...

Why In-Line Component is used.
The idea behind the loader is to set them active if only it is set active.
Does the in-line component have the same efficiency?
Please test and provide proof of concept, since this feature is very new and I haven't tested it.
If can't be proven, use the loader only, please.

4:24 am

Behrouz NematiPour

In C++ the trinary "?" operator will call both true and false sections and then will decide which to return. If that is the case for the QML/JS I suggest using a function with an if block to return...

In C++ the trinary "?" operator will call both true and false sections and then will decide which to return.
If that is the case for the QML/JS I suggest using a function with an if block to return the decided object.
to ensure the trinary "?" operator behavior, you can use the "Component.onCompleted: {", if the new Qt 5.15 in-line Component declaration supports it.

Sunday 12 Mar 2023
12:58 pm

Vy <vduong@sunriselabs.com>

DEN-14912: Quick Start - Arrows - Update logic to increment/decrement on button press

Options
    • -6
    • +10
    ./Slider.qml
Saturday 11 Mar 2023
7:33 am

Vy <vduong@sunriselabs.com>

DEN-14912: Quick Start - Arrows - Add implementation for value increment/decrement buttons

Options
    • -0
    • +62
    ./CircleButton.qml
    • -0
    • +33
    ./Slider.qml
    • -1
    • +50
    ./SliderCreateTreatment.qml
  4. … 4 more files in changeset.
5:24 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start : Sliders - Refinement of the rangeSlider's look for quick start

Options
    • -3
    • +10
    ./RangeSlider.qml
  2. … 1 more file in changeset.
Friday 10 Mar 2023
11:55 pm

Vy <vduong@sunriselabs.com>

DEN-14912: Quick Start Sliders -Improvement to the rangeSlider's look and feel for quick start

Options
    • -1
    • +1
    ./RangeRect.qml
    • -3
    • +10
    ./RangeSlider.qml
    • -1
    • +1
    ./TickMarks.qml
  4. … 2 more files in changeset.
6:01 pm

Dara Navaei

UI-DEN-14909_UI VD S92 QS Arrows
UI-DEN-14909_UI VD S92 QS Arrows
6:01 pm

Dara Navaei

UI-DEN-14909_UI VD S92 QS Sliders
UI-DEN-14909_UI VD S92 QS Sliders
5:48 pm

Vy <vduong@sunriselabs.com>

DEN-14912: Quick Start - Sliders - Improvements to the sliders look and feel for the quick start

Options
    • -4
    • +6
    ./RangeRect.qml
    • -29
    • +29
    ./Slider.qml
    • -2
    • +3
    ./SliderCreateTreatment.qml
    • -18
    • +72
    ./TickMarks.qml
  5. … 2 more files in changeset.
2:57 pm

Vy <vduong@sunriselabs.com>

DEN-13971 Adjust handle behavior on first drag

Options
    • -16
    • +1
    ./Slider.qml
10:58 am

Vy <vduong@sunriselabs.com>

DEN-13971 Remove unused/commented out code

Options
    • -3
    • +0
    ./Slider.qml
10:53 am

Vy <vduong@sunriselabs.com>

DEN-13971 Refinement to activation of slider handle and value setting

Options
    • -6
    • +27
    ./Slider.qml
    • -6
    • +4
    ./SliderCreateTreatment.qml
Thursday 09 Mar 2023
11:33 am

vduong  (deleted user)

Can you check on the latest commit if this space was already removed? I can't tell which line this comment is in regards to. Thanks!

Can you check on the latest commit if this space was already removed? I can't tell which line this comment is in regards to. Thanks!

9:48 am

Vy <vduong@sunriselabs.com>

DEN-14838 Remove debugging printout

Options
    • -1
    • +0
    ./Slider.qml
9:45 am

Vy <vduong@sunriselabs.com>

DEN-14838 CR Comment changes

Options
    • -15
    • +6
    ./RangeRect.qml
    • -1
    • +1
    ./Slider.qml
9:41 am

vduong  (deleted user)

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

9:39 am

vduong  (deleted user)

This is after the text property. I removed the newline between them as a change

This is after the text property. I removed the newline between them as a change