components

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-17157: Update_Denali_Application_for_Dry_Demo

- Addressed the code review comments.

  1. … 7 more files in changeset.
Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

please add //DEBUG: to comment this out.

please add //DEBUG: to comment this out.

please align arguments.

please align arguments.

please remove extra space before DRY_...

please remove extra space before DRY_...

I believe you should correct the other z-orders.

I believe you should correct the other z-orders.

same here as above. *same here as above.
  • same here as above.
  • same here as above.
is there a specific reason the notSetVariable function is not used and replaced with "__"?

is there a specific reason the notSetVariable function is not used and replaced with "__"?

please do the same as the comment in the following link: http://devapps.diality.us:8060/cru/UI-DEN-17157-1#c21568

please do the same as the comment in the following link:
http://devapps.diality.us:8060/cru/UI-DEN-17157-1#c21568

please align the " ,2"

please align the " ,2"

please define these numbers (on other lines as well) as a: readonly property <type of the value> <name of the propery> example: on top: readonly property int bloodFlowRateDef : 400 replace with: d...

please define these numbers (on other lines as well) as a:
readonly property <type of the value> <name of the propery>
example:
on top:

readonly property int bloodFlowRateDef : 400

replace with:

defaultValue: _GuiView.dryDemoMode ? _root.bloodFlowRateDef : vTreatmentRanges.bloodFlowRateDef
Please put a comment here for next developer to avoid confusion: /* It is only for the dry-demo due to its independent flow. Otherwise, won't needed in the normal designed user-flow. */

Please put a comment here for next developer to avoid confusion:
/*
It is only for the dry-demo due to its independent flow.
Otherwise, won't needed in the normal designed user-flow.
*/

same here

same here

Make it like GridSelection.qml @ L54.

Make it like GridSelection.qml @ L54.

LEAH-1976: implement-a-simple-video-screen

Added Video Screen with button-controller with transition animation

Temporary:

The screen can be accessed by clicking on the "SD" icon

The test video is stored in "/home/denali/videos/

    • -0
    • +211
    ./VideoScreen.qml
  1. … 4 more files in changeset.
UI-LEAH-1976_Feature/Leah 1976 Implement A Simple Video Screen
UI-LEAH-1976_Feature/Leah 1976 Implement A Simple Video Screen
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 605 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 605 more files in changeset.
DEN-17157: Update_Denali_Application_for_Dry_Demo

- Updated the UI application to support dry demo

  1. … 2 more files in changeset.