application / sources / gui

qml

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 10 Feb
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 May 2021
7:59 pm

Behrouz NematiPour

DEN-8319: TxLog: Code Review 0

Options
    • -1
    • +1
    ./pages/TreatmentFlowBase.qml
    • -5
    • +5
    ./pages/UserConfirmation.qml
  3. … 4 more files in changeset.
2:08 pm

Behrouz NematiPour

It's like running the cppcheck script that we keep the outputs.

It's like running the cppcheck script that we keep the outputs.

2:07 pm

Behrouz NematiPour

Correct, A repository will be created for this tool very soon, but still, the executable will be here regardless.

Correct,
A repository will be created for this tool very soon, but still, the executable will be here regardless.

1:52 pm

Behrouz NematiPour

It's like running the cppcheck script that we keep the outputs.

It's like running the cppcheck script that we keep the outputs.

1:38 pm

Behrouz NematiPour

As we had a conversation, the V&V request can be covered in the effort of the three stacks checking their versions and compatibility, then a message can be sent over the HD channel.

As we had a conversation, the V&V request can be covered in the effort of the three stacks checking their versions and compatibility, then a message can be sent over the HD channel.

1:35 pm

Behrouz NematiPour

Added a FIXME which is more important than TODO. Updated

Added a FIXME which is more important than TODO.
Updated

1:34 pm

Behrouz NematiPour

Updated

Updated

1:34 pm

Behrouz NematiPour

Updated

Updated

1:34 pm

Behrouz NematiPour

Updated

Updated

11:17 am

pmontazemi  (deleted user)

remove the before anything

remove the before anything

11:16 am

pmontazemi  (deleted user)

does not (instead of doesn't)

does not (instead of doesn't)

11:16 am

pmontazemi  (deleted user)

change (instead of changed)

change (instead of changed)

11:12 am

pmontazemi  (deleted user)

Add TODO

Add TODO

9:06 am

plucia  (deleted user)

V&V has requested to be able to get the version from the UI using dialin to automate their testing

V&V has requested to be able to get the version from the UI using dialin to automate their testing

9:01 am

plucia  (deleted user)

The UI is already talking with Dialin. Your simulator is using dialin to talk to the UI. Because the UI doesn't recognize Dialin at all, Dialin has to talk on the HD to UI or DG to UI channels inst...

The UI is already talking with Dialin. Your simulator is using dialin to talk to the UI.
Because the UI doesn't recognize Dialin at all, Dialin has to talk on the HD to UI or DG to UI channels instead when sending up commands to the UI.
This poses a security risk because the UI could never restrict communication to just the DG/HD only. If Dialin can talk to the UI on separate channels then those channels can be ignored in production mode later.

It's your stack so your call but something I think we should consider

8:51 am

Behrouz NematiPour

If we decide UI to talk with Dialin we need to add Dialin channels later, but it is not the case now.

If we decide UI to talk with Dialin we need to add Dialin channels later, but it is not the case now.

8:49 am

Behrouz NematiPour

On the UI side, we have no plan, for now, to listen to Dialin.

On the UI side, we have no plan, for now, to listen to Dialin.

8:44 am

plucia  (deleted user)

These definitions force dialin to talk on an HD/DG channels in order to simulate the UI. Seems like a security risk and that the UI should be able to tell the difference.

These definitions force dialin to talk on an HD/DG channels in order to simulate the UI. Seems like a security risk and that the UI should be able to tell the difference.

8:18 am

plucia  (deleted user)

Dialin is a known CAN source.

Dialin is a known CAN source.

8:07 am

plucia  (deleted user)

The dialin usage is incorrect here. Please see my comments in the dialin code review.

The dialin usage is incorrect here. Please see my comments in the dialin code review.

7:13 am

plucia  (deleted user)

The bytearray conversions need to be inside the dialin function

The bytearray conversions need to be inside the dialin function

7:13 am

plucia  (deleted user)

The bytearray conversions need to be inside the cmd_send_post_treatment_log_response function

The bytearray conversions need to be inside the cmd_send_post_treatment_log_response function

7:00 am

plucia  (deleted user)

I assume this is just the stderr output from running alarmMapping. Is there a reason why it needs to be part of the repository?

I assume this is just the stderr output from running alarmMapping. Is there a reason why it needs to be part of the repository?

6:59 am

plucia  (deleted user)

Should the log file be added to the repository?

Should the log file be added to the repository?

6:58 am

plucia  (deleted user)

Shouldn't the source code be added to the repository instead of the binary file?

Shouldn't the source code be added to the repository instead of the binary file?

6:56 am

plucia  (deleted user)

Copyright is missing

Copyright is missing

6:56 am

plucia  (deleted user)

Copyright is missing

Copyright is missing

6:55 am

plucia  (deleted user)

The copyright is missing

The copyright is missing

6:55 am

plucia  (deleted user)

The copyright is missing

The copyright is missing

6:53 am

plucia  (deleted user)

Docstring is missing

Docstring is missing