application / sources

gui

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 27 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 May 2021
2:49 pm

Peter Lucia <plucia@diality.com>

DEN-8064: Addressed code review comments

Options
    • -1
    • +0
    ./GuiGlobals.h
  2. … 5 more files in changeset.
2:49 pm

plucia  (deleted user)

Fixed

Fixed

2:49 pm

plucia  (deleted user)

Done

Done

1:06 pm

plucia  (deleted user)

That works too. No need for tee here. I've updated it

That works too. No need for tee here. I've updated it

12:59 pm

plucia  (deleted user)

I think VDateTime.h is less safe in this case. It should be updated to match if (_process.state() != QProcess::NotRunning) { return; } to prevent re-starting the process when its already in the "S...

I think VDateTime.h is less safe in this case. It should be updated to match 

if (_process.state() != QProcess::NotRunning) { return; }

to prevent re-starting the process when its already in the "Starting" state as well as the "Running" state.

    enum ProcessState {
        NotRunning,
        Starting,
        Running
    };
12:51 pm

plucia  (deleted user)

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

12:51 pm

plucia  (deleted user)

AlarmVolumeTemp has been removed

AlarmVolumeTemp has been removed

12:51 pm

plucia  (deleted user)

It is removed now

It is removed now

12:50 pm

plucia  (deleted user)

Done

Done

12:50 pm

Peter Lucia <plucia@diality.com>

DEN-8064: Addressed code review comments

Options
    • -0
    • +1
    ./GuiGlobals.h
    • -16
    • +16
    ./qml/pages/SettingsAlarmVolume.qml
    • -2
    • +2
    ./qml/pages/SettingsBluetooth.qml
    • -4
    • +4
    ./qml/pages/SettingsBrightness.qml
    • -2
    • +2
    ./qml/pages/SettingsDateTimeSet.qml
    • -2
    • +2
    ./qml/pages/SettingsDeviceInformation.qml
    • -8
    • +7
    ./qml/pages/SettingsHome.qml
    • -2
    • +2
    ./qml/pages/SettingsWifi.qml
  9. … 10 more files in changeset.
4:27 am

Behrouz NematiPour

DEN-8316: TxLog: Implementation [Simulator/Testing]

Options
    • -0
    • +6
    ./GuiView.cpp
    • -1
    • +5
    ./GuiView.h
    • -1
    • +0
    ./qml/SDItem.qml
    • -3
    • +3
    ./qml/components/Circle.qml
    • -5
    • +5
    ./qml/components/ExportButton.qml
    • -0
    • +18
    ./qml/components/TouchRect.qml
    • -1
    • +3
    ./qml/components/USBButton.qml
    • -5
    • +6
    ./qml/pages/disinfect/DisinfectBase.qml
    • -5
    • +6
    ./qml/pages/posttreatment/PostTreatmentBase.qml
    • -73
    • +8
    ./qml/pages/posttreatment/PostTreatmentReview.qml
    • -8
    • +9
    ./qml/pages/posttreatment/PostTreatmentStack.qml
    • -5
    • +7
    ./qml/pages/pretreatment/PreTreatmentBase.qml
  13. … 42 more files in changeset.
Friday 30 Apr 2021
1:46 pm

plucia  (deleted user)

UI-DEN-7529_Service Mode
UI-DEN-7529_Service Mode
Thursday 29 Apr 2021
2:38 pm

Behrouz NematiPour

DEN-8303 Meeting & Support - General Purpose

- Adding two other Alarms parameters to the log

- Fixed the ProgressCircle component circle color.

- Adding a simple detail screen for the Treatment Log Review screen

- Popping up the keyboard when get into the Date/Time screen.

-

Options
    • -0
    • +2
    ./GuiGlobals.h
    • -1
    • +1
    ./qml/components/ProgressCircle.qml
    • -0
    • +4
    ./qml/pages/posttreatment/PostTreatmentReview.qml
    • -0
    • +10
    ./qml/pages/posttreatment/PostTreatmentStack.qml
    • -0
    • +5
    ./qml/pages/settings/SettingsDateTime.qml
    • -1
    • +2
    ./qml/pages/settings/SettingsStack.qml
  7. … 5 more files in changeset.
11:37 am

Behrouz NematiPour

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used. So it would be better to have key or value as QStringList properties and change these prop...

As it seems in the qml these properties are not used directly in UI and only the key/value pairs are used.
So it would be better to have key or value as QStringList properties and change these properties to just values.

11:34 am

Behrouz NematiPour

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

11:32 am

Behrouz NematiPour

please put tr() for translation.

please put tr() for translation.

11:32 am

Behrouz NematiPour

please put tr() for translation.

please put tr() for translation.

11:24 am

Behrouz NematiPour

The one which has been used in the VDateTime is much cleaner: if (_process.state() == QProcess::Running) { return; }

The one which has been used in the VDateTime is much cleaner:

if (_process.state() == QProcess::Running) {
    return;
}
11:18 am

Behrouz NematiPour

please move it in an appropriate folder(hd/adjustment)

please move it in an appropriate folder(hd/adjustment)

11:17 am

Behrouz NematiPour

please move it in an appropriate folder(dg/adjustment)

please move it in an appropriate folder(dg/adjustment)

11:11 am

Behrouz NematiPour

Where it is used?

Where it is used?

11:09 am

Behrouz NematiPour

please change this to eDG.

please change this to eDG.

11:07 am

Behrouz NematiPour

Please use 'fontPixel' prefix for your font's pixelSize variables to distinguish between the different properties of the font.

Please use 'fontPixel' prefix for your font's pixelSize variables to distinguish between the different properties of the font.

10:56 am

Behrouz NematiPour

Please don't use "%0" as we discussed.

Please don't use "%0" as we discussed.

10:54 am

Behrouz NematiPour

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

10:51 am

Behrouz NematiPour

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

10:48 am

Behrouz NematiPour

Was there a reason the tee command is being used, instead of simply using > like : echo "$1" > /sys/class/backlight/backlight-mipi/brightness ?

Was there a reason the tee command is being used, instead of simply using > like :

echo "$1" > /sys/class/backlight/backlight-mipi/brightness

?

10:30 am

Behrouz NematiPour

What is this line used for?

What is this line used for?

10:24 am

Behrouz NematiPour

Interesting. Why it is a broadcast instead of a request/response? Why does UI need a broadcast message while it will always be adjusted by UI?

Interesting.
Why it is a broadcast instead of a request/response?
Why does UI need a broadcast message while it will always be adjusted by UI?

10:18 am

plucia  (deleted user)

It prevents updates to alarmVolume by the HD broadcast while we're editing the alarm volume. Otherwise, alarmVolume could be incorrectly updated by an HD broadcast of a set alarm volume that the us...

It prevents updates to alarmVolume by the HD broadcast while we're editing the alarm volume.
Otherwise, alarmVolume could be incorrectly updated by an HD broadcast of a set alarm volume that the user decided to cancel.