application / sources

gui

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 23 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 29 Jul 2023
8:16 pm

Behrouz NematiPour

DEN-15548: UI: Send alarm 178 on CAN (also log alarm 178)

- added the log for the Alarm UI generates (178) to be displayed on the screen, which is not actually send on the CANBus.

- I did not created another extra AlarmStatus request Model, since it is not necessary t o send this message over the CANBus, and it would be lots of unnecessary code for an unnecessary action (sending the message over the CANBus ) since the nature of the message actually is to be sent when there is no HD to ack UI messages.

Options
    • -3
    • +4
    ./GuiController.cpp
    • -0
    • +11
    ./qml/components/NotificationBar.qml
    • -0
    • +1
    ./qml/main.qml
  4. … 10 more files in changeset.
Friday 28 Jul 2023
2:03 pm

Dara Navaei

DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
1:13 pm

msuleiman  (deleted user) and vduong  (deleted user)

12:27 pm

Behrouz NematiPour

these are the removed/red lines. the added/green lines and not-changed/white lines are alinged.

these are the removed/red lines.
the added/green lines and not-changed/white lines are alinged.

10:47 am

vduong  (deleted user)

10:39 am

Behrouz NematiPour

for arterial and venous pressure values we align them to the right. this is correct.

for arterial and venous pressure values we align them to the right.
this is correct.

10:38 am

Behrouz NematiPour

for arterial and venous pressure values we align them to the right. this is correct.

for arterial and venous pressure values we align them to the right.
this is correct.

10:24 am

msuleiman  (deleted user)

10:21 am

Behrouz NematiPour

10:21 am

Behrouz NematiPour

9:49 am

msuleiman  (deleted user)

code alignment

code alignment

9:48 am

msuleiman  (deleted user)

code alignment

code alignment

9:47 am

msuleiman  (deleted user)

code alignment

code alignment

5:36 am

vduong  (deleted user)

Changed

Changed

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Changed based on how GuiView handles the connection from a created-in-QML object.

Changed based on how GuiView handles the connection from a created-in-QML object.

5:33 am

Vy <vduong@sunriselabs.com>

DEN-15487: Updated - UI: POST: UI needs to report an error if the configuration files, or parameter(s) are missing.

Updated with changes per CR request

Options
    • -0
    • +9
    ./GuiController.cpp
    • -0
    • +3
    ./GuiController.h
  3. … 3 more files in changeset.
5:00 am

vduong  (deleted user)

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

4:46 am

vduong  (deleted user)

RESOLVED

RESOLVED

1:46 am

Behrouz NematiPour

this is incorrect connection usage. it should be moved to the applicationController class. The rule of API design: *the API is just emitting the signal *and is not responsible for the usage. *an...

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

1:41 am

Behrouz NematiPour

please check, lists are not empty. can be checked by private member variable: isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

please check, lists are not empty.
can be checked by private member variable: 

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
1:38 am

Behrouz NematiPour

add an empty line before and after

add an empty line before and after

1:34 am

Behrouz NematiPour

please align SIGNAL(did SLOT( on

please align
SIGNAL(did
SLOT( on

1:33 am

Behrouz NematiPour

please do not use else. make it like the others on top. Look at lines 79 - 83. And insert it in between lines 89,90 with two empty line on top and bottom of the if block if ( ! codition ) { err ...

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block 

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks

1:11 am

Behrouz NematiPour

yes, to easily checkout on all the relevant repositories.

yes, to easily checkout on all the relevant repositories.

1:07 am

Behrouz NematiPour

DEN-15812: UI: Add an option on the Configurations setup screen to prevent the Device Registration cleanup

- Managed the Settings/System.conf owner

Options
    • -3
    • +7
    ./qml/pages/settings/SettingsStack.qml
  2. … 3 more files in changeset.
Thursday 27 Jul 2023
4:49 am

vduong  (deleted user)

Was this intentionally added for the pre-build steps ?

Was this intentionally added for the pre-build steps ?

Wednesday 26 Jul 2023
4:03 pm

Dara Navaei

UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
9:13 am

vduong  (deleted user)